There are two problems when passing a non-absolute path to the -b flag:
1. It ends up being used in "./configure --prefix=${base_dir}".
configure fails, because the prefix must be absolute.
2. It ends up being used to set up symlinks, leading to broken links.
Making the install path absolute fixes those.
Change-Id: I7c1d22754c1a788f02cd912f2114cc091951b303
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
The GdbFullCliConsole has id: GdbFullCliConsole.#ContextMenu
The GdbBasicCliConsole has id: GdbBasicCliConsole.#ContextMenu
The commit also adds an example of adding a new button to those menus in
org.eclipse.examples.dsf.gdb
Change-Id: If9579e3e60524f39a332df868f512c5f457043ed
Due to a GDB bug present in numerous versions of GDB
https://sourceware.org/bugzilla/show_bug.cgi?id=19637
CDT can fail to display advanced memory info and
registers view properly.
This fix is more lenient, and if the user really wants
to see the registers, a workaround for GDB's bug is linked
to.
Change-Id: Ia78947e29a1e446837ef992d470dfd14f047bda2
When building all gdb versions, the older ones have
a greater chance of failing, so should be done last.
Change-Id: I8bb2f600d84cc7a8f97c308995c174124d881d8d
We use the $version variable in the check_supported function, but it is
not set. It happens to work because we use the same variable name in
the outer scope, where check_supported is called.
Change-Id: I75e8ae4ef42a232174accf88ca146c0e427f8d4e
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Commit 6335a5c2ba reverted
a previous commit which made the changes being reverted
here unecessary.
This reverts commit 896eba55c5.
Change-Id: I890a67513b35df7708f9fc33c0be3e879fdb9e0e
Includes splitting out and expanding CommandLineArgsTest
from LaunchConfigurationAndRestartTest.
Change-Id: I19fa97a847d908c1c780ca767cf688f26a51d684
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
In all-stop mode for a remote session, it's not possible to have the
target switch thread, while the target is running. At the moment, the
GDB focus synchronizer attempts to switch the thread in that case, when
the user switches thread in the Debug View, which can fail and ends-up
logging an error.
This patch silences this error.
Change-Id: Ib21347fe9f4c31b3a42b4a83d289dbcd10b74a07
The previous all-stop implementation use Ctrl-C (variants) to suspend
the target program. This option is not supported when using the new
GDB full CLI console provided in GDB 7.12.
So the alternative is to send the mi command -exec-interrupt to suspend
the target, however this option requires the use of target async-on mode
(already in use for non stop mode).
This update makes all-stop mode use target async mode when using
versions higher or equal to GDB 7.12.
This update also removes the non-stop mode restriction initially
implemented for the use of the new GDB Full CLI console.
Change-Id: Iabef20bdee814d413fc338f9ec8c2d99d6311c20
This commit introduces a PersistentPTY. By using it, we now allow the
user to restart the process from the GDB console (by pressing 'run').
In this case, the I/O will continue using the PersistentPTY.
Previously, the PTY would have been closed, and GDB would fail to
restart the process because it would fail to use the closed PTY.
Change-Id: I395b402e297a2043af8fce33df163eddef9e6c7a
This patch synchronizes the GDB focus when the user selects a process
node in the DV.
When the user selects a new process (inferior) from the GDB console, we
are already synchronizing the DV to the thread/frame that GDB selects
from that process.
Change-Id: I11dfd175d51ec49e969f4d07288f80f7ea72a3e1
When a new launch is triggered and a new GDB console created, it was
shown automatically. However, if there was a current debug session
where the selection was a stack frame, our sticky policy
(DefaultDsfSelectionPolicy) prevents the new session from being
selected, so the new GDB console shown didn't match the selection in the
DV.
With this patch, when a new GDB console is created, we don't show it
automatically, but let other logic figure out if it should be shown or
not.
Change-Id: If826677a6fb0f925f6b397a13f61fc75fc892748
Make sure Core Build handles the properties set by these tabs
correctly. A bunch of string externalization too.
Change-Id: I54a61b4d2520a0952c43608169747e792826062e
- Reuse the TU from the open editor if present, otherwise load it from
workspace
- Added test plugin org.eclipse.cdt.codan.checkers.ui.test
Change-Id: I725b7b8e462ffba39dd6c9a828ab72dd58f86b1f
Signed-off-by: Dominic Scharfe <dominic.scharfe@coseda-tech.com>
This adds a new service, GDBFocusSynchronizer, that helps keep the
internal GDB selection and the Debug View selection synchronized.
Change-Id: I021b3f65d61e82f6971bdb9232369b6fdf58ea5b
Adds gdb launching for Core Build launches. A common class is created
for things common to run and debug (and probably others).
At the bin directory containing qmake to the PATH var for builds and
launches since that's where the DLLs are.
Adds method and variable to GDBLaunch to override the default
environment.
Change-Id: I3ab3b48a2f99eaed50cdb4cfdc03959e9700abc5
The org.eclipse.cdt.launch.remote feature is the only non-source,
non-sdk feature to include the corresponding source plugin for it's main
provided plugin. An org.eclipse.cdt.launch.remote source-feature should
be created to provide the source plugin.
Change-Id: I2e396270f0d19f023e75452c316da0e4eda495b1
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Most GDB MI commands support the "--thread" and "--frame" options, that
tells GDB on which thread/stack frame the command is meant to act-on.
For those that don't, CDT has a mechanism to first have GDB switch
thread (MIThreadSelect) or frame (MIStackSelectFrame), before issuing
the command that will act on that entity. Ironically, those two commands
are wrongly identified as not supporting those parameters, and so are
sometimes sent in duplicate, when a single command including the thread
or frame would be possible. This commit correctly identifies those
commands as supporting the thread/frame parameter.
Change-Id: I6e7fc4e873abe36ad024c7131efda7c0aa89dc44
Since users don't usually care about seeing the communication between
CDT and GDB, we should not show it by default. However, once a problem
happens it would be nice to be able to look at the traces even if they
were previously hidden.
This patch has the gdb traces always enabled, but hides the actual
console from the user. When the user enables the traces, they will be
shown in the Console view, with all previous traces available.
Change-Id: Ifd312aa19e4421b6764169b6199b5e935cf25f87
When a second config is added, the binary parsers wasn't getting
reset so the new binary parser wasn't getting called.
Also cleans up the reset to remove the close that happens. Not sure
why it was needed so will keep an eye out for new bad behavior.
Change-Id: I0b4cb628829b138e2ceb3f08833649b90255648c
This hanging needs to be investigated/fix before re-enabling
this needs to be done as it impacts every single verification build
Change-Id: I66d5e46773c4f816dd09268fdd55a7495755375e
Since delegate instances are cached and reused for subsequent launches,
we have to reset the buildFailed flag on subsequent builds (i.e., calls
of buildForLaunch). Otherwise, this flag will remain to be set to true
after a failed/cancelled build for the entire lifetime of this delegate,
even if a project has been re-launched and the build succeeded. If the
flag remains to be true, the dialog keeps popping up asking the user
whether to succeed with the launch with errors in the project, even if
the build succeeded and there are no errors any more.
Change-Id: I51aece90154f817542ed7548ec4c36591b19eaec
Signed-off-by: Philip Langer <planger@eclipsesource.com>
In the Multicore Visualizer, add the gdb thread ids so that users can
more easily recognize threads
Change-Id: I747e9223d9b689dd6a94d707dd2e5cfdb767764e
The Delete operation doesn't properly call
TextEditorAction.validateEditorInputState() and as a result doesn't work
in version control environments that keep unchanged files read-only.
Another problem is that Ctrl+Z doesn't trigger Undo when the Outline
view is active. When the Delete element action is reintroduced it should
be made to behave the same way as in JDT, e.g, display a prompt before
deletion and be bound to the Delete key.
This reverts commit f034a69fb7.
Change-Id: I6d37f5aaea1770143fbf84288068794430a5b0e0
The DebuggerConsoleView may be interfering with other views while
bringing it to the top. This is not desirable as many users may not need
to access the features of the GDB CLI.
With this change the view will be shown but not automatically brought up
to the top, so users can find it and select it as needed.
Change-Id: I6a26f3a39d43732659d1db4e1aeb77f3c9e399d9
Signed-off-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
IDebuggerConsoleManager.showConsoleView() was mimicked on
IConsoleManager.showConsoleView() which allows to specify which console
in the view should now be shown.
This makes sense for the generic platform Console view where extenders
could choose to display any kind of console when an event happens (e.g.,
a build console when the build is started). However, in our Debugger
Console case, it complicates things unnecessarily. In our case, we want
to be able to open the view, but the console to show is handled by other
logic such as a synchronizer service.
And if there is a need to change which console should be shown within
the Debugger Console view, then IDebuggerConsoleView.display() should be
used. I think having it in IConsoleManager.showConsoleView() is a
shortcut that is not very useful in our case.
Change-Id: Id66ea5c953e8a7ab603cfc23789a814c1ad821d2
