mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-24 01:15:29 +02:00
Code Issues Wiki Activity

Don't force the GDB console to be shown when created.

Browse source 
When a new launch is triggered and a new GDB console created, it was
shown automatically.  However, if there was a current debug session
where the selection was a stack frame, our sticky policy
(DefaultDsfSelectionPolicy) prevents the new session from being
selected, so the new GDB console shown didn't match the selection in the
DV.

With this patch, when a new GDB console is created, we don't show it
automatically, but let other logic figure out if it should be shown or
not.

Change-Id: If826677a6fb0f925f6b397a13f61fc75fc892748
This commit is contained in:
Marc Khouzam 2016-10-28 15:57:22 -04:00
parent 2cbf669a38
commit c2b4f18943
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
debug/org.eclipse.cdt.debug.ui/src/org/eclipse/cdt/debug/internal/ui/views/debuggerconsole/DebuggerConsoleView.java
View file

@ -211,9 +211,14 @@ implements IConsoleView, IDebuggerConsoleView, IConsoleListener, IPropertyChange
DebuggerConsoleWorkbenchPart part = new DebuggerConsoleWorkbenchPart(registered, getSite());
fConsoleToPart.put(registered, part);
fPartToConsole.put(part, registered);
// Must call partActivated() to create the page
// However, this will also show the page, which is not
// what we want. Therefore, let's force the previous
// page to be shown again right after.
IDebuggerConsole previouslyShown = getCurrentConsole();
partActivated(part);
if (console instanceof IDebuggerConsole) {
display((IDebuggerConsole)console);
if (previouslyShown != null) {
display(previouslyShown);
}
break;
}