mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-24 01:15:29 +02:00
Code Issues Wiki Activity

Bug 499230 - Duplicated "-thread-select" and "-stack-select-frame"

Browse source 
Most GDB MI commands support the "--thread" and "--frame" options, that
tells GDB on which thread/stack frame the command is meant to act-on.
For those that don't, CDT has a mechanism to first have GDB switch
thread (MIThreadSelect) or frame (MIStackSelectFrame), before issuing
the command that will act on that entity. Ironically, those two commands
are wrongly identified as not supporting those parameters, and so are
sometimes sent in duplicate, when a single command including the thread
or frame would be possible. This commit correctly identifies those
commands as supporting the thread/frame parameter.

Change-Id: I6e7fc4e873abe36ad024c7131efda7c0aa89dc44
This commit is contained in:
Marc Dumais 2016-08-05 09:09:41 -04:00 • committed by Gerrit Code Review @ Eclipse.org
parent c7526e8a04
commit 735b1ab488
2 changed files with 0 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIStackSelectFrame.java
View file

@ -28,9 +28,4 @@ public class MIStackSelectFrame extends MICommand<MIInfo> {
public MIStackSelectFrame(IDMContext ctx, int frameNum) {
super(ctx, "-stack-select-frame", new String[]{Integer.toString(frameNum)}); //$NON-NLS-1$
}
@Override
public boolean supportsThreadAndFrameOptions() {
return false;
}
}

5
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/command/commands/MIThreadSelect.java
View file

@ -37,9 +37,4 @@ public class MIThreadSelect extends MICommand<MIInfo>
public MIThreadSelect(IDMContext ctx, String threadNum) {
super(ctx, "-thread-select", new String[]{threadNum}); //$NON-NLS-1$
}
@Override
public boolean supportsThreadAndFrameOptions() {
return false;
}
}