That way we don't have to remember to set it in the Hudson job or manual
maven builds.
Change-Id: I7208ddaa15d8309b78be5991e64e0e88228d2a7d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
I got a feedback that the error message when passing an unsupported
version should be more helpful.
Change-Id: I3c925c500d6de787ca9bfce421eda6109e9f6415
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
implement few code style rules for comments
- no line comments (sometimes enforced)
- no nested comments (no /* in block comment)
Change-Id: Ib4042a8ffab0dc1c5effd7b77ab6d2f51a1e6cae
Partial revert of commit 196d978624.
The removed change was causing a problem where the connectionCombo
pulldown was being set to its first element even for existing LC
Change-Id: I6888f2f783a303770d2924d0351b5dd7b5c055cc
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Instead of relying only on a sleep, wait until the specified console
view has the specified text pattern.
Change-Id: I196ac1f1c04212c536b9bd5917156f24158df469
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
The indexer is mostly useless in a headless build and slows things down
- add an option to disable it.
Change-Id: I32560499923561acbcc0421ca77716232b18008a
Signed-off-by: Christian Walther <walther@indel.ch>
java.io.File is used to store the path to the cross tools.
getAbsolutePath is invoked before variables are expanded. Hence File
cannot see the path is already absolute and therefore prepends CWD.
Reverted to getPath, since conversion to full path would not make sense
anyway.
Change-Id: I13e5b2c0d7747741926a88e120d13003b910e8c6
Signed-off-by: Morten Kristiansen <millibit@gmail.com>
MIMemoryTest.writeCharVarying{Address,Offset}
When we switched SyncUtil.readMemory to use queries, it exposed a race
condition with the asserts that check for the number of event received.
Basically, nothing guarantees that when the assert is evaluated the
event had the time to arrive.
We now use a ServiceEventWaitor to wait until the event arrives (with a
timeout, of course).
At the same time, rename word_size to wordSize.
Change-Id: I6f4b51e22f46625e20bbbdbac91cf70cfd864e5e
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
As it is now, if you pass a start address but no end address (null), the
disassembled range will be [startAddress, $pc + 100], which does not
quite make sense.
I think the intention was to have the default end address be whatever
the start address is, + 100.
Change-Id: I1399cc116ecde6cfbdb2f1ec54a181e64a7f4c5f
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Reduce function complexity and comply with java coding styles.
Convert some larger ifs to switches for performance sake.
Change-Id: Ief2672141511a1373cdd8a98e0fa2eeb564816e1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Both Jetty 8 and Jetty 9 were getting included in the target platform. It seems
that those two versions can't co-exist and Eclipse fails to start.
Change-Id: I33e94458b34c339f8bffa5f64830958fe00a2e2d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
basically for the code like
if (a) return 1; else return 2;
a++; // this should be a dead code node
but we don't check connector node of "if" and don't add
it to dead nodes graph resulting it this code not being marked as dead,
which can lead to false positives or false negatives for checkers that
use that. Same apply for other control statements...
Change-Id: Iafb4b48ca960f0ffab2c0265285a31cb08eb0d11
Choose version 2.5.2 which is what is supported by CDT's HIPP. Note that by removing the version altogether, the latest available findBugs would be selected. However, this could lead to different results between manual builds and HIPP builds, which is why I thought it would be better to specify the version explicitly.
FindBugs can be run by adding the string
findbugs:findbugs
as a maven parameter, either in a local maven build, or on HIPP.
Add releng/findbugs-exclude.xml to control the errors shown by FindBugs.
The content of that file was copied from the TM project, but should
eventually be ajusted for CDT.
Change-Id: Ibc8348b9286f00580a4079a7ca3c669708bc6194
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
There is a superfluous LINE_MAIN_BEFORE_THREAD_START that is causing
problems, remove it.
Change-Id: I57c4637ada0b5efda2848029e5216a13cf638067
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
