mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-23 17:05:26 +02:00
Code Issues Wiki Activity

Make disassembly default end address relative to start

Browse source 
As it is now, if you pass a start address but no end address (null), the
disassembled range will be [startAddress, $pc + 100], which does not
quite make sense.

I think the intention was to have the default end address be whatever
the start address is, + 100.

Change-Id: I1399cc116ecde6cfbdb2f1ec54a181e64a7f4c5f
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
This commit is contained in:
Simon Marchi 2015-02-11 14:11:56 -05:00 • committed by Marc Khouzam
parent 6b512c3be4
commit 989d77bf7a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dsf-gdb/org.eclipse.cdt.dsf.gdb/src/org/eclipse/cdt/dsf/mi/service/MIDisassembly.java
View file

@ -124,7 +124,7 @@ public class MIDisassembly extends AbstractDsfService implements IDisassembly {
}
String start = (startAddress != null) ? startAddress.toString() : "$pc"; //$NON-NLS-1$
String end = (endAddress != null) ? endAddress.toString() : "$pc + 100"; //$NON-NLS-1$
String end = (endAddress != null) ? endAddress.toString() : start + " + 100"; //$NON-NLS-1$
fConnection.queueCommand(fCommandFactory.createMIDataDisassemble(context, start, end, mode),
new DataRequestMonitor<MIDataDisassembleInfo>(getExecutor(), drm) {
@Override
@ -206,7 +206,7 @@ public class MIDisassembly extends AbstractDsfService implements IDisassembly {
}
String start = (startAddress != null) ? startAddress.toString() : "$pc"; //$NON-NLS-1$
String end = (endAddress != null) ? endAddress.toString() : "$pc + 100"; //$NON-NLS-1$
String end = (endAddress != null) ? endAddress.toString() : start + " + 100"; //$NON-NLS-1$
fConnection.queueCommand(fCommandFactory.createMIDataDisassemble(context, start, end, mode),
new DataRequestMonitor<MIDataDisassembleInfo>(getExecutor(), drm) {
@Override