1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
cdt/llvm
Marc-Andre Laperle 00b30bb03a Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor
When a toolchain is selected along with its builder, the builder gets
matched to a “real builder” (ManagedBuildManager.getRealBuilder). If the
builder is abstract, the builder is not in the possible list of matches,
as implemented in Builder.getMatchKey. This causes
getCurrentBuilderCompatibilityInfo to return null which is not handled.

This patch changes the base LLVM builder to a non-abstract one, which
solves this specific NPE.
Also, in order to be more helpful to the user in case it happens to
another toolchain, a null check was added with an error message that the
builder is incompatible. Then at least, it is more clear that something
is wrong and the user can pick a different builder. 

Change-Id: I4d26c568dfe6307b496719c10908a36933fd3ab8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
2017-02-19 21:51:36 -05:00
..
org.eclipse.cdt.llvm.dsf.lldb-feature releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
org.eclipse.cdt.llvm.dsf.lldb.core releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
org.eclipse.cdt.llvm.dsf.lldb.ui releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
org.eclipse.cdt.managedbuilder.llvm-feature releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
org.eclipse.cdt.managedbuilder.llvm.tests Move the rest of the CDT plugins to java 8 2016-06-22 14:51:43 -04:00
org.eclipse.cdt.managedbuilder.llvm.ui Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor 2017-02-19 21:51:36 -05:00
pom.xml releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00