1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Find a file
Marc-Andre Laperle 00b30bb03a Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor
When a toolchain is selected along with its builder, the builder gets
matched to a “real builder” (ManagedBuildManager.getRealBuilder). If the
builder is abstract, the builder is not in the possible list of matches,
as implemented in Builder.getMatchKey. This causes
getCurrentBuilderCompatibilityInfo to return null which is not handled.

This patch changes the base LLVM builder to a non-abstract one, which
solves this specific NPE.
Also, in order to be more helpful to the user in case it happens to
another toolchain, a null check was added with an error message that the
builder is incompatible. Then at least, it is more clear that something
is wrong and the user can pick a different builder. 

Change-Id: I4d26c568dfe6307b496719c10908a36933fd3ab8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
2017-02-19 21:51:36 -05:00
.mvn releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
build Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor 2017-02-19 21:51:36 -05:00
codan releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
core Bug 512262 - Remove the unnecessary ICPPEvaluationOwner interface 2017-02-17 01:14:35 -05:00
cross releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
debug releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
doc Add missing reference to GDB Debugging Preferences (for DSF preferences) 2016-12-05 21:47:25 +00:00
dsf releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
dsf-gdb Revert "Bug 512303 - [tests] job debug-tests-master-all-gdb-versions has issues" 2017-02-17 14:43:04 -04:00
jtag releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
launch releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
llvm Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor 2017-02-19 21:51:36 -05:00
lrparser releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
memory releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
native releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
qt Bug 512262 - Remove the unnecessary ICPPEvaluationOwner interface 2017-02-17 01:14:35 -05:00
releng Fix script permissions to executable 2017-02-15 10:05:18 -04:00
remote releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
testsrunner releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
toolchains/arduino releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
upc releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
util releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
visualizer releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
windows releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
xlc releng: Make use of Tycho POM-less functionality 2017-02-13 23:19:56 -04:00
.gitignore Ignore NFS-created files. 2012-11-08 13:34:54 -08:00
pom.xml Update Maven build machinery. 2017-02-14 10:54:17 +02:00