1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-21 21:52:10 +02:00
Commit graph

36156 commits

Author SHA1 Message Date
Lisa-Marie Saru
c9a38e541f Code cleanup on Memory Search Result Page
- Use modern java instanceof
- Log unexpected exceptions
- reorder tests
- add missing null checks
- invert some if conditions for less nesting
2023-08-18 13:04:21 -04:00
Lisa-Marie Saru
f7a8c506f4 Improve memory search results page
The Memory Browser and Memory views will jump to the memory
address after a user selects a value from the Memory Search
Result list. If the views belong to the same tab group as
the Search view, then it might not be very intuitive for
the user to switch back to one of the Memory views and see
the effect of the selection.

The current commit adds on the the double click listener
(from MemorySearchResultsPage.java) the behavior to refocus
on the Memory Browser/ Memory view.

Resolves: #515
2023-08-18 13:04:21 -04:00
Jonah Graham
202f221671 allow github to index the build directory
https://docs.github.com/en/search-github/searching-on-github/finding-files-on-github
2023-08-18 13:03:14 -04:00
Jonah Graham
02035b02cf Support Context tags in Boost test runs
Boost a while ago added Context tags, this commit makes
those context tags supported in the testsrunner code of CDT

See also https://www.boost.org/doc/libs/1_82_0/libs/test/doc/html/boost_test/test_output/test_tools_support_for_logging/contexts.html

Fixes 459
2023-08-18 10:06:10 -04:00
Jonah Graham
60948feda8 Trim excess whitespace in Boost test output
The code for boost test running parsing left
all the excess whitespace from the XML file.
This led to a lot whitespace in messages
in the UI. This change trims leading and
trailing whitespace, but preserves whitespace
within a message.
2023-08-18 10:06:10 -04:00
Jonah Graham
081cb8249a Remove assumption that strings are always intern
The pre-existing code assumed that string (qName) passed in
to start and end element was always interned and compared
those strings to constants using ==. Instead rewrite
code using switch statements on the strings.

Also includes small change to the exception handling so that
code analysis can correctly where exceptions are always thrown.
i.e. instead of hiding a throw in an always throwing method,
return the exception and throw it at the call site.
2023-08-18 10:06:10 -04:00
Jonah Graham
ae92ad243a Update to platform 2023-09 M3 contribution 2023-08-17 17:38:03 -04:00
Jonah Graham
abed2b7ecd Use latest build of CDT, rather than latest release in target platform 2023-08-17 15:15:28 -04:00
Jonah Graham
75521e0e9f Fix the check bundle versions check 2023-08-17 09:07:51 -04:00
Jonah Graham
6d4e8ededc Stop checking baseline-compare-and-replace in build and test workflow
This is checked in the code cleanliness workflow and by failing the
main build here causes the tests not to run and the tests are more
important. Similar to the new api-baseline-check that doesn't
run in the main workflow
2023-08-17 09:07:51 -04:00
Jonah Graham
fe2d38e7a1 Add API Baseline checking to the build 2023-08-17 09:07:51 -04:00
Jonah Graham
2c3aaf89a1 Update to Tycho 4.0.1
The error handling in Tycho 4 identifies when bundles are listed
in category.xml but not available. The removed bundles were
not in the output, and with this change the error is resolved
in the build.

Updated setting for maven enforcer to match Tycho requirements.
2023-08-16 15:55:55 -04:00
Jonah Graham
f083a4a203 Split check code cleanliness into two build steps
A while ago we made the "Make sure all versions have been bumped
appropriately compared to the baseline" output to another file
to make it clearer. This refactor splits it up into different
build steps instead so that I don't have to open an additional
log file.
2023-08-16 15:04:39 -04:00
Jonah Graham
c7169b3186 Refactor XML file handling 2023-08-16 11:06:59 -04:00
Jonah Graham
b9cfdf91d8 Update target platform for 2023-09 M3 Orbit updates
Includes an I-build of platform that needs to updated to M3
platform when it is released on Friday

Fixes #509
2023-08-15 20:01:44 -04:00
Jonah Graham
220ba610d0 Fixup some API version errors
Follow up for #491
2023-08-15 20:00:56 -04:00
Jonah Graham
72c8186f50 Fix NPE when language entry is incomplete (as it is for LLVM) 2023-08-11 14:33:36 -04:00
Jeff Johnston
dd4a40a683
Fix meson build under Docker Tooling (#491)
* Fix meson build under Docker Tooling

- add new IToolChainConstants containing SECCOMP_UNCONFINED property constant
- add new setLauncher() method to CBuildConfiguration so that
  watchProcess() can be used for container building
- enhance ContainerCommandLauncher to discover specification of
  SECCOMP_UNDEFINED boolean option for execute() so "seccomp=undefined" can be specified
- fix ContainerCommandLauncherFactory.verifyIncludePaths() to only
  look at filtered includes that have been made absolute and to
  recognize matches when the prefix shows up in the loaded list
- add setting a property to ContainerGCCToolChain to set SECCOMP_UNCONFINED to true
  by default for the time-being
- when generating scannerinfo, specify "seccomp=unconfined"
- in ContainerGCCToolChain.startBuildProcess() remove extraneous
  banner statement and ensure that the build directory is created
- fixes #479
2023-08-10 16:36:05 -04:00
Jonah Graham
1e04efa017 Explicitly activate shell for launchbar selector
In https://github.com/eclipse-platform/eclipse.platform.swt/issues/450
the behaviour was changed so that setFocus no longer activates the shell
by default. Therefore when creating the popup shell and setting the focus
the overall focus was still on a control in the main eclipse shell.

This affected Eclipse SWT/Platform 4.29 M1 and has been changed for
M3. However there is intention to (possibly) change the default back
to not activating in setFocus. If that happens this patch will be ready
for it, and in the meantime (until CDT changes to M3) it resolves this
test failure:

`createNewLaunchConfig (org.eclipse.launchbar.ui.tests.internal.CreateLaunchConfigTests) with error`

full trace:

```java
org.eclipse.swtbot.swt.finder.exceptions.WidgetNotFoundException: Could not find shell matching: with text 'Create Launch Configuration'
	at org.eclipse.launchbar.ui.tests.internal.CreateLaunchConfigTests.createNewLaunchConfig(CreateLaunchConfigTests.java:77)
Caused by: org.eclipse.swtbot.swt.finder.widgets.TimeoutException: Timeout after: 10000 ms.: Could not find shell matching: with text 'Create Launch Configuration'
	at org.eclipse.launchbar.ui.tests.internal.CreateLaunchConfigTests.createNewLaunchConfig(CreateLaunchConfigTests.java:77)
SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
```
2023-08-10 12:23:36 -04:00
Jonah Graham
de012f42a6 Remove and ignore object references from Yaml files
Yaml 2.0 fixes CVE-2022–1471 to error on object references. This
commit adapts our use of Yaml to not output object references
anymore and on loading explicitly allow object references to
expected types.

Fixes #498
2023-08-10 09:38:12 -04:00
Jonah Graham
e725b88951 Fix test cases that recently regressed
Recently new extensions were added to CDT for C++ modules in #422
At the time some test failures were not noticed. This change patches
those failing tests.

Fixes #454
2023-08-09 21:37:19 -04:00
Jonah Graham
4c7dd6921a Clean up target platform
Until https://github.com/eclipse-cdt/cdt/pull/495 can be resolved
fully, apply some of the required changes.

- wildwebdeveloper was out of date, however we don't really
  need wwd in CDT, but some of our dependencies have requirements
  that are fufilled (e.g. linuxtools)
- duplicate entry for hamcrest 2.2 removed (other entry was just
  above it!)
2023-08-09 16:55:12 -04:00
Jonah Graham
154d66f815 Add unique display name for some test plug-ins 2023-08-08 15:47:35 -04:00
John Dallaway
a19a7230b6 Add NXP LinkServer definitions 2023-08-08 13:06:42 +01:00
Jonah Graham
9448058a76
Resolve cast exception - fixup for inferring generic types (#490)
Long ago in 334702ee05 generic types
were added. However in at least one place a previous assumption
that existed was broken. That assumption was the true
type of ResourceInfo.getTools() would be Tool[] as opposed to ITool[].
That commit broke it for ResourceConfiguration.getTools()

Internally in CDT ITool is in practice always Tool, and as a result
there are lots of downcast from ITool -> Tool. However ITool[] cannot
be downcast to Tool[] unless the original type was Tool[].

Instead we use Arrays.copyOf to copy the array into the correct
array type.

Steps to reproduce the problem now fixed:

1. Create a Managed Build executable project.
2. Open the properties window of the source file (as opposed to project)
3. At the Properties page, navigate to "C/C++ Build/Tool Chain Editor".
4. Click the "Apply" button.
2023-08-03 17:12:26 -04:00
John Dallaway
d3afc5403b Fix version dependency on o.e.c.managedbuilder.core 2023-08-03 21:45:50 +01:00
Gesa Hentschke
c2d0a6600b
[#484] Add extension point for custom icons of C/C++ source files (#485)
* [#484] Add extension point for custom icons of C/C++ source files

fixes #484
2023-08-03 17:42:23 +02:00
Jonah Graham
9920d7afbd
Move entirely from the old Orbit repos to the new aggregated ones (#486)
I have also removed the now unused dependencies.
2023-08-02 15:07:25 -04:00
John Dallaway
e069e974e8 Eliminate GC resource leak 2023-08-02 16:12:46 +01:00
Jonah Graham
bb8ffa7b09
Make GitHub issue template more relevant (#468)
The old template was the default for GitHub, but it was off the mark
a little for some aspects. This change hopes to make the template
more useful
2023-07-21 15:43:56 -04:00
Jonah Graham
49d3e3113d Move back to Linux Tools Docker nightly
The commit resolves the resolution error that was raised in
https://github.com/eclipse-linuxtools/org.eclipse.linuxtools/issues/232

I have raised an issue in PDE here:
https://github.com/eclipse-pde/eclipse.pde/issues/675
2023-07-21 15:00:07 -04:00
Jonah Graham
3d586dc7d7 Explicitly include ASM in our target platform
My last attempt at this in 4aa51673ab I had set
includeDependencyDepth="direct" but that pulled in a bunch
of unintended dependencies. Instead explicitly add the ASM
dependency.
2023-07-21 14:27:05 -04:00
Jonah Graham
4aa51673ab Update target platform to latest Eclipse Platform milestone
This includes updating to 3rd party dependencies coming from Maven
so that everything resolves properly. In particular spifly
required asm, and by doing `includeDependencyDepth="direct"` that
dependency is included in the target platform.
2023-07-20 23:24:51 -04:00
Jonah Graham
899a386bfb Use last released LinuxTools docker
At the moment there are some resolution issues on the nightly
versions of LinuxTools docker components, so for now use the
latest release rather than nightly.

See https://github.com/eclipse-linuxtools/org.eclipse.linuxtools/issues/232
2023-07-20 23:24:51 -04:00
Jonah Graham
5be1b7ac9e Fix Variables button for Working Directory in launch config
Fixes #463
2023-07-20 07:49:01 -04:00
Jonah Graham
d6c4e73c8f Update to latest version of deps
Using https://github.com/eclipse-orbit/orbit-simrel/blob/main/report/maven-osgi/cdt/REPORT.md

Part of #420
2023-07-11 10:21:13 -04:00
Jonah Graham
ac84c4ec86 Prepare repo for CDT 11.3.0 development
Some bundles are bumped because dev happened between 11.2 release and
this version bump. The most significant change that happened
was the bump in Tycho version which changed ECJ version and
hence some class files changed

Part of #420
2023-07-10 21:41:39 -04:00
Jonah Graham
460c0021aa Move all dependencies to maven direct where possible
Includes:

- Sign all artifacts, particularly 3rd party with CDT's PGP key
- Using maven version managed and updated by EF Webmasters
- Update to latest SnakeYAML
- Move some 3rd party dependencies to Import-Package (instead of
  Require-Bundle)
2023-07-10 20:47:10 -04:00
Jonah Graham
33c30fa819 Format target file
The target file has been formatted with the formatter
in the Target editor when in the Source tab (Context menu ->
Source -> Format).
2023-07-10 20:07:02 -04:00
Alexander Fedorov
c23b3241ae [#449] Import memory window is not working as expected
Increment version for org.eclipse.cdt.debug.ui.memory.transport

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2023-07-08 16:13:36 +03:00
Alexander Fedorov
68ccd09ca1 [#449] Import memory window is not working as expected
Use `SWT.OPEN` style for import dialogs

Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2023-07-08 16:13:36 +03:00
John Dallaway
5be8661c9b Support DWARF v5 content form data 2023-07-07 21:07:17 +01:00
John Dallaway
54d5e1445c Support DWARF attribute form DW_FORM_implicit_const 2023-07-03 14:05:43 +01:00
ewaterlander
8a8b94bfbb
Postpone build container creation to build start. Fixes possible Eclipse freeze. (#433)
The creation of the build container for Core Build projects is
postponed to the start of the build process.

StandardBuildConfiguration getBuildContainer and setBuildContainer
have been cleaned up.

CBuildConfiguration creation is started via
CBuildConfigurationManager.getBuildConfiguration(IBuildConfiguration)
which holds a lock on the HashMap 'configs'. Creation of
StandardBuildConfiguration triggered, via applyProperties and
getBuildContainer(), a Folder.create which loops back to
CBuildConfigurationManager.getBuildConfiguration().
For detailed traces see https://github.com/eclipse-cdt/cdt/issues/424

Fixes #424
2023-06-26 13:37:23 -04:00
John Dallaway
44dc9d7cd7 Propagate exceptions in default binary file viewer 2023-06-26 18:30:53 +01:00
Jonah Graham
0dc9d340f5 Lock snakeyaml to expected 1.x version
Snakeyml recentlyish came out with 2.0 version and more recently
TM4E started using the 2.0 version. As TM4E snapshots are in our
target platform we started failing as we started wiring to the newer
version due to a missing underbound on our dependency.

A separate task of updating to recent snakeyaml will be done as part
of #387
2023-06-26 11:49:51 -04:00
John Dallaway
9edc432c49 Eliminate memory leak in Default Binary File Editor 2023-06-17 06:07:53 +01:00
15knots
09728af3db
recognize source file extensions ".ccm", ".cxxm", and ".c++m" (#422)
* recognize source file extensions ".ccm", ".cxxm", and ".c++m"

cmake 3.27 release notes: The "CXX" language now treats source file
extensions ".ccm", ".cxxm", and ".c++m" as C++.

Signed-off-by: 15knots <11367029+15knots@users.noreply.github.com>
2023-06-16 20:56:51 +02:00
Jonah Graham
04f67b14b8 Use stable URL for Platform 4.28 dependency
Part of #420
2023-06-15 13:32:59 -04:00
Jonah Graham
0dd2c4b5c2 CDT 11.3 N&N starting point
Part of #420
2023-06-13 15:26:21 -04:00