1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 14:42:11 +02:00
Commit graph

1738 commits

Author SHA1 Message Date
Jonah Graham
1f19cff227 Make missing identifiers and classes in plugin.xml errors
Subsequent commits fix the errors
2022-11-04 08:19:23 -04:00
Jonah Graham
10e95a1825 Fix race condition in multithread test
The long sleep at the end of each thread is to make sure that
while the test code is waiting for an event the "other" thread
doesn't finish. 3 seconds is not long enough for this.

This is similar to why we need dsf.gdb.tests.timeout.multiplier
for other tests. Especially on the build machines the tests
can run much slower causing the sleep to be insufficient.

Increasing this to 30 seconds doesn't make the test suites
take any longer, when they are all passing.

Fixes #119
2022-10-27 20:33:26 -04:00
Jonah Graham
5fac32e3f8 Fix the dprintf tests when running on gdbserver
Because dprintf goes to stdout, need to make sure buffers are
fully flushed before we check output.
2022-10-25 22:21:38 -04:00
John Dallaway
1590791e76
Eliminate deprecated GDBBackend methods for CDT 11 (#112) 2022-10-25 13:40:13 +01:00
Jonah Graham
6cd2e97470 Bug 580873: Remove error checking on dprintf parameters
The parser for dprintf parameters was much too simplistic and
prevents real uses cases from operating.

It is not necessary to remove the , between the arguments to
dprintf, so don't try to split on that anymore. That also
means we can't check for and error on mismatch between format
specifiers and number of arguments.

e.g. "===> XML_EVENT_TEXT(%s)\n", (char *)strtok(Text,"\n")
should be permitted.

The alternative would be to write a more complete parser for
both the printf specification and the arguments. Well out of
scope and unnecessary.

Some inputs may now be accepted by the GUI and then when
inserted with GDB fail. These errors are displayed in the
GUI already anyway.
2022-10-20 10:27:58 -04:00
Jonah Graham
3b3f29c93a Don't synchronize on Boolean/Integer object
This fixes numerous warnings like this:
Boolean is a value-based type which is a discouraged argument
for the synchronized statement
and:
Integer is a value-based type which is a discouraged argument
for the synchronized statement
2022-10-19 10:53:09 -04:00
Jonah Graham
161b57f9ed Tests for dprintf GDB functionality
Bug 400628 was originally completed without any new tests.
To make it easier to test that Bug 580873 works, this commit
adds in some missing tests.
2022-10-19 10:53:09 -04:00
Jonah Graham
34381cd253 Bump Major version of o.e.cdt.dsf.gdb for CDT 11.0.0 2022-10-19 10:53:09 -04:00
Jonah Graham
1d9de8fd1e Fix fragment name
Two bundles were called DSF-GDB test fragment,
rename this one to be more explicit
2022-10-10 19:34:08 -04:00
Jonah Graham
56ee2c3bb1 DSF-GDB tests in GitHub Actions
- Fix the running so that the correct gdb is used.
- Only run DSF tests if dsf directories have been modified
- Default to using gdb,gdbserver on the PATH when running
  tests
- Remove double reporting of test results
2022-10-10 08:44:28 -04:00
Jonah Graham
ab3b819156 Remove API tooling from projects that are not part of our release 2022-10-03 12:42:37 -04:00
Jonah Graham
e4e06008af Update to Java 17 as BREE. Fixes #80 2022-10-03 12:42:37 -04:00
Jonah Graham
110ac149c2 [releng] Bump versions for CDT 11.0.0 2022-10-03 12:42:37 -04:00
Jonah Graham
1c8c96c239 Move the disable intro ini out of root of repo
The root files in GitHub are a bit more prominent, so keep
that area clean and move this special ini to a subdir.

Change-Id: I12d95727e9dad29ebe4f50d47faa9e98753a52bc
2022-08-04 12:23:12 -04:00
Torbjörn Svensson
96839a029d Bug 580259: Not all remote session have a connected process
Contributed by STMicroelectronics

Change-Id: Idec88f4bf0cbc8326bf19b9f081af9f9f9d437e2
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2022-07-21 04:47:09 -04:00
Umair Sair
7b040db113 Bug 579877 - Slow Threads update for debugging on remote target
Reason:
=======
The problem is that we use '-thread-info' command for each thread and
for each command, a lot of common conversation happen between gdb and
gdbserver for each command.

Solution:
=========
We should use '-list-thread-groups <group id>' instead which provides
the same required information for all the threads and minimizes the
communication between gdb and gdbserver. This command takes lesser time
than the collective time taken by all '-thread-info' commands.

Tested with 2 and 8 threaded application using gdb 7.1 and 11. The gain
is more prominent as the number of threads increases.

Signed-off-by: Umair Sair <umair_sair@hotmail.com>

Change-Id: Ie4824bf110f05d4136697f4e1ecbcc19dcf145a7
2022-05-10 21:49:24 -04:00
Torbjörn Svensson
a2e6ef61c9 Bug 579666: Improve dark theme on Windows
On Windows, the TabFolder and TabItem classes does not follow the
themeing in Eclipse. As a result, the tab selectors will be drawn with
the light theme while the rest of the Eclipse UI is in dark theme.

Contributed by STMicroelectronics

Change-Id: I9169c9e01f8c9a3af7b6bb6d1c673a043735e7e9
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2022-05-06 04:38:00 -04:00
Jonah Graham
a1c02e2cce [releng] Apply auto-clean of save to all files with Eclipse 4.23
This mostly is using diamond operator, but includes
adding missing @Override and organizing imports and
applying formatting improvements in the JDT formatter.

Change-Id: Id91cbff33b0a039cc5121945ffbc407ecba45866
2022-04-19 20:13:15 -04:00
Jonah Graham
148ae40d0f [releng] Make CDT Clean-up profile match Editor on save actions
The CDT Cleanup profile had a bunch of extra cleanups applied to it, this
prevents running the CDT cleanup profile manually to simulate running the
save actions on all Java files

Change-Id: Iad491e1258a4ba90d81d1457ea0f6779e3663e38
2022-04-19 20:13:15 -04:00
Torbjörn Svensson
7581f79346 Bug 579687: Reduce concurrent commands to 1 for GDB 9/10/11
Since the fault in GDB is triggered when there is more than one MI
command sent before the response for the prior one is processed, limit
the number of concurrent commands to 1 for the affected versions.

Contributed by STMicroelectronics

Change-Id: I5b47fc64d90eefdc44c1d2ead0da99b35aadfa39
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2022-04-14 18:27:12 -04:00
Jonah Graham
7400e22b1f [releng] Update all legal files with update_legal_files.sh
The about.html was changed as per
https://gitlab.eclipse.org/eclipsefdn/it/websites/eclipse.org/-/issues/90

Change-Id: Ied879279460a8fc610630fc26794ab3df9eae39f
2022-04-13 13:42:35 -04:00
Jonah Graham
1f0451c163 [releng] Prepare for 10.7.0 with version bumps
All the about.html files are updated, so every bundle that hasn't
already had a bump in 10.7 needs one now

Change-Id: I6143d2fbe77a58a3a6d2f4a226d96087117f9ac1
2022-04-13 13:15:06 -04:00
Torbjörn Svensson
ffb319ba61 [releng] Correct version increment due to new API
Contributed by STMicroelectronics

Change-Id: I9aad65f862f4681c531baa0ca94b312f9c1774af
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
2022-04-12 08:18:45 -04:00
Jonah Graham
5c4d54df1a [releng] Update comparator repo to 10.6.0
Change-Id: Ie4e5bc90a41bb6e47cd34afb42126e1934fcc042
2022-04-10 20:55:36 -04:00
Jonah Graham
e8d924bb9a [releng] Bump versions for 10.7.0
Change-Id: Ibada1ef26f47f4238ae64f53fb67a73125534347
2022-04-10 20:55:36 -04:00
Jonathan Tousignant
7bddb5f4cb Bug 528145 - Attach debugger to a gdbserver remote session
Change-Id: I18bfe412a46b727c74597ceb871391dcb48b302d
2022-03-10 09:54:34 -05:00
John Dallaway
e1e9d9e792 Bug 578323: Initialize memory data before remote connection
We must ensure that memory data is initialized before the restoration of
persisted memory monitors is triggered.

Change-Id: I1fc2af877d27f331fbc4c516c05fb871dad410c4
Signed-off-by: John Dallaway <john@dallaway.org.uk>
2022-01-26 03:24:23 -05:00
Jonah Graham
640dc53892 [releng] Bump version numbers for all modified projects
Change-Id: I0d78c550512d8e63374bf1bc3a53f80e5d387e31
2022-01-12 18:57:12 -05:00
Jonah Graham
431e5ffd23 [releng] Bump end year on copyright on all modified features
Change-Id: I0d35eb6514d87fb6dcba0a284f58963b80861d51
2022-01-12 18:57:12 -05:00
Jonah Graham
8adb3bf37e [releng] Resolve API errors and warning since branch
The org.eclipse.remote.* version bumps were all because of
BREE change since the last release.

The api filters are removed because of the baseline bump

Change-Id: Ic7317dafa9872bb737502654a726823a35ec47b3
2022-01-12 14:12:50 -05:00
Jonah Graham
dbd7558f17 [releng] Bump to CDT version 10.6.0
Change-Id: I28629cdfb0906ce7f1b33a88cbbd55521afc8f6b
2022-01-12 14:07:45 -05:00
Michael Uhl
ceb39b8735 Bug 577907: IIllegalArgumentException on attach process dialog cause of
project with empty name

Change-Id: Ib45b75e27d8bf83eb90fa1020823190f4cd16e1b
Signed-off-by: Michael Uhl <Michael.Uhl@NashTech.Com>
2021-12-21 12:17:31 -05:00
Mat Booth
ed1e05876c Bug 576987 - Unable to scroll when editing a launch config
The current situation is that:
* launch configuration dialog tabs scroll correctly in the standard
  Eclipse platform dialog, but not at all in the Launchbar-specific dialog
* some CDT-supplied launch configuration dialog tabs try to manage their
  own scrolling behaviour to fix scrolling in the Launchbar-specific
  dialog but this breaks scrolling for that tab in the standard Eclipse
  platform dialog.

This change fixes the launchbar-specific editor dialog to use a scrolled
composite instead of a regular composite on which to layout the content
of each tab -- This gives the launchbar's configuration editing dialog
exactly the same scrolling behaviour as the standard Eclipse platform
configuration editing dialog.

And also fixes any CDT-supplied tabs that try to manage their own
scrolling behaviour so now all tabs have the same behaviour when viewed
in the Launchbar-specific dialog as they do when viewed in the standard
Eclipse platform dialog.

Change-Id: I0d7364a24ca48bb125cae9518728b4c93b93545d
Signed-off-by: Mat Booth <mat.booth@gmail.com>
2021-11-04 11:18:50 -04:00
Mat Booth
ef30e37327 Bug 561996 - Remove dependency to com.ibm.icu from CDT DSF GDB
Switch to JRE implementations:
 * com.ibm.icu.text.MessageFormat -> java.text.MessageFormat

Signed-off-by: Mat Booth <mat.booth@gmail.com>
Change-Id: I823bcea99adad3decdfa29651b934b5902607f70
2021-11-03 18:28:19 +00:00
Jonah Graham
e60ef74ebb Bug 576884: Ignore unsuitable adapter when the UI layer isn't running
When the UI layer is running the correct terminate adapter is returned,
when the UI layer is not running, the Launch.terminate code is a valid
fallback, and the org.eclipse.debug.internal.core.commands.TerminateCommand
is not an appropriate adapter to use.

Change-Id: I3c4c273b78b4e5bc9fe521b4a24ef5443852d3c0
2021-10-25 18:56:15 -04:00
Mat Booth
8db32cb918 Bug 561998 - Remove dependency to com.ibm.icu from CDT DSF GDB UI
Switch to JRE implementations:
 * com.ibm.icu.text.MessageFormat -> java.text.MessageFormat

Signed-off-by: Mat Booth <mat.booth@gmail.com>
Change-Id: Ib21c4c31cdc28bf70df2688a403afcf25a81cadc
2021-10-25 04:23:08 -04:00
Jonah Graham
871ee590c4 Bug 575018: Add repeatable iteration order for map used in test
The test used to fail on the -100.0 / 3.0 case if that was the first
condition tested. This change forces that to not be the first
condition tested which reduces the incidence of failures.

This does not resolve the unknown underlying issue which appears
to be on the GDB side that CDT is exposing. Upgrading GDB version
may also resolve the test failures, but for now I am going with
this fix so that we stop having UNSTABLE Jenkins CI builds.

Change-Id: Ibfa93a8350cfc08adf721723bc07566521bed812
2021-10-04 14:00:54 -04:00
Umair Sair
68c67b20a4 Bug 576291 - Add preference for suspend timeout
- Adding preference in GDB preference page

Change-Id: Ic179ddd4f15eb02f8de479ca095cc2ec19818c6b
Signed-off-by: Umair Sair <umair_sair@hotmail.com>
2021-09-28 21:20:39 +05:00
Jonah Graham
ad4d444823 [releng] Prepare for CDT 10.5.0
Change-Id: I9b72edf4a0ff0771a147934dd7f1c92ba1ee799a
2021-09-26 20:23:17 -04:00
Victor Rubezhny
8fa72d559f [575317] CDT Debugger fails to start in Eclipse Flatpak
'/tcp' suffix is not supported anymore with 'gdb',
so an IP address should be in form of HOST:PORT
(and not of HOST:PORT/PROTOCOL)

See: https://github.com/flathub/org.eclipse.Java/issues/36

Change-Id: I9eedc450da0d39305fc5d4cde851eb991c3c31f0
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
2021-08-09 22:02:30 +02:00
Mat Booth
0092d1cb4d Bug 561997 - Remove dependency to com.ibm.icu from MultiCoreVisualizer UI
Remove unneeded import-package on com.ibm.icu.text.

Signed-off-by: Mat Booth <mat.booth@gmail.com>
Change-Id: I2c919cd33cf6c87a71bd61fcc7e675173c7c9abc
2021-08-09 11:17:16 -04:00
Jonah Graham
c33e81872d Bug 575018: Mark volatile field correctly
Change-Id: I0edebbd906b4a5cfda804ddb3a22c75a04c3e510
2021-07-24 19:05:38 -04:00
Jonah Graham
467eeb06a4 Fix trace of command line array
In the DSF tests the command line is output, but it is an array so
needed an Arrays.toString

Change-Id: I8b7dc33073dc3a34ffe7eea0343e415041335c7d
2021-07-24 18:03:23 -04:00
Jeff Johnston
d27126df9a Bug 574874 - Disable full gdb console support if running CDT in flatpak
- add check for flatpak environment variable in
  GDBBackend_7_12.isFullGdbConsoleSupported() method
  and return false if variable is set

Change-Id: I667a63395592e2671ab3bf6f255e7428371086b3
2021-07-15 16:12:37 -04:00
Abdullah Khalid
481f08beb4 Bug 574239 - Adding path mapping through CSourceNotFoundEditor makes
launch configuration's Source tab dirty

Change-Id: I32396e274e4e803344d5e4a56324fb84ca40fd93
2021-06-16 19:16:06 -04:00
Jonah Graham
d907da99a4 Bug 573677: Use array based exec commands to avoid problems with spaces
While most of these commands don't actually have spaces in them, or
their arguments, avoid the deprecated methods.

Change-Id: If7b4324695699d5a6d9a2f8a979657977486d8a4
2021-06-14 22:20:28 -04:00
Jonah Graham
902ea0dfa1 [releng] Bump to CDT version 10.4.0
Change-Id: I0807f46d9ebb8bb579b687366cdb19e40935a9ec
2021-06-12 20:52:54 -04:00
Abdullah Khalid
6352e0c207 Bug 574136: support hardware breakpoints in SyncUtil
Improvements in SyncUtil's addBreakpoint and runToLocation
methods to make them support hardware breakpoint

Change-Id: If358bf11cab426f48edb8854e9ece911c2839815
Signed-off-by: Abdullah Khalid <abdullah.dev0@gmail.com>
2021-06-10 17:00:36 -04:00
Jonah Graham
f07ba87a12 Bug 572582: Increase minimum fully supported version of GDB to 8.0
Eclipse CDT supports GDB version 6.6 and newer. Some features
in Eclipse CDT require newer versions of GDB. The Eclipse CDT
project focuses its testing time on GDB version 8.0 and newer.

Change-Id: Ifb7cd77c9fae4b9d1b82e0aa8a2cea206a4298b7
2021-05-15 21:15:15 -04:00
John Dallaway
00204a3c4c Bug 573506: Fix counting of opcode bytes
Change-Id: Ib5d1f1984e064099fc5cb357508359a5805f131c
2021-05-13 13:45:26 -04:00