mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-21 21:52:10 +02:00
Code Issues Wiki Activity

Fix race condition in multithread test

Browse source 
The long sleep at the end of each thread is to make sure that
while the test code is waiting for an event the "other" thread
doesn't finish. 3 seconds is not long enough for this.

This is similar to why we need dsf.gdb.tests.timeout.multiplier
for other tests. Especially on the build machines the tests
can run much slower causing the sleep to be insufficient.

Increasing this to 30 seconds doesn't make the test suites
take any longer, when they are all passing.

Fixes #119
This commit is contained in:
Jonah Graham 2022-10-27 14:08:24 -04:00
parent 949d46c630
commit 10e95a1825
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/data/launch/src/MultiThreadRunControl.cc
View file

@ -22,7 +22,7 @@ static ThreadRet THREAD_CALL_CONV PrintHello(void *void_arg) {
firstBreakpoint(thread_id); // Stop a second time
SLEEP(3); // Resuming past this will give us a running thread
SLEEP(30); // Resuming past this will give us a running thread
return THREAD_DEFAULT_RET;
}
@ -45,7 +45,7 @@ int main(int argc, char *argv[])
SLEEP(1); // Resuming past this will make this thread run, while we stop the second thread
SLEEP(3); // Resuming past this will make this thread run, while we also run the second thread
SLEEP(30); // Resuming past this will make this thread run, while we also run the second thread
return 0;
}