DsfTerminateCommand leaves a timeout job on the executor queue, remove
it proactively so the executor doesn't sit around just waiting
for it to terminate.
Change-Id: If26411a5b6e0d35a1c45582e91ba62d24cef6bbb
If a build tool (e.g. gcc) outputs colored text, the ANSI escape
sequences will prevent the output parsers from matching the lines. This
patch makes the ErrorParserManager remove them before handing the
strings to the parsers.
I tested that this works well with the ANSI console plugin [1], which
allows displaying colors in the console window.
Note that I stole the regex from this SO post [2], I hope it's trivial
enough that it doesn't cause any IP problem.
[1] https://marketplace.eclipse.org/content/ansi-escape-console
[2] https://stackoverflow.com/questions/25189651/how-to-remove-ansi-control-chars-vt100-from-a-java-string
Change-Id: I0d6a25723be4008600acecb8595865bcb4f4abc1
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
See : https://www.eclipse.org/forums/index.php/t/1084842/
Original (WizardNewProjectCreationPage) getStartingPage() cast within
getMainPageData() method was obviously forcing first wizard page type
... provided basic trick is opening some opportunities more !
Change-Id: Ie9b7c4ef63040df6a419af8348f088be79cc2611
Signed-off-by: cartu38 opendev <cartu38.opendev@gmail.com>
It's internal and not used anywhere.
Change-Id: I194b4db7f4284bc0820221220301515a12b17ae4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
A few rm.done() calls were missing in overridden methods.
Those queries were slowing down debugging significantly.
Change-Id: I966d79af38721e551e9ebf2a74ca4d8d895241d0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reorganize code and expose things for generic editor.
So far presentation reconciler only is ported.
Allows to right-click/Open with/Generic editor on e.g. Makefile.am and
see it in the generic editor. It is not as feature rich as the
specialized editors we have now but over time it should provide all the
features of them with significantly less code.
Change-Id: I72324b94ce08ab762979804914adbb1982c88198
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
I ran shellcheck [1] on the script and it found various minor things to
improve.
- Use $(...) instead of `...` to run commands in a subshell.
- Wrap all variables in quotes, in case there are spaces.
At the same time, I noticed a few other things:
- Use "#!/usr/bin/env bash" instead of "#!/bin/bash", in case the user
uses a bash not at /bin/bash.
- Use "set -o errexit" instead of "set -e" for better readability.
- Use "set -o nounset" to generate errors if trying to read unset
variables.
- Pass CXXFLAGS in addition to CFLAGS, since GDB is now in C++.
- Use ${CFLAGS:-} instead of ${CFLAGS}, in case CFLAGS is not set
(because of "set -o nounset").
- Don't check for result of getopt. If it fails, the script ends
immediatly due to errexit.
[1] http://www.shellcheck.net/
Change-Id: If73f3510e46ca80d542d47c29c55b48b8b0bc697
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Generified, some lamnda conversions and some non-javadoc removal.
Change-Id: Ibf0493917ac3da7531de1ca591a9bfdc250ddf2a
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
When the pdom for a project it corrupted, the only message in the
console/log is "Error". The DBStatus class accepts a message string as a
parameter and doesn't use it. If it's changed to use it, then a more
useful message is printed:
"Corrupted database: foo.1487621676851.pdom"
Change-Id: I0d4fb0b97fe1c63661941130e14edea18d0f26ee
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
There was an attempt to not delete the rcp*/ folders when deleting the
repository folder but it left the folders empty. The updated pattern
seems to work correctly.
Change-Id: Ibb0e399044d87ad2374fe2f0f96e1f7eaf70bcd0
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
There is a collision in the ids of the pthread options,
"cdt.managedbuild.tool.gnu.c.pthread" is there twice. Change the ids to
be more in line with the other options.
Change-Id: Ice9d003b82b3740df6420811e90a2b157375c243
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Before this change, we had to remember to edit the config.ini every time
a dependency was modified in debug.product. This change introduces a
script during the build that generates the config.ini with the same list
of plugins specified in debug.product.
The cdtdebug.sh start-up script was simplified in the process because
the config.ini includes all platform-specific plugins now and they just
won't get loaded if they are not a match for the environment.
Change-Id: I658b0dd8688088e203966a154e6154f1b2c851f4
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
When building o.e.cdt.repo we used to delete the
entire directory in which we put the build result. However, it is
possible that the Standalone debugger was built before o.e.cdt.repo and
already put the valid rcp and rcp-repository directories in that
location. We therefore should not delete those.
Change-Id: I5d1608bceb48633f2205af8f8282e884ff223351
From my experience, bad things happen if the user specifies a
non-absolute path in the box labeled "Remote Absolute File Path for
C/C++ Application". This patch adds a validation to the tab to make
sure that the path is a valid absolute POSIX path.
This assumes that we do not support remote launching on Windows targets,
and therefore do not need to specify paths such as "C:\foo\bar.exe".
Change-Id: I20367078ff20179f0515272afee17d0986940309
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Instead of calling "chmod +x" by hand, use IFileStore.putInfo to set the
file attributes. Since we already use the IFileStore API to copy the
file, it makes sense (and it's cleaner) to use it to set the executable
attribute as well.
In most cases, it wouldn't be needed to make the file executable, since
it should already be on the host filesystem and IFileStore.copy
transfers the attributes. However, it's still good to force it
executable in case it's not already for some reason.
Change-Id: I4c86e36265962781d4541aaceeb40b502248f674
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
A new plugin is required since the last 4.7 milestone build.
Change-Id: Ibf0bb9bc3ed7858dca67782051f53d81c5ace915
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
