mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
Code Issues Wiki Activity

Remove wait on stop in BinaryRunner. It causes deadlock.

Browse source 
If we have issues with the runner while the job is trying to cancel,
we sould be address it there.

Change-Id: I2c42d654f4d08a7499c97c52fe14d76e24aa3dd6
This commit is contained in:
Doug Schaefer 2018-03-06 10:22:18 -05:00
parent 8934f52ae6
commit c781ba5c36
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/BinaryRunner.java
View file

@ -163,14 +163,13 @@ public class BinaryRunner {
} }
/** /**
* Cancels the binary runner and waits until it is stopped. * Cancels the binary runner
*/ */
public void stop() { public void stop() {
synchronized (runnerJob) { synchronized (runnerJob) {
isStopped= true; // make sure job is not scheduled afterwards isStopped= true; // make sure job is not scheduled afterwards
runnerJob.cancel(); runnerJob.cancel();
} }
waitIfRunning();
} }
private class Visitor implements IResourceProxyVisitor { private class Visitor implements IResourceProxyVisitor {