From c781ba5c361d9b9b5b4f43b920a111c46e3b928c Mon Sep 17 00:00:00 2001 From: Doug Schaefer Date: Tue, 6 Mar 2018 10:22:18 -0500 Subject: [PATCH] Remove wait on stop in BinaryRunner. It causes deadlock. If we have issues with the runner while the job is trying to cancel, we sould be address it there. Change-Id: I2c42d654f4d08a7499c97c52fe14d76e24aa3dd6 --- .../org/eclipse/cdt/internal/core/model/BinaryRunner.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/BinaryRunner.java b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/BinaryRunner.java index 7fff3e71f68..48aa6cab590 100644 --- a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/BinaryRunner.java +++ b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/model/BinaryRunner.java @@ -163,14 +163,13 @@ public class BinaryRunner { } /** - * Cancels the binary runner and waits until it is stopped. + * Cancels the binary runner */ public void stop() { synchronized (runnerJob) { isStopped= true; // make sure job is not scheduled afterwards runnerJob.cancel(); } - waitIfRunning(); } private class Visitor implements IResourceProxyVisitor {