mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

bug 284295: Hardcoded semicolon separator when appending to native environment variables

Browse source 
Patch from Marc-Andre Laperle
This commit is contained in:
Andrew Gvozdev 2009-11-17 02:34:32 +00:00
parent 3b31890d4e
commit aca23fae0e
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java
View file

@ -63,7 +63,7 @@ import org.eclipse.cdt.internal.core.envvar.UserDefinedEnvironmentSupplier;
* @noextend This class is not intended to be subclassed by clients. * @noextend This class is not intended to be subclassed by clients.
*/ */
public class EnvironmentTab extends AbstractCPropertyTab { public class EnvironmentTab extends AbstractCPropertyTab {
private static final String SEMI = ";"; //$NON-NLS-1$ private static final String SEPARATOR = System.getProperty("path.separator", ";"); //$NON-NLS-1$ //$NON-NLS-2$
private static final String LBR = " ["; //$NON-NLS-1$ private static final String LBR = " ["; //$NON-NLS-1$
private static final String RBR = "]"; //$NON-NLS-1$ private static final String RBR = "]"; //$NON-NLS-1$
private static final UserDefinedEnvironmentSupplier fUserSupplier = EnvironmentVariableManager.fUserSupplier; private static final UserDefinedEnvironmentSupplier fUserSupplier = EnvironmentVariableManager.fUserSupplier;
@ -472,12 +472,12 @@ public class EnvironmentTab extends AbstractCPropertyTab {
cfgs = new ICConfigurationDescription[] {cfgd}; cfgs = new ICConfigurationDescription[] {cfgd};
if (cfgd == null) if (cfgd == null)
vars.createVariable(name, dlg.t2.trim(), vars.createVariable(name, dlg.t2.trim(),
IEnvironmentVariable.ENVVAR_APPEND, SEMI); IEnvironmentVariable.ENVVAR_APPEND, SEPARATOR);
else else
for (ICConfigurationDescription cfg : cfgs) { for (ICConfigurationDescription cfg : cfgs) {
ce.addVariable(name, dlg.t2.trim(), ce.addVariable(name, dlg.t2.trim(),
IEnvironmentVariable.ENVVAR_APPEND, IEnvironmentVariable.ENVVAR_APPEND,
SEMI, cfg); SEPARATOR, cfg);
} }
updateData(); updateData();
setPos(name); setPos(name);
@ -528,7 +528,7 @@ public class EnvironmentTab extends AbstractCPropertyTab {
ce.addVariable( ce.addVariable(
name, value, name, value,
IEnvironmentVariable.ENVVAR_APPEND, IEnvironmentVariable.ENVVAR_APPEND,
SEMI, cfg); SEPARATOR, cfg);
} }
} }
updateData(); updateData();