From aca23fae0e1ec3f0bf54e5710aa03313cac2c766 Mon Sep 17 00:00:00 2001 From: Andrew Gvozdev Date: Tue, 17 Nov 2009 02:34:32 +0000 Subject: [PATCH] bug 284295: Hardcoded semicolon separator when appending to native environment variables Patch from Marc-Andre Laperle --- .../src/org/eclipse/cdt/ui/newui/EnvironmentTab.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java index fe55a09fc6b..c174b4a9cbc 100644 --- a/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java +++ b/core/org.eclipse.cdt.ui/src/org/eclipse/cdt/ui/newui/EnvironmentTab.java @@ -63,7 +63,7 @@ import org.eclipse.cdt.internal.core.envvar.UserDefinedEnvironmentSupplier; * @noextend This class is not intended to be subclassed by clients. */ public class EnvironmentTab extends AbstractCPropertyTab { - private static final String SEMI = ";"; //$NON-NLS-1$ + private static final String SEPARATOR = System.getProperty("path.separator", ";"); //$NON-NLS-1$ //$NON-NLS-2$ private static final String LBR = " ["; //$NON-NLS-1$ private static final String RBR = "]"; //$NON-NLS-1$ private static final UserDefinedEnvironmentSupplier fUserSupplier = EnvironmentVariableManager.fUserSupplier; @@ -472,12 +472,12 @@ public class EnvironmentTab extends AbstractCPropertyTab { cfgs = new ICConfigurationDescription[] {cfgd}; if (cfgd == null) vars.createVariable(name, dlg.t2.trim(), - IEnvironmentVariable.ENVVAR_APPEND, SEMI); + IEnvironmentVariable.ENVVAR_APPEND, SEPARATOR); else for (ICConfigurationDescription cfg : cfgs) { ce.addVariable(name, dlg.t2.trim(), IEnvironmentVariable.ENVVAR_APPEND, - SEMI, cfg); + SEPARATOR, cfg); } updateData(); setPos(name); @@ -528,7 +528,7 @@ public class EnvironmentTab extends AbstractCPropertyTab { ce.addVariable( name, value, IEnvironmentVariable.ENVVAR_APPEND, - SEMI, cfg); + SEPARATOR, cfg); } } updateData();