mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-07 17:56:01 +02:00
Code Issues Wiki Activity

Patch for Devin Steffler.

Browse source 
ArrayIndexOutOfBoundsException fix for DOMAST View
This commit is contained in:
John Camelon 2005-04-07 14:39:29 +00:00
parent 4cc19b628e
commit 7beab5038c
1 changed files with 21 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/DOMAST/DOMASTNodeLeaf.java
View file

@ -377,6 +377,11 @@ public class DOMASTNodeLeaf implements IAdaptable {
for(int i=0; i<interfaces.length; i++) { for(int i=0; i<interfaces.length; i++) {
Method[] methods = interfaces[i].getMethods(); Method[] methods = interfaces[i].getMethods();
for(int j=0; j<methods.length; j++) { for(int j=0; j<methods.length; j++) {
// multiple interfaces can have the same method, so don't duplicate that method in the property view
// which causes an ArrayIndexOutOfBoundsException elsewhere
if (alreadyEncountered(methods[j], desc))
continue;
if (methods[j].getParameterTypes().length > 0 || (!shouldInvokeMethod(methods[j].getName()))) continue; // only do getters, that aren't in the bad list (like clone()) if (methods[j].getParameterTypes().length > 0 || (!shouldInvokeMethod(methods[j].getName()))) continue; // only do getters, that aren't in the bad list (like clone())
TextPropertyDescriptor text = null; TextPropertyDescriptor text = null;
@ -398,6 +403,22 @@ public class DOMASTNodeLeaf implements IAdaptable {
return (IPropertyDescriptor[])ArrayUtil.trim(IPropertyDescriptor.class, desc); return (IPropertyDescriptor[])ArrayUtil.trim(IPropertyDescriptor.class, desc);
} }
private boolean alreadyEncountered(Method method, IPropertyDescriptor[] desc) {
StringBuffer name = null;
for(int i=0; i<desc.length; i++) {
if (desc[i] == null) // reached the end of the array
break;
name = new StringBuffer();
name.append(method.getName());
name.append(EMPTY_PARAMETER);
if (name.toString().equals(desc[i].getDisplayName()))
return true;
}
return false;
}
public Object getPropertyValue(Object id) { public Object getPropertyValue(Object id) {
if (!(id instanceof String)) if (!(id instanceof String))
return BLANK_STRING; return BLANK_STRING;