From 7beab5038c374bcc27748f6b324e0e2126dc224c Mon Sep 17 00:00:00 2001
From: John Camelon <jcamelon@ca.ibm.com>
Date: Thu, 7 Apr 2005 14:39:29 +0000
Subject: [PATCH] Patch for Devin Steffler. ArrayIndexOutOfBoundsException fix
 for DOMAST View

---
 .../cdt/ui/tests/DOMAST/DOMASTNodeLeaf.java   | 21 +++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/DOMAST/DOMASTNodeLeaf.java b/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/DOMAST/DOMASTNodeLeaf.java
index 4dfa44c1c87..d6f1137b158 100644
--- a/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/DOMAST/DOMASTNodeLeaf.java
+++ b/core/org.eclipse.cdt.ui.tests/src/org/eclipse/cdt/ui/tests/DOMAST/DOMASTNodeLeaf.java
@@ -377,6 +377,11 @@ public class DOMASTNodeLeaf implements IAdaptable {
 			for(int i=0; i<interfaces.length; i++) {
 				Method[] methods = interfaces[i].getMethods();
 				for(int j=0; j<methods.length; j++) {
+					// multiple interfaces can have the same method, so don't duplicate that method in the property view
+					// which causes an ArrayIndexOutOfBoundsException elsewhere
+					if (alreadyEncountered(methods[j], desc))
+						continue;
+					
 					if (methods[j].getParameterTypes().length > 0 || (!shouldInvokeMethod(methods[j].getName()))) continue; // only do getters, that aren't in the bad list (like clone())
 					
 					TextPropertyDescriptor text = null;
@@ -398,6 +403,22 @@ public class DOMASTNodeLeaf implements IAdaptable {
 			return (IPropertyDescriptor[])ArrayUtil.trim(IPropertyDescriptor.class, desc);
 		}
 		
+		private boolean alreadyEncountered(Method method, IPropertyDescriptor[] desc) {
+			StringBuffer name = null;
+			for(int i=0; i<desc.length; i++) {
+				if (desc[i] == null) // reached the end of the array
+					break;
+				
+				name = new StringBuffer();
+				name.append(method.getName());
+				name.append(EMPTY_PARAMETER);
+				if (name.toString().equals(desc[i].getDisplayName()))
+					return true;
+			}
+			
+			return false;
+		}
+		
 		public Object getPropertyValue(Object id) {
 			if (!(id instanceof String))
 				return BLANK_STRING;