mirror of
https://github.com/eclipse-cdt/cdt
synced 2025-09-10 12:03:16 +02:00
Debug BaseTestCase: don't swallow exception
Catching the exception and asserting false just hides the real reason, making failures harder to debug. Change-Id: I1a73fb5893da2762d0b9a9a496749643471f75b4 Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca> Reviewed-on: https://git.eclipse.org/r/39787 Reviewed-by: Marc Khouzam <marc.khouzam@ericsson.com> Tested-by: Marc Khouzam <marc.khouzam@ericsson.com>
This commit is contained in:
parent
ac6e5420d9
commit
41065c06e1
1 changed files with 5 additions and 10 deletions
|
@ -43,7 +43,6 @@ import org.eclipse.core.runtime.NullProgressMonitor;
|
|||
import org.eclipse.core.runtime.Platform;
|
||||
import org.eclipse.core.runtime.preferences.IEclipsePreferences;
|
||||
import org.eclipse.core.runtime.preferences.InstanceScope;
|
||||
import org.eclipse.debug.core.DebugException;
|
||||
import org.eclipse.debug.core.DebugPlugin;
|
||||
import org.eclipse.debug.core.ILaunchConfiguration;
|
||||
import org.eclipse.debug.core.ILaunchConfigurationType;
|
||||
|
@ -372,16 +371,12 @@ public class BaseTestCase {
|
|||
|
||||
}
|
||||
|
||||
@After
|
||||
@After
|
||||
public void doAfterTest() throws Exception {
|
||||
if (fLaunch != null) {
|
||||
try {
|
||||
fLaunch.terminate();
|
||||
} catch (DebugException e) {
|
||||
assert false : "Could not terminate launch";
|
||||
}
|
||||
fLaunch = null;
|
||||
}
|
||||
if (fLaunch != null) {
|
||||
fLaunch.terminate();
|
||||
fLaunch = null;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Add table
Reference in a new issue