From 41065c06e11155acaf4c1fcd7bef13f001cf3c33 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Fri, 16 Jan 2015 12:51:07 -0500 Subject: [PATCH] Debug BaseTestCase: don't swallow exception Catching the exception and asserting false just hides the real reason, making failures harder to debug. Change-Id: I1a73fb5893da2762d0b9a9a496749643471f75b4 Signed-off-by: Simon Marchi Reviewed-on: https://git.eclipse.org/r/39787 Reviewed-by: Marc Khouzam Tested-by: Marc Khouzam --- .../cdt/tests/dsf/gdb/framework/BaseTestCase.java | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/BaseTestCase.java b/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/BaseTestCase.java index e008c5b157f..56d8f27dace 100644 --- a/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/BaseTestCase.java +++ b/dsf-gdb/org.eclipse.cdt.tests.dsf.gdb/src/org/eclipse/cdt/tests/dsf/gdb/framework/BaseTestCase.java @@ -43,7 +43,6 @@ import org.eclipse.core.runtime.NullProgressMonitor; import org.eclipse.core.runtime.Platform; import org.eclipse.core.runtime.preferences.IEclipsePreferences; import org.eclipse.core.runtime.preferences.InstanceScope; -import org.eclipse.debug.core.DebugException; import org.eclipse.debug.core.DebugPlugin; import org.eclipse.debug.core.ILaunchConfiguration; import org.eclipse.debug.core.ILaunchConfigurationType; @@ -372,16 +371,12 @@ public class BaseTestCase { } - @After + @After public void doAfterTest() throws Exception { - if (fLaunch != null) { - try { - fLaunch.terminate(); - } catch (DebugException e) { - assert false : "Could not terminate launch"; - } - fLaunch = null; - } + if (fLaunch != null) { + fLaunch.terminate(); + fLaunch = null; + } } /**