mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-07-01 06:05:24 +02:00
Code Issues Wiki Activity

Bug 321383 - fixed performance issue for ProblemBindingChecker

Browse source
This commit is contained in:
Alena Laskavaia 2010-08-04 00:55:24 +00:00
parent 413b28ded9
commit 25147bd632
1 changed files with 1 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ProblemBindingChecker.java
View file

@ -16,7 +16,6 @@ import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker;
import org.eclipse.cdt.core.dom.ast.ASTTypeUtil; import org.eclipse.cdt.core.dom.ast.ASTTypeUtil;
import org.eclipse.cdt.core.dom.ast.ASTVisitor; import org.eclipse.cdt.core.dom.ast.ASTVisitor;
import org.eclipse.cdt.core.dom.ast.DOMException; import org.eclipse.cdt.core.dom.ast.DOMException;
import org.eclipse.cdt.core.dom.ast.IASTCompositeTypeSpecifier;
import org.eclipse.cdt.core.dom.ast.IASTExpression; import org.eclipse.cdt.core.dom.ast.IASTExpression;
import org.eclipse.cdt.core.dom.ast.IASTFieldReference; import org.eclipse.cdt.core.dom.ast.IASTFieldReference;
import org.eclipse.cdt.core.dom.ast.IASTFunctionCallExpression; import org.eclipse.cdt.core.dom.ast.IASTFunctionCallExpression;
@ -33,7 +32,6 @@ import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTQualifiedName;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTTemplateId; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTTemplateId;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPClassType; import org.eclipse.cdt.core.dom.ast.cpp.ICPPClassType;
import org.eclipse.cdt.core.dom.ast.cpp.ICPPFunction; import org.eclipse.cdt.core.dom.ast.cpp.ICPPFunction;
import org.eclipse.cdt.core.index.IIndex;
public class ProblemBindingChecker extends AbstractIndexAstChecker { public class ProblemBindingChecker extends AbstractIndexAstChecker {
@ -186,14 +184,7 @@ public class ProblemBindingChecker extends AbstractIndexAstChecker {
if (utils.getEnclosingCompositeTypeSpecifier(name) != null) { if (utils.getEnclosingCompositeTypeSpecifier(name) != null) {
return true; return true;
} }
IASTFunctionDefinition function = utils.getEnclosingFunction(name); return false;
if (name == null || function == null) {
return false;
}
IIndex index = name.getTranslationUnit().getIndex();
IASTCompositeTypeSpecifier composite = utils.getCompositeTypeFromFunction(function, index);
return composite != null;
} }
private boolean isInFunctionContext(IASTName name) { private boolean isInFunctionContext(IASTName name) {