From 25147bd6321952d4e10d6efb604aeb54c57b9667 Mon Sep 17 00:00:00 2001 From: Alena Laskavaia Date: Wed, 4 Aug 2010 00:55:24 +0000 Subject: [PATCH] Bug 321383 - fixed performance issue for ProblemBindingChecker --- .../internal/checkers/ProblemBindingChecker.java | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ProblemBindingChecker.java b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ProblemBindingChecker.java index 4c2bacff6a5..bb33c0a5f2f 100644 --- a/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ProblemBindingChecker.java +++ b/codan/org.eclipse.cdt.codan.checkers/src/org/eclipse/cdt/codan/internal/checkers/ProblemBindingChecker.java @@ -16,7 +16,6 @@ import org.eclipse.cdt.codan.core.cxx.model.AbstractIndexAstChecker; import org.eclipse.cdt.core.dom.ast.ASTTypeUtil; import org.eclipse.cdt.core.dom.ast.ASTVisitor; import org.eclipse.cdt.core.dom.ast.DOMException; -import org.eclipse.cdt.core.dom.ast.IASTCompositeTypeSpecifier; import org.eclipse.cdt.core.dom.ast.IASTExpression; import org.eclipse.cdt.core.dom.ast.IASTFieldReference; import org.eclipse.cdt.core.dom.ast.IASTFunctionCallExpression; @@ -33,7 +32,6 @@ import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTQualifiedName; import org.eclipse.cdt.core.dom.ast.cpp.ICPPASTTemplateId; import org.eclipse.cdt.core.dom.ast.cpp.ICPPClassType; import org.eclipse.cdt.core.dom.ast.cpp.ICPPFunction; -import org.eclipse.cdt.core.index.IIndex; public class ProblemBindingChecker extends AbstractIndexAstChecker { @@ -186,14 +184,7 @@ public class ProblemBindingChecker extends AbstractIndexAstChecker { if (utils.getEnclosingCompositeTypeSpecifier(name) != null) { return true; } - IASTFunctionDefinition function = utils.getEnclosingFunction(name); - if (name == null || function == null) { - return false; - } - IIndex index = name.getTranslationUnit().getIndex(); - IASTCompositeTypeSpecifier composite = utils.getCompositeTypeFromFunction(function, index); - - return composite != null; + return false; } private boolean isInFunctionContext(IASTName name) {