mirrors/mindcraft
1
0
Fork 0
mirror of https://github.com/kolbytn/mindcraft.git synced 2025-07-25 17:35:25 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions

perf: Optimize door detection for large paths

Browse source 
- Add path node sampling to limit max checks to 50 nodes
- Replace triple nested loops with strategic neighbor offset array
- Optimize duplicate detection with string-based position keys
- Reduce complexity from O(P×36) to O(min(P,50)×15)
- Addresses Copilot feedback on potential performance issues

Maintains full functionality while preventing slowdowns on long paths.
This commit is contained in:
Johnathan Walker 2025-06-26 15:28:33 -04:00
parent 601478f792
commit 866b2beb36
1 changed files with 41 additions and 32 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

73
src/agent/library/skills.js
View file

@ -1029,43 +1029,52 @@ async function detectDoorsInPath(bot, targetX, targetY, targetZ) {
const doorsInPath = [];
const checkedPositions = new Set();
// Check each point in the path for doors
for (const node of path.path) {
// Optimized door scanning: check strategic positions along path
// Sample path nodes to avoid O(n³) complexity on very long paths
const maxNodesToCheck = 50; // Limit scanning for performance
const nodeStep = Math.max(1, Math.floor(path.path.length / maxNodesToCheck));
for (let i = 0; i < path.path.length; i += nodeStep) {
const node = path.path[i];
const x = Math.floor(node.x);
const y = Math.floor(node.y);
const z = Math.floor(node.z);
// Check current position and adjacent positions for doors (focusing on horizontal movement)
for (let dx = -1; dx <= 1; dx++) {
for (let dy = -1; dy <= 2; dy++) { // Check up to 2 blocks high for doors
for (let dz = -1; dz <= 1; dz++) {
const checkX = x + dx;
const checkY = y + dy;
const checkZ = z + dz;
const posKey = `${checkX},${checkY},${checkZ}`;
// Optimized neighbor check: only check likely door positions
const neighborOffsets = [
// Direct adjacency (most common door positions)
[0, 0, 0], [0, 1, 0], [0, 2, 0], // Current position vertical
[-1, 0, 0], [-1, 1, 0], [-1, 2, 0], // West
[1, 0, 0], [1, 1, 0], [1, 2, 0], // East
[0, 0, -1], [0, 1, -1], [0, 2, -1], // North
[0, 0, 1], [0, 1, 1], [0, 2, 1] // South
];
for (const [dx, dy, dz] of neighborOffsets) {
const checkX = x + dx;
const checkY = y + dy;
const checkZ = z + dz;
const posKey = `${checkX},${checkY},${checkZ}`;
if (checkedPositions.has(posKey)) continue;
checkedPositions.add(posKey);
const block = bot.blockAt(new Vec3(checkX, checkY, checkZ));
if (block && doorTypes.includes(block.name)) {
// Check if door is closed
const isOpen = block._properties && block._properties.open;
if (!isOpen) {
// Quick duplicate check using position key
const doorKey = `${block.position.x},${block.position.y},${block.position.z}`;
const alreadyAdded = doorsInPath.some(door =>
`${door.position.x},${door.position.y},${door.position.z}` === doorKey
);
if (checkedPositions.has(posKey)) continue;
checkedPositions.add(posKey);
const block = bot.blockAt(new Vec3(checkX, checkY, checkZ));
if (block && doorTypes.includes(block.name)) {
// Check if door is closed (using _properties to match existing code pattern)
const isOpen = block._properties && block._properties.open;
if (!isOpen) {
// Check if this door is already in our list (doors can be 2 blocks tall)
const alreadyAdded = doorsInPath.some(door =>
Math.abs(door.position.x - block.position.x) <= 1 &&
Math.abs(door.position.y - block.position.y) <= 1 &&
Math.abs(door.position.z - block.position.z) <= 1
);
if (!alreadyAdded) {
doorsInPath.push({
position: block.position,
type: block.name
});
}
}
if (!alreadyAdded) {
doorsInPath.push({
position: block.position,
type: block.name
});
}
}
}