mirror of
https://github.com/eclipse-cdt/cdt
synced 2025-04-23 14:42:11 +02:00
ffffd11890
The protected method GdbLaunchDelegate.cleanupLaunch() has been removed. It has been replaced with GdbLaunchDelegate.cleanupLaunch(ILaunch). The complexity about not using a class field in GdbLaunchDelegate is that throughout the process of launching a session, we must be ready to cleanup the GdbLaunch object. The problem is that the platform does not provide that launch object in the methods preLaunchCheck() and finalLaunchCheck(), so we needed to store the launch object in a field. This patch delays the call to GdbLaunch.initialize() so that we don't need to cleanup the launch object if preLaunchCheck() and finalLaunchCheck() abort the launch. One hurdle was that we still needed to create the DsfSession when constructing GdbLaunch, so still needed to clean it up. This patch adds a check in GdbLaunch itself, when the launch is removed, to cleanup any lingering DsfSession automatically. I've tested every path that aborts the launch in GdbLaunchDelegate and confirmed that things are properly disposed of in every case. Change-Id: Ie2981a843917b464f1785a477871073227e027c3 |
||
|---|---|---|
| .. | ||
| org.eclipse.cdt.dsf.gdb | ||
| org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui | ||
| org.eclipse.cdt.dsf.gdb.multicorevisualizer.ui.tests | ||
| org.eclipse.cdt.dsf.gdb.tests | ||
| org.eclipse.cdt.dsf.gdb.ui | ||
| org.eclipse.cdt.examples.dsf.gdb | ||
| org.eclipse.cdt.gnu.dsf-feature | ||
| org.eclipse.cdt.gnu.dsf.source-feature | ||
| org.eclipse.cdt.gnu.multicorevisualizer-feature | ||
| org.eclipse.cdt.tests.dsf.gdb | ||