1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 14:12:10 +02:00
cdt/llvm/org.eclipse.cdt.managedbuilder.llvm.ui
Marc-Andre Laperle 00b30bb03a Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor
When a toolchain is selected along with its builder, the builder gets
matched to a “real builder” (ManagedBuildManager.getRealBuilder). If the
builder is abstract, the builder is not in the possible list of matches,
as implemented in Builder.getMatchKey. This causes
getCurrentBuilderCompatibilityInfo to return null which is not handled.

This patch changes the base LLVM builder to a non-abstract one, which
solves this specific NPE.
Also, in order to be more helpful to the user in case it happens to
another toolchain, a null check was added with an error message that the
builder is incompatible. Then at least, it is more clear that something
is wrong and the user can pick a different builder. 

Change-Id: I4d26c568dfe6307b496719c10908a36933fd3ab8
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
2017-02-19 21:51:36 -05:00
..
.settings llvm: Cosmetics (trailing whitespace) 2017-02-15 10:04:28 -04:00
doc Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
help Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
META-INF Move the rest of the CDT plugins to java 8 2016-06-22 14:51:43 -04:00
patches Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
scripts Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
src/org/eclipse/cdt/managedbuilder/llvm llvm: Cosmetics (trailing whitespace) 2017-02-15 10:04:28 -04:00
UML Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
.classpath Move the rest of the CDT plugins to java 8 2016-06-22 14:51:43 -04:00
.euml2 Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
.project Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
.umlproject Bug 338553 - import plugins from llvm4eclipse. Just importing everything 2013-03-03 22:50:09 -05:00
about.html Add llvm to the build. 2013-03-03 23:48:27 -05:00
about.ini Add llvm to the build. 2013-03-03 23:48:27 -05:00
about.mappings Add llvm to the build. 2013-03-03 23:48:27 -05:00
about.properties Add llvm to the build. 2013-03-03 23:48:27 -05:00
build.properties Bug 459567 - Help missing for LLVM Managed Build 2016-05-24 10:48:45 -04:00
cdt_logo_icon32.png Update to new CDT Logo 2014-12-16 13:29:12 -05:00
plugin.properties Bug 413771: Dialect category and options for language standards for LLVM toolchains 2013-08-12 13:09:10 -04:00
plugin.xml Bug 512096 - Fix NPE selecting an LLVM toolchain in toolchain editor 2017-02-19 21:51:36 -05:00