1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-23 14:42:11 +02:00
cdt/codan
Alex Blewitt 6bdca5f4a2 Bug 492230 - Replace buffer.append(a+b) calls
When using a `StringBuilder` or `StringBuffer` to create a string message,
using implicit string concatenation inside an `.append()` call will
create a nested StringBuilder for the purposes of creating the arguments,
which will subsequently be converted to a String and then passed to
the outer StringBuilder.

Skip the creation of the intermediate object and String by simply
replacing such calls with `buffer.append(a).append(b)`.

Where values are compile time String constants, leave as is so
that the javac compiler can perform compile-time String concatenation.
Ensure that NEWLINE isn't appended in such a way since it is not
a compile time constant `System.getProperty("line.separator")`

Change-Id: I4126aefb2272f06b08332e004d7ea76b6f02cdba
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
2016-04-25 11:38:47 -05:00
..
org.eclipse.cdt.codan.checkers Update copyright dates 2016-02-11 01:50:14 -05:00
org.eclipse.cdt.codan.checkers.ui Incremented CDT features version to 9.0.0 2016-01-18 16:37:47 -05:00
org.eclipse.cdt.codan.core Bug 492230 - Replace buffer.append(a+b) calls 2016-04-25 11:38:47 -05:00
org.eclipse.cdt.codan.core.cxx Bug 486610 - Fixed a highlight problem in reportProblem method 2016-02-23 16:59:59 -05:00
org.eclipse.cdt.codan.core.test Bug 491825 - Remove primitive wrapper creation 2016-04-16 12:17:48 -04:00
org.eclipse.cdt.codan.examples Update copyright dates 2016-02-11 01:50:14 -05:00
org.eclipse.cdt.codan.ui Missing copyright header. 2016-02-01 12:47:41 -05:00
org.eclipse.cdt.codan.ui.cfgview Bug 491984 - Replace .equals("") with .isEmpty() 2016-04-19 13:35:54 -04:00
org.eclipse.cdt.codan.ui.cxx Update copyright dates 2016-02-11 01:50:14 -05:00