Add enforecment script that verifies that only specified file types are
allowed to be mared as executable.
Change-Id: I4b40e3a46b03bfc78a9dcd52e8bf29cb079b7f3b
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
This will enforce formatting when building the native code
Change-Id: I6c047f4c0672609df322b7ba716fc786f0e3aab4
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
Added a new C/C++ formatter profile called "Unmanaged profile 'CDT'"
(name stolen from the Java formatter) that is basically K&R with the
tweak of maxium line width set to 120 (same width as for .java files).
Added enforcement of the formatter during build.
libspawner.so/jnilib have differences because the re-formatting changes
line numbers and therefore the __LINE__ macro expands to a different
value.
Change-Id: Id3a0619cb31640c7817dc684c72139f90cab0fc6
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
List as many as possible of the failed bundles when doing the baseline
compare.
Change-Id: I0d2817c418cf865f7fc6ea1c7e25d5b3b7b41bd5
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
As more checks have been added it has gotten a little unweildy.
The new script "do_all_code_cleanups.sh" now does most of the code
formatting checks.
Change-Id: I65fd888c88e1d7e470ed5621cee18ff3bf6680b4
As mentioned in
https://devblogs.microsoft.com/oldnewthing/20180103-00/?p=97705,
Microsoft has stopped using the _IMAGE_FILE_HEADER.TimeDateStamp as a
time stamp and rather as a hash of the source files to make the build
result predictable.
Change-Id: I4f4a7b9557330e4c478ef7fb25653144c5b2d4ad
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
Because we build cross platform, we want to make sure no unexpected
dependencies are introduced on newer or non-universal libraries
in the native code.
Change-Id: Ib8ffeb5f374bcd04514c31dca9d8297fed70343a
Also generate JNI header for serial component. This component does not
really need it since the implementation is in one file only, but this
would at least throw an error if the java part changes and the native
part is not updated accordingly.
Change-Id: Id598410c322580bdda37c905ed08627390c913ba
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
The native directory can contain both libraries and utilities. In
Gerrit https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/165270,
there is a utility, so the directory name "jni", or even "library" does
not work. In order to support both utilities and libraries, the
suggested name of the directory is "native_src" and thus, this commit
syncs that change in o.e.c.native.serial.
Change-Id: Iafa9ce9ae1dca7ef563ab397e8b3eb0b8642372d
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
When git is configured to honor executable bit for files
(core.fileMode=true), the .exe and .dll files in the
repository needs to have execute bit set to be able to run
Eclipse in runtime mode on Windows.
For more details:
https://git-scm.com/docs/git-config#Documentation/git-config.txt-corefileMode
"Git for Windows" does not appear to have this problem,
but at least Cygwin does.
Change-Id: I4c164f6d99219d461c301189f101ccbf63debb50
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
This commit on its own fails cleanliness, but is separated out
to make review easier. The subsequent commit is the result of
cleaning the code with the script
Change-Id: Ibaddc2f338f14fbe60662acc8cb272b584a1a828
Expand the copy mask for .settings/org.eclipse.pde.*, copy only
$COREPROJECT/.settings/org.eclipse.pde.prefs
$COREPROJECT/.settings/org.eclipse.pde.api.tools.prefs
Change-Id: I54d3bb65bb8b2a6d1054bff84fd6185e3fec67ef
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
Now that this script does not need to be in a common place
for launchbar and tools.templates bring it back into the main
repo.
Change-Id: Ia3033a44bbb809e9163b8cf6b14b49e63f151dd1
The check-code-cleanliness CI jobs have not been running recently,
so this commit is to the code up to those minor changes
Change-Id: I9fb4b0213dec558f58c5ca718b3d2685564ef456
The DSF Examples contains some commented out source that is enabled
via a script so this commit cleans that up for new formatting rules.
Change-Id: I82c5e195cc3746415c659b2c0fc72b8118cdc56c
The previous alignment of all the warnings/ignores
led to too many warnings that weren't there before. This
commit relaxes them a bit.
The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs
is still the "master" copy, with
releng/scripts/check_code_cleanliness.sh containing the
exceptions that apply to test plug-ins.
Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
git ls-files has two benefits:
- Only finds tracked files
This is necessary because we were having a few cleanups
being attempted on ignored files.
- Is much faster
Change-Id: I5a53497f8ef9c839676b7ef7e3be35171140f4b9
This commit contains the formatter settings and compiler settings,
using org.eclipse.cdt.core as the master for .settings and
a script to copy them to all the other projects with
apply_jdt_prefs_to_all_projects.sh
Change-Id: Ifd1a45879bed716273cae0ea05b55f629210c36e
Script based on work done by Lars Vogel on Eclipse Platform.
See https://git.eclipse.org/r/#/c/127598/
Change-Id: Ic8d04a20c955179645fdeeb11cb3861d7b31fa3f
There is also a new script to verify completeness of .gitattributes:
releng/scripts/verify_gitattributes.sh
Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b