The use of toString().toEmpty() is a potential code smell, and has
identified a couple of places where this pattern could be optimised.
Change-Id: I1a37e62ed8546a48151a494e9f24fea46d9d2497
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
- Wait until binary file exists after building instead of sleep
- Replace waiting loop with waitUntil methods with bigger timeouts
- Replace menu detection with faster and more reliable method:
- Find menu items in specific shell
- Use waitUntil with small timeout to detect absent menu items
Change-Id: I5239fa5dab9e091936addf6ceb9ef05095d23bd3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
In many cases a String's empty status is tested with `.equals("")`.
However, Java 1.6 added `.isEmpty()` which can be more efficient since
it compares the internal length parameter only for testing. Replace
code using the `.isEmpty()` variant instead.
Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()`
where it is already known that the `expr` is not null; however,
these have to be reviewed on a case-by-case basis.
Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
The implementation of `ToolReference::getToolCommand()` different from its
neighbours by checking if the `parent` was non-null. Change this so it looks for
the `parent` being null and swap the bodies of the `if` statement around to
maintain compatibility.
Change-Id: I8a188b350f94db9b1bd9d240b7a7320a930280a2
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Replace all occurrences of `new String(expr)` with `expr` provided that the
`expr` is not a byte array or a char array.
Change-Id: Iecae801b83084908b60b9e146eba87550eac640d
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Occurrences of `new String("...")` have been replaced with a direct reference
to the literal it was wrapping.
Change-Id: Iefb49a009f210db59e5724e0a232dba2e13292b1
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Occurrences of `new String()` have been replaced with the equivalent `""` and
additional NON-NLS tags have been inserted in where appropriate.
Change-Id: I54cf71dcd0d5a92a675a71166d66949533de502b
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Using `new Integer` and other wrapper types such as `new Character` results in
potential extra heap utilisation as the values are not cached. The built-in
`Integer.valueOf` will perform caching on numbers in the range -128..127 (at
least) using a flyweight pattern. In addition, parsing `int` values can be done
with `Integer.parseInt` which avoids object construction.
Adjust tests such as `"true".equals(expr)` to `Boolean.parseBoolean(expr)`.
Change-Id: I0408a5c69afc4ca6ede71acaf6cc4abd67538006
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
Neon generified ListenerList so cleanup here too.
Change-Id: I569ddf79d4cc0e805da5083867f3c403aa6d79b9
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
From JLS 15.27.1.
It is a compile-time error if a lambda parameter has the name _ (that
is, a single underscore character).
The use of the variable name _ in any context is discouraged. Future
versions of the Java programming language may reserve this name as a
keyword and/or give it special semantics.
Change-Id: I6f357dcc8f1eea933c6fc3afb474982e6d6210fe
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
Move the new build system to cdt.core and remove the previous
plugins. Hook the new system into scanner info and environment
variable manager.
Clean up API in preparation for Neon and API lockdown. Hook up
Qt to the new APIs.
Add discovery of MSYS2's toolchain and Qt and Qt's MinGW toolchain.
Change-Id: I85b1a91da4a44e86f0e9da9310f8106c894623e0
During the testsuite refactoring that significantly improved the DSF
suite (Commit 528de33113) some info
was lost from the code. This resurrects those comments.
Change-Id: I0a11dee2dcabb0800306880fc7c6217374bc337a
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
MappingSourceContainerBrowser has long since replaced
with NewMappingSourceContainerBrowser.
PathMappingDialog has long since replaced
with MappingSourceContainerDialog.
Change-Id: I67bd6640d5e75608c9b3d616285914987ff38f98
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
A bug was fixed in SWTBot and it doesn't throw
IndexOutOfBoundsException anymore. A test was relying on that.
Change-Id: I807aaa773b8544172cf33cbf1a04583fe171bd51
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Old SWTBot from Eclipse Mars had a dependency on
o.e.c.runtime.compatibility but this was removed in Eclipse 4.6 M3.
It suddently stopped working now because the Eclipse 4.6 milestones
composite repository doesn't contain the old milestones anymore.
Change-Id: I43608f0142e26d4bee175f0bc3cf921b00ffbb96
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Updates:
- references from CVS to git
- Old version of SDK to more recent version
- many typos
Change-Id: Ibea3ec63ddf0ddf6a17ed976885ef0cf593ea3d8
Signed-off-by: Stefan Sprenger <stefan@sprenger.software>
When using memory spaces, a backend may sometimes qualify an address
to specify the memory space to which the address belongs. However, to
minimize impacts, the memory space qualifier may not always be present.
In such cases, the address is implied to belong to the "default" memory
space.
DSF-GDB currently has no means to know what is the "default" memory
space to apply in such cases.
This change introduces a new API to request the default memory space
from the memory service.
Change-Id: Icea87543b8529756aee92c6d2af95fb936f5fb9c
Allow to easily run only Supported or Unsupported tests
Only run Supported versions in test suites
Change-Id: I0d628c8aea28dad77df7943b8b1ee18df5bb6bcf
Build windows using mingw cross on Ubuntu. Clean up Makefiles
and remove unused Windows code.
Change-Id: Ic2d36ddbef7e4eecfcee12a496b923326c8a51c6
Signed-off-by: Jonathan Williams <jonwilliams@qnx.com>
This commits adds support for the stand-alone debugger on Mac OS X
for both the RCP (product) and the script. The script had to be
modified slightly because of the different installation layout on Mac
and also the use of non-standard arguments to the 'find' command.
Change-Id: I24e4fec98803689dbaadb1dcfa651e431d4188a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
The depedency was added to the product before but not to the script.
This means the stand-alone debugger worked in the form of the
product but not the script bundled as part of other Eclipse products.
Change-Id: I3e9da14a7522524a6bec73d3d9e9d22263f17093
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
