Those features have the exact same id and groupid than a plugin
which throws off SonarQube with:
"Two modules have the same id: 'org.eclipse.cdt:org.eclipse.cdt.util'.
Each module must have a unique id."
In the pom.xml, we can specify a different groupid which resolves the
problem. Alternatively, the feature id could have been changed but that
would break upgrades.
Change-Id: Ib2912ad854a3af431b96f89a6ead1bcb6d06ba60
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
From my experience, bad things happen if the user specifies a
non-absolute path in the box labeled "Remote Absolute File Path for
C/C++ Application". This patch adds a validation to the tab to make
sure that the path is a valid absolute POSIX path.
This assumes that we do not support remote launching on Windows targets,
and therefore do not need to specify paths such as "C:\foo\bar.exe".
Change-Id: I20367078ff20179f0515272afee17d0986940309
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
Instead of calling "chmod +x" by hand, use IFileStore.putInfo to set the
file attributes. Since we already use the IFileStore API to copy the
file, it makes sense (and it's cleaner) to use it to set the executable
attribute as well.
In most cases, it wouldn't be needed to make the file executable, since
it should already be on the host filesystem and IFileStore.copy
transfers the attributes. However, it's still good to force it
executable in case it's not already for some reason.
Change-Id: I4c86e36265962781d4541aaceeb40b502248f674
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
This patch converts RemoteHelper.remoteFileDownload to use SubMonitor
instead of the deprecated SubProgressMonitor.
The remoteFileDownload operation consists of two sub-operations, to
which I assigned the following weigth:
- Download the file to the target (95%)
- Change the permissions (5%)
Ref: http://www.eclipse.org/articles/Article-Progress-Monitors/article.html
Change-Id: I8336f8e853e811a4350f1a63ba64934121ace5d8
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>
This removes a lot of pom.xml from the source tree. This is using the
"POM-less" Tycho functionality.
See
https://wiki.eclipse.org/Tycho/Release_Notes/0.24#POM-less_Tycho_builds
One advantage of this is that you do not need to update the version in
the pom.xml when you change it in the MANIFEST.MF because the pom.xml is
automatically generated. This also reduces a lot of the duplicated
information and pom.xml repetition.
- Maven 3.3 and up is required.
- Only eclipse-plugins and eclipse-features can be pom-less.
Repositories, target and others still have pom.xml.
- New parent poms are added because a parent is necessary directly one
level above the plug-in/feature that will have its pom generated
- Some test plug-ins had to be renamed .test -> .tests because it's
required so that it detects that it's a test plug-in
- Some suites were renamed so that they all use the same consistent name
"AutomatedIntegrationSuite"
- Profiles were added for the more common test configurations. They are
activated by the presence of simple .properties files that only serve to
activate the correct profile. The profiles:
- One for UI tests (UI present and start in UI thread)
- One for SWTBot tests (UI present and do not start in UI thread)
Other test plug-ins that are too different are kept intact and still
have
a pom.xml
- Fragments are kept intact since they all have different target
platform configurations
Change-Id: I9d73380eb766f547830c552daf08053a30b1845c
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
This commit removes explicit source features and has tycho create them
automatically, along with all other source features that were not
previously defined. The logic to auto-generate is in the root pom.xml
For all pre-existing source feature, the name presented to the user has
been changed to use the default name used by Tycho, which is "Developer
Resources". This will provide a more standard user-experience with
respect to other source features built by Tycho.
Existing SDK features are kept for backwards compatibility.
All the names of the auto-generated source features that replace an
existing source feature have stayed the same except for the
'testsrunner' feature; for that one name change, a p2.inf file is added
to allow upgrading from the old named feature to the new named feature.
Change-Id: Ie632e798c93898fd828f88df4983fc43e2749d22
The org.eclipse.cdt.launch.remote feature is the only non-source,
non-sdk feature to include the corresponding source plugin for it's main
provided plugin. An org.eclipse.cdt.launch.remote source-feature should
be created to provide the source plugin.
Change-Id: I2e396270f0d19f023e75452c316da0e4eda495b1
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
This patch addresses an issue in the "Select Remote C/C++ Application
File" browse dialog:
- The remote browse dialog's selected file or directory is still used
in the launch configuration, even if the user cancels the browse dialog
Change-Id: Ib535254d681a349b2aadfe91adfc73d633a16e90
When uploading a file to a remote system, the file permissions are updated,
however the process taking care of it may not have completed this task before
the application tries to use it.
This change forces the calling thread to wait for Max 1 sec for it to complete,
If the process task takes longer an exception is thrown so the application can
provide a meaningful message to the user.
A second fix is provided in: execCmdInRemoteShell
So this method now makes sure that the remote connection is opened
before executing commands over the remote shell.
Change-Id: Ibe8bd2709e1b1f446e1f74aa8a3df424ac7fa650
Adding an explicit dependency to o.e.remote at feature level,
so the dependecies are loaded at the installation of the
launch remote feature
Change-Id: I90f6bd29cd1b6f2efc46e241520621bbd256ffef
Solaris Sparc support was removed in SWT therefore it cannot be
supported by CDT anymore.
Change-Id: Ic40f55632023fd77fd164d3e48b5ca06835c3a31
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Replaced RSE with o.e.remote on C/C++ remote run
and debug launchers.
Change-Id: I308b81ad90ae8e838557d7b2afb53efb1cdf7ff9
Signed-off-by: Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
In many cases a String's empty status is tested with `.equals("")`.
However, Java 1.6 added `.isEmpty()` which can be more efficient since
it compares the internal length parameter only for testing. Replace
code using the `.isEmpty()` variant instead.
Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()`
where it is already known that the `expr` is not null; however,
these have to be reviewed on a case-by-case basis.
Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
API Breaking changes:
- The old RemoteCMainTab.java was removed. RemoteCDSFMainTab should be
used.
Move Remote Run launch to use RemoteCDSFMainTab
Remove plugin.xml definition of the tabs associated with the removed CDI
Remote debug launch.
Change-Id: Ie71497aa745295cc696b2679aa3047d9895d2481
This is the first change to remove CDI from CDT. The CDI model
implementation is removed along with everything that directly
depends upon the implementation.
This commit does not include refactoring or moving classes. The few
insertions are the minimum necessary.
Change-Id: I80274e1a0d77bc7bb00a2afe4babc00c4f7613ae
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
org.eclipse.cdt.launch.remote and org.eclipse.cdt.launch.remote-feature had
the same artifactId and groupId. This made Sonar fail and is probably an
oversight anyway.
Change-Id: I026e5a67ddd811db75c1b0cb59dcb734fce9f446
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
getAdaptable() in 4.5 M6 has changed to use generics, making casting its
result no longer necessary.
Change-Id: Idd943216a925576bb72c784b2c5a2a4b8e8b00d2
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Partial revert of commit 196d978624.
The removed change was causing a problem where the connectionCombo
pulldown was being set to its first element even for existing LC
Change-Id: I6888f2f783a303770d2924d0351b5dd7b5c055cc
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
java.io.File is used to store the path to the cross tools.
getAbsolutePath is invoked before variables are expanded. Hence File
cannot see the path is already absolute and therefore prepends CWD.
Reverted to getPath, since conversion to full path would not make sense
anyway.
Change-Id: I13e5b2c0d7747741926a88e120d13003b910e8c6
Signed-off-by: Morten Kristiansen <millibit@gmail.com>
This is breaking downstream builds.
This reverts commit 18e6101a53.
Change-Id: I5dd2ee129518757866ab832c683b648d13b07b83
Reviewed-on: https://git.eclipse.org/r/38594
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
features
Change-Id: I52a71e62f8161990657e96ef52403fd7f69698a2
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27499
This means that:
- feature.xml files now make a reference to the shared license plugin
using version 0.0.0
- feature.properties files no longer have the text for the license
- license.html and epl-v10.html files are removed as they are part
of the shared license plugin
- build.properties files no longer reference removed files
- the main pom.xml file references the license repository
Change-Id: Ibd880480de3a07597084d44cce7b822903509079
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27250
