We've seen a deadlock during startup mainly caused by CDT but triggered
when the launch bar manager initialized. This moves the init to a job
where it should be anyway to ensure smooth startup.
Change-Id: Id4b63e07dca3f96c561d6b4f45d60cf7cbcf530c
Reviewed-on: https://git.eclipse.org/r/35235
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
The launch bar manager was missing the line to actually remove the
launch target in launchTargetRemoved. Added a test to detect that.
Also fixed the Config Edit page. Name verification was failing since
it was comparing against the false configs created when the tabs
are initialized. We clean up now right after that init.
Change-Id: I9cff816040f2e1866c9454cb00f69ec4468225d4
Reviewed-on: https://git.eclipse.org/r/34477
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
to test a previous commit I made directly accidentally.
Change-Id: Ia78de20a35e8288b58ba802c4215eb8abc2aff1f
Change-Id: I615c2673a0b2d091d71ffcf21a25fcc5b447e4f0
Reviewed-on: https://git.eclipse.org/r/33649
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
Pretty major changes but heavily reduce the size of the API. Check
out the ILaunchBarManager which now only supports providers. All other
methods are now for internal use by the UI plugin. Also change to the
model. The extension point has much more documentation now. Please see
it for an explanation. But essentially made launch configuration types
part of the model to make a nice cleaner bridge to the platform.
Also includes change to Launch Targets view to make it a common
navigator so different target types can add objects to the tree.
Also a number of changes to try and delay plug-in loading with the
providers.
Change-Id: Icdd300e99f831c84cd0a25a23410aa1cd2ccfd7c
Reviewed-on: https://git.eclipse.org/r/33061
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
Jacoco arguments are missing when executing certain tests. This happens when
argLine is being overriden. We had the same problem in Linux Tools. We solved
it by prepending the argLine with ${tycho.testArgLine}. This should help
improving the Code coverage metric in Sonar.
Also update the jacoco version to fix a bug when building with Java 8.
Change-Id: I7f73f40488efc01fc7d643940c1ac0d5950c900d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32507
Tested-by: Hudson CI
Reviewed-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
* Project provider to react on project changes (i.e. when nature
changed)
* Added concept of open descriptor - which will be visible in UI,
this will allow not to remap to null, reuse objects for other reasons,
and eventually I want to replace object map into 1:1 mapping without
nulls
* Removed throwing CoreException from getLaunchDescriptors (it does not
need to throw it)
* Project based type now checks if project is open
* Fixed copyright
* Added interface for ILaunchDescriptorProjectBased
Change-Id: I3277f5910c7df1bb4aa3e809dda3b61921dcad6e
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31321
* added tracing
* added method to get LCType without need for lc
* delete LC is nasty in platform, notificaton is sent after
it is deleted, have to store parametes somewhere else to be able
to handle it properly
* added toString to abstract classes
* allow config based type to have null config
* fixed loader for default provider extension (and added test for it)
Change-Id: I223684414eb51e18fe7f54113b1ae2055ddab1ae
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31043
Tested-by: Hudson CI
* added launchObjectUpdated API
* added tests for it
* changed abstract provider to use it instead of hack that it used
before
* fixed login in launchObjectAdded to correctly update object map
Change-Id: I697594c34097e5439ca1550d0d68758baf7208e2
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30830
Tested-by: Hudson CI
Initial tests and refactoring to support tests
Change-Id: Ia14961b4a13ad7e8f2e1d75be264243f7432fe2d
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30462
