Delegate to an instance of ImageRegistry instead, which is legal.
Change-Id: Ife10b526c54483143a9ef5599c4571844a60604d
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
With the fix for bug 536677, disposing a org.eclipse.ui.part.Page will
dispose also its site.
org.eclipse.cdt.dsf.gdb.internal.ui.console.GdbFullCliConsolePage.dispose()
calls super.dispose() and then accesses the page site, which results in
a NPE.
This change changes the order of disposal to the natural order,
extending class first and then the super.
Change-Id: I853c8c426b9ea4e1403cd9af34f9878f6379f72a
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
The automated license change didn't handle this case properly. Add the
missing #s.
Change-Id: I11ad2c22b3be7b4d3db66aa69386619007aa8b6e
Signed-off-by: Simon Marchi <simon.marchi@ericsson.com>
In some situations, it makes sense to have more than one GDB instance.
Allow to reuse the GDB controling layer to avoid more code duplication
than neccessary to have a second GDB session.
Change-Id: I641919157c5b86c14ff768c8cd3fcddc9dcdbeb2
Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@st.com>
Some commands, such as -file-list-exec-source-files, can generate
10s of thousands of lines of output.
Change-Id: I07fc3ef99bdd8e9247c75e2e9733e43b35657687
Signed-off-by: Baha El Kassaby <baha.elkassaby@gmail.com>
Also-by: Jonah Graham <jonah@kichwacoders.com>
Provides GDB version detection as a public API that can be used without
having a saved launch config, or having a launch config at all.
Change-Id: Ifaee337899c01fe7066b27f7d66484bfc728f5ed
Signed-off-by: Max Bureck <max.bureck@fokus.fraunhofer.de>
The DSF Examples contains some commented out source that is enabled
via a script so this commit cleans that up for new formatting rules.
Change-Id: I82c5e195cc3746415c659b2c0fc72b8118cdc56c
The previous alignment of all the warnings/ignores
led to too many warnings that weren't there before. This
commit relaxes them a bit.
The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs
is still the "master" copy, with
releng/scripts/check_code_cleanliness.sh containing the
exceptions that apply to test plug-ins.
Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
Some files which has other cleanups applied meant they needed to be
reformatted again. e.g. the removing of type parameters shortened
some lines of code that meant the wrapping changed.
Change-Id: I68ca09567b9530cc2a085c33923642b6de2ec77b
Command used:
# Remove space at eol in comments
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^(#.*)[ \t]+$/\1/' {} +
# Remove space at eol in blank lines
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^[ \t]+$//' {} +
# Replace escaped spaces at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\ $/\1\\u0020/' {} +
# Replace unescaped spaces at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\]) $/\1\\u0020/' {} +
# Replace escaped tabs at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\\t$/\1\\u0009/' {} +
# Replace unescaped tabs at eol with unicode
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\t$/\1\\u0009/' {} +
# Stage all changes
git add -A .
# trim any remaining whitespace and then identify and fixup
# manually
# Only dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/MessagesForDebugVM.properties
# needed this due to missing newline at end of the file
find . ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/[ \t]+$//' {} +
Change-Id: I858f16891fe001f4f7e62d5a4f904146e891cd39
Some Java files were missed, or other cleanups introduced
trailing whitespace. So clean it up with this commit.
Command used:
find . ! -path "./.git/*" -type f -name *.java -exec sed -i -E 's/[ \t]+$//' {} +
Change-Id: I18f5e3a3eb5352443c9e753d427bb8d06107b8a4
These were inserted in the past automatically by Eclipse but
newer tooling makes them redundant.
These were removed by doing a global find/replace on *.java files
using the following regular expression:
\t/\*\n\t \* \(non-Javadoc\)[^/]*/\n
Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant semicolons
and completing the wizard
Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant type arguments
and completing the wizard
Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Organize Imports
and completing the wizard
Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Format source code
- Remove trailing white spaces on all lines
and completing the wizard
Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
The releng/scripts/apply_jdt_prefs_to_all_projects.sh was run to
copy standard settings to all other projects.
Change-Id: I4436c947d7f0142f56b709e661379c3eb54f666b
There is also a new script to verify completeness of .gitattributes:
releng/scripts/verify_gitattributes.sh
Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
This is a follow up to 60d95da97b (Bug
399460) as in that change the reporting option inadvertently changed.
Change-Id: I1afe70632107ab388be09a707e8e9fc419f76b91
This change ensures that the Select Processes dialog remembers the
filter field input. This helps attaching to the same application without
having to input the filter text on each debug attach.
Furthermore with this change its possible to match a process name with
suffixes, without resorting to pattern matching symbols. E.g. match
"Eclipse" by typing "lipse".
Change-Id: I07a3bb1504f2f5e9626023d1097fcad78dfa9ac7
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
This change adds command line arguments to the information listed in the
"Select Processes" dialog, seen e.g. when attaching to a C++ application
to debug.
Change-Id: I18ab685f73cb1c16ed3ea935872f49afa1de9aab
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
With this change, the Select Processes dialog will remember its new size
if it was resized by the user.
Change-Id: I27161ae5b5332db87cc9876aa23cf8fd8c751a80
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
Guard against NULL oldValues, which is legitimate, in which case use an
empty Map.
Change-Id: I78ac252d3e91d431340320719cb57b32145813f0
Signed-off-by: John Moule <evil_bandit_betamax@yahoo.co.uk>
Resolve project-related string variables within the GDB command, based
on the launch configuration rather than the current selection.
Change-Id: I6fc5d2f1de515624aff59397de60d0c394acf72f
Signed-off-by: John Dallaway <john@dallaway.org.uk>
Include the error message in the message shown directly in the error
dialog.
Change-Id: I8d6e65353750ee59966ede59b75ebc6256658cb6
Signed-off-by: Samuel Hultgren <samuel.hultgren@st.com>
When shutting down eclipse and there is an active debug session, eclipse
might deadlock if it can't destroy the debug session and would normally
leave a zombie process for the eclipse instance. This fix allows
eclipse to properly shutdown if the debug session is destroyed in less
than 1 minute, else the IDE will simply be terminated.
Change-Id: Icb9b019c7ff2ec9cdc9870a392a657fe0dfde81b
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
When I fixed the assume on "remote" in commit 4a447ce1a6
I exposed this test as having not been run in a while and it has
bitrotten due to changes in the compiler behaviour and the bad
definition of fastTracepointsSupported. This commit brings the test up
to speed.
Change-Id: I5eee6af4de111d864465851de91889aecf875dfb
