Disassembly view is expected to be populated with lines that are fetched from a given source file. There might be the case where instructions on what lines to append are wrong. This results in a null response that will propagate through the code leading to a NPE.
The current commit is proofing the code from NPE by:
- removing the source position of the lines that were not found within the given file
- null checking the source before becoming a key element in the code flow
- adding logging if expected lines are not found in the given file
Resolves: #287
Warning in build.properties will be errors when they run
in the tycho build, like this:
```
Error: Failed to execute goal org.eclipse.tycho:tycho-packaging-plugin:2.7.5:package-plugin
(default-package-plugin) on project org.eclipse.cdt.core.tests:
/home/runner/work/cdt/cdt/core/org.eclipse.cdt.core.tests/build.properties:
bin.includes value(s) [test.xml] do not match any files. -> [Help 1]
```
So make them errors in the workspace so that the issue is
detected before push.
Some build.properties issues don't affect the build, but
are still indicative of a problem.
The only time the stack service is unavailable is:
1. Stack service hasn't been started yet
2. Stack service has been shutdown
3. Stack service never gets created
All of these cases are configuration error, except (2). In (2) the
stack service isn't available to do source lookup, so instead
of an error, simply return no file (aka null)
Fixes#53
The removed assertion was overly harsh and some combinations of fonts
and text meant that the assertion was being hit. This code
was based on LineNumberRulerColumn (platform.text) which has long
since removed the assertion - see
3e70d44d64
for the removed assertion.
Note that this change simply removes the assertion and does not
address all the possibilities of mixed fonts. I suspect that there
may be some (hopefully) small drawing errors if such mixed fonts
are used. This code (unlike platform text) will continue to
assume all lines are the same height.
Change-Id: I3801b05c96e2784aabe53b3a503dbdb86e6e10c0
The trail in the disassbemly view should have luminance going towards
the background color, that might be different color than white.
Contributed by STMicroelectronics
Change-Id: I9e00e71719cbd1fb40cc5e6de983aacbcb854106
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
This mostly is using diamond operator, but includes
adding missing @Override and organizing imports and
applying formatting improvements in the JDT formatter.
Change-Id: Id91cbff33b0a039cc5121945ffbc407ecba45866
The CDT Cleanup profile had a bunch of extra cleanups applied to it, this
prevents running the CDT cleanup profile manually to simulate running the
save actions on all Java files
Change-Id: Iad491e1258a4ba90d81d1457ea0f6779e3663e38
All the about.html files are updated, so every bundle that hasn't
already had a bump in 10.7 needs one now
Change-Id: I6143d2fbe77a58a3a6d2f4a226d96087117f9ac1
Over the years, there have been a few changes to the
ExpressionInformationControlCreator class in JDT that was never
backported to the CDT version of the class.
Below is a list of JDT commit id's for the changes that are ported with
this change:
* cdcbfc3d91770a370336a7e48fff3e33edcaab39 - Fix bitwise to boolean and
* eab4ed938be7938ecd72592249639084638a3933 - Dispose the context
* ce04ec5c162ac64796da816f4abfa5f415756382 - Set correct themed colors
Contributed by STMicroelectronics
Change-Id: Ib4cc1e65c796d811c84859f7ccb05940934e2890
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Use the current theme for the expression information control. If the
theme doesn't provide information colors use the old implementation
(system colors) as fallback.
Change-Id: I0096a730364994dbd39e37c561f217bd3ff5979c
Signed-off-by: Dominic Scharfe <dominic.scharfe@coseda-tech.com>
When the ICommandControlRefreshAllDMEvent is sent, open the coresponding
source file to the new stack frame. It could be the same or a completly
different file as before the event.
Contributed by STMicroelectronics
Also-By: Jonah Graham <jonah@kichwacoders.com>
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Change-Id: Ib99f19f444a5bae1d99072ec9ed07e5666732bb6
If the request montior is not marked done, the call can hang.
Contributed by STMicroelectronics
Change-Id: I9c7989e889d70d59d420a3d170e1587a2e2abafe
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Newer Tycho has a new feature that adds an extra header (Bundle-License)
to every plug-in. This commit includes omitting this new feature
rather than bumping every single version of every bundle in CDT.
See https://www.eclipse.org/tycho/sitedocs/tycho-packaging-plugin/package-plugin-mojo.html#deriveHeaderFromProject
Bundles have version bumps due to newer Tycho including newer
JDT compiler which leads to classfile differences.
Change-Id: Id536d75a92a30582418324e27d74008869f7dd3a
Memory region may change access rights during the execution time. For
example, in embedded, a memory location might be clocked or not clocked
depending om some SFR. As the region can be changed during the
execution time, it's not enough to use the initial flags.
Contributed by STMicroelectronics
Change-Id: Ida4d6ed69faf3fb6e515aa0a29fa90ea241135dc
Also-By: Anders Jansson <anders.jansson-ext@st.com>
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
Instead of silently having opcode bytes not display, show an ellipsis
in the last column of the opcodes if the length required for that line
is too long.
Change-Id: If1379846c2dd7111324933c2bd72244f6abade02
We receive a string from GDB and then display the same string to the
user. So instead of converting it internally into a Byte[] to then
convert it back into a String, keep it as a String.
This fixes a regression where some GDBs' output format was not as space
separated 8-bit-bytes, but as words or similar.
Change-Id: I4ea241ff9ea45165489604fee26a3593ec3f6756
Added missed license headers
Updated baseline for the parent pom to CDT 10.2
Updated version for pom.xml to 10.3
Updated version for features and bundles to CDT 10.3
Updated copyright for about.properties to be 2021
Incremented version + 100 where needed
Change-Id: I79666fcc0402fee6607499d7dce1eaf87a5f446d
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
There is no way to predict what the user might do during for example the
launch sequence, so as a last resort, tell the UI to drop all caches and
refresh the data as the last step of the launch sequence.
Change-Id: I97731c8286657a0fc1111ba41deb47863181a453
Also-by: Jonah Graham <jonah@kichwacoders.com>
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
