1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Commit graph

26153 commits

Author SHA1 Message Date
Jonah Graham
5b21097125 Bug 540373: Instructions on how to rebase an old commit onto master
Change-Id: I1bbb82b379c1540ba9c88e6bad35d535a11e150e
2018-11-24 17:50:05 +00:00
Jonah Graham
3859b78b71 Bug 540373: Cleanup warnings in tests
- Remove redundant super-interfaces
- Remove redundant null checks
- Remove redundant instanceof checks

Change-Id: I3e8adba818b58f8ae5b43682ace74812db5b9bb4
2018-11-24 11:32:04 +00:00
Jonah Graham
f869a3f247 Bug 540373: Post code-cleanup for DSF examples
The DSF Examples contains some commented out source that is enabled
via a script so this commit cleans that up for new formatting rules.

Change-Id: I82c5e195cc3746415c659b2c0fc72b8118cdc56c
2018-11-24 11:22:15 +00:00
Jonah Graham
37ed2c406d Bug 540373: Update the compiler warnings/ignores
The previous alignment of all the warnings/ignores
led to too many warnings that weren't there before. This
commit relaxes them a bit.

The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs
is still the "master" copy, with
releng/scripts/check_code_cleanliness.sh containing the
exceptions that apply to test plug-ins.

Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
2018-11-24 10:55:06 +00:00
Jonah Graham
1ca3067521 Bug 540373: Use git ls-files instead of find
git ls-files has two benefits:
- Only finds tracked files
   This is necessary because we were having a few cleanups
   being attempted on ignored files.
- Is much faster

Change-Id: I5a53497f8ef9c839676b7ef7e3be35171140f4b9
2018-11-24 10:55:06 +00:00
Jonah Graham
96b71a9a48 [releng] Add missing @since tag
Change-Id: I21eb74aaed8d789e8f7d68dae58bf83cddb8f138
2018-11-24 10:12:25 +00:00
Nathan Ridge
ac68d83566 Bug 541117 - NPE in CElementHyperlinkDetector.isLanguageKeyword
Change-Id: I4bd2155de5aa7a09cb9e68f57e1168bdaab76401
2018-11-24 02:09:32 -05:00
Jonah Graham
0c7b32c0dd Bug 541116 - fix whitespace
Change-Id: I8c345f0f4a531ecef78955512de488386c22fc7d
2018-11-23 17:26:38 +00:00
Nathan Ridge
240f017407 Bug 541116 - NPE in IndexToASTNameHelper.findMatchingASTName
Change-Id: I6440dd072841cfc7d9e8240024f7dee527954b57
2018-11-23 11:05:53 -05:00
Jonah Graham
d79977e17e Remove accidentally committed first prototype gdbstandalone.zip
Change-Id: Ie73dd49b031d6d4613ec7b297a07b040cbbbad41
2018-11-23 10:35:23 -05:00
Jonah Graham
1903ae1acd Bug 540373: Add a code cleanliness check script
Change-Id: Ib665e551469e512193ecdf36bd31667ea38408ea
2018-11-23 14:59:29 +00:00
Jonah Graham
8e811ccbd0 Bug 540373: Fix trailing whitespace in MANIFEST.MFs
Change-Id: I818e939ec4667bea4c7bcd5cd3c1af1a273ca0ce
2018-11-23 13:59:50 +00:00
Jonah Graham
3caea240a3 Bug 540373: Format some Java files that were missed
Some files which has other cleanups applied meant they needed to be
reformatted again. e.g. the removing of type parameters shortened
some lines of code that meant the wrapping changed.

Change-Id: I68ca09567b9530cc2a085c33923642b6de2ec77b
2018-11-23 13:59:46 +00:00
Jonah Graham
ff75ae80fa Bug 540373: Cleanup: Remove trailing whitespace in properties files
Command used:
# Remove space at eol in comments
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^(#.*)[ \t]+$/\1/' {} +
# Remove space at eol in blank lines
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/^[ \t]+$//' {} +
# Replace escaped spaces at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\ $/\1\\u0020/' {} +
# Replace unescaped spaces at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\]) $/\1\\u0020/' {} +
# Replace escaped tabs at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\\\t$/\1\\u0009/' {} +
# Replace unescaped tabs at eol with unicode
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/([^\\])\t$/\1\\u0009/' {} +
# Stage all changes
git add -A .
# trim any remaining whitespace and then identify and fixup
# manually
# Only dsf/org.eclipse.cdt.dsf.ui/src/org/eclipse/cdt/dsf/debug/ui/viewmodel/MessagesForDebugVM.properties
# needed this due to missing newline at end of the file
find .  ! -path "./.git/*" -type f -name *.properties -exec sed -i -E 's/[ \t]+$//' {} +

Change-Id: I858f16891fe001f4f7e62d5a4f904146e891cd39
2018-11-23 07:52:26 +00:00
Jonah Graham
be35c7327d Bug 540373: Cleanup: Remove trailing whitespace in Java files
Some Java files were missed, or other cleanups introduced
trailing whitespace. So clean it up with this commit.

Command used:
find .  ! -path "./.git/*" -type f -name *.java  -exec sed -i -E 's/[ \t]+$//' {} +

Change-Id: I18f5e3a3eb5352443c9e753d427bb8d06107b8a4
2018-11-23 00:53:06 +00:00
Jonah Graham
b4031b5a8b Bug 540373: Safely remove trailing whitespace from MANIFEST.MF
Change-Id: Iec292561511bc696ab8a7a617e50fbc089b7bff9
2018-11-23 00:42:21 +00:00
Jonah Graham
aa1040a21a Bug 540373: Remove '(non-Javadoc)' comments
These were inserted in the past automatically by Eclipse but
newer tooling makes them redundant.

These were removed by doing a global find/replace on *.java files
using the following regular expression:
\t/\*\n\t \* \(non-Javadoc\)[^/]*/\n

Change-Id: I59d3248020f10934fde1dda5b5a31e20bb188e19
2018-11-22 22:00:29 +00:00
Jonah Graham
eeb3006e27 Bug 540373: Cleanup: Remove redundant semicolons
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant semicolons
and completing the wizard

Change-Id: I3d3175cfdfadec4f815c551d486e42c9f57b80ce
2018-11-22 21:57:01 +00:00
Jonah Graham
caf2292768 Bug 540373: Cleanup: Remove redundant type arguments
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove redundant type arguments
and completing the wizard

Change-Id: Iaecc7010f097b4b1fabd29ccaa34ccb23a716fbf
2018-11-22 21:55:36 +00:00
Jonah Graham
8844a8f9f2 Bug 540373: Cleanup: Remove unnecessary casts
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Remove unnecessary casts
and completing the wizard

Change-Id: I287d4066b12fc19d7f73a016e11c9405abb4ceb9
2018-11-22 21:53:35 +00:00
Jonah Graham
8985c7b63f Bug 540373: Cleanup: Add missing annotations
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Add missing Annotations - and selecting all three types:
 - @Override
 - @Override on interface methods
 - @Deprecated
and completing the wizard

Change-Id: I5d367dacb04327107f25e147edc08efc4eb1c2fe
2018-11-22 21:51:31 +00:00
Jonah Graham
a923614c73 Bug 540373: Cleanup: Organize Imports
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Organize Imports
and completing the wizard

Change-Id: Ia7b305a4c967d0e6f4e8fb8c1041e7028b24006c
2018-11-22 21:47:02 +00:00
Jonah Graham
170e654b47 Bug 540373: Cleanup: Format & Remove trailing whitespace
This was done by selecting all projects in Eclipse then
Source -> Clean Up... -> choosing:
- Format source code
- Remove trailing white spaces on all lines
and completing the wizard

Change-Id: I63685372c6bcc67719bcf145123bcb72e5b00394
2018-11-22 21:47:02 +00:00
Jonah Graham
35996a5c5c Bug 540373: Standard .settings auto applied
The releng/scripts/apply_jdt_prefs_to_all_projects.sh was run to
copy standard settings to all other projects.

Change-Id: I4436c947d7f0142f56b709e661379c3eb54f666b
2018-11-22 21:47:02 +00:00
Jonah Graham
4f9a44aa3d Bug 540373: Standard .settings for JDT/PDE
This commit contains the formatter settings and compiler settings,
using org.eclipse.cdt.core as the master for .settings and
a script to copy them to all the other projects with
apply_jdt_prefs_to_all_projects.sh

Change-Id: Ifd1a45879bed716273cae0ea05b55f629210c36e
2018-11-22 21:47:02 +00:00
Jonah Graham
37f0f660c8 Bug 540373: Fix tests that rely on format of Java code
TestSourceReader.getContentsForTest() does not examine lines containing
@ to see if they have the test method. This means that changing
the formatting of this test could break it as the reader would see
the // comments as test data. Things which are comments and not
test data should have /**/ comments as this commit now does.

Change-Id: Ic30a63df3910c6a5643b4ac734c05526e3420095
2018-11-22 20:34:33 +00:00
Jonah Graham
086e6e30b7 Bug 540373: Fix tests that rely on whitespace at end of line
Change-Id: I2aa5d28e5fbd9ba1f12f6ec275ea1474730efe46
2018-11-22 20:34:33 +00:00
Jonah Graham
871c91ee5e Bug 540373: Fix declaration to interface
This file was always intended to be an interface. The discussion
on fixing this happened as part of the review to
change I240bbe08666b89861fe132c6384174be7883c022

Change-Id: I7ddd211f927f7089ed40abdf578ae10c0c437329
2018-11-22 20:34:29 +00:00
Jonah Graham
c5c5412f8d Bug 540373: Remove invalid javadoc API tags
Change-Id: I240bbe08666b89861fe132c6384174be7883c022
2018-11-22 20:33:28 +00:00
Jonah Graham
f70a8b35c1 Bug 540371: Update to EPLv2 using releng/scripts/change_to_eplv2.sh
Change-Id: Ifbb1d5af2a00bd5634dea200320e8c4303ffca6c
2018-11-22 20:31:51 +00:00
Jonah Graham
f0ce92d3b5 Bug 540371: normalize files before applying EPLv2
Change-Id: I8bfd427bba1df18579d6d5e58ad1e5d704485050
2018-11-22 20:30:13 +00:00
Jonah Graham
cd61252736 Bug 540371: Script for updating to EPLv2
Script based on work done by Lars Vogel on Eclipse Platform.

See https://git.eclipse.org/r/#/c/127598/

Change-Id: Ic8d04a20c955179645fdeeb11cb3861d7b31fa3f
2018-11-20 21:22:12 +00:00
Jonah Graham
48d2271a58 Bug 540373: Normalize newlines with .gitattributes
There is also a new script to verify completeness of .gitattributes:
releng/scripts/verify_gitattributes.sh

Change-Id: I2ce270852ab54b66b6c474a6ec94203fe5bba78b
2018-11-20 21:20:39 +00:00
Jonah Graham
3cf0297769 Bug 532077: Preserve Ignore Count set in the platform breakpoint
Change-Id: I19ad64254b0e9ed55114f2e83fe2f09e2aeac83c
2018-11-18 12:36:44 +00:00
Jonah Graham
090fc94fa0 Bug 536448: Require target platform bundles as minimum version
Without setting dependent plug-ins to minimum version to match the
target platform we are aiming for we can imply (and therefore let install)
CDT into older versions of Eclipse where CDT does not actually work.

This can be exposed in very odd ways, such as IllegalAccessError, when
platform has allowed API changes.

However, rather than update every single bundle in CDT, only the
o.e.cdt.core/ui bundles are being updated as this should achieve the
desired result without every other bundle needing to be touched.

Change-Id: Idf166bc4f4a39ad5096386e24cbff234c0238900
2018-11-17 20:41:49 +00:00
Jonah Graham
a7425a05b4 Bug 541270: Fix Restore Defaults for Console Prefs
Bug 414525 was trying to workaround Bug 270326/320723 but did not
handle the case that no plugin_customization.ini was provided.
This fix make Restore Defaults for Preferences ->  C/C++ ->
Build -> Console work again.

Change-Id: Idbacc2a0baece6c3f594cfac4a2eeece886bac80
2018-11-17 19:55:31 +00:00
Jonah Graham
39b6373f66 Bug 407405: Limit wrapping in Build Console
If the build console is too long word wrapping is very slow. The
underlying issue is Bug 168557, this is just a workaround so users
don't fall down this particular rabbit hole.

Change-Id: I1be3540003d475e2d5431295219198ae2db7862f
2018-11-17 19:55:27 +00:00
Nathan Ridge
e082f73b56 Bug 540957 - Implement equivalence checking for expressions
This is used for declaration matching in function templates.

Change-Id: I80044304b2d9dfda085a13f0cfc040f1200a2e1c
2018-11-17 03:02:51 -05:00
Jonah Graham
54f6c19de2 Bug 541069: Don't error on missing variables when doing substitution
This is a follow up to 60d95da97b (Bug
399460) as in that change the reporting option inadvertently changed.

Change-Id: I1afe70632107ab388be09a707e8e9fc419f76b91
2018-11-16 11:24:38 +00:00
Nathan Ridge
b6c1a085d1 Bug 540909 - underlying_type of typedef to enum
Change-Id: Ic4f48c4da79419d5404e132da2944ee2823ca41f
2018-11-15 21:47:11 -05:00
Marc-Andre Laperle
ef2b34f148 [releng] Fix missing dependency in stand-alone debugger
Change-Id: I347d47ea4689aa154ddb090b9cc05e7dc132959e
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-14 18:57:24 -05:00
Jonah Graham
41c369ee01 [releng] Update to newer tools.template for javax.xml.bind issues in Java11
Change-Id: I224e0248eb49feeea79b05ef394f94b943b2a6a6
2018-11-14 07:13:44 +00:00
Marc-Andre Laperle
7999eab841 Bug 516046 - NPE in AbstractDebugTextHover when hovering over undefined macro
Change-Id: If732a826801f025e929f711fa35a793545d0ed73
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-13 21:20:13 -05:00
Nathan Ridge
a561d301ca Bug 512297 - Improve propagation of semantic problem IDs
Change-Id: I3c95a244e88abe37f550370ff6c7c9aec2c102da
2018-11-13 17:46:50 -05:00
Doug Schaefer
afe7d18793 Bug 540978 Rename lsp plugins to be org.eclipse.cdt.lsp.*
To make it clear these are CDT's future :).

Change-Id: I64935e3998a46632f4f4006589a17eb01959eb27
2018-11-10 14:09:43 -05:00
Marc-Andre Laperle
f9250cb361 Add com.sun.xml.bind to target
This is a convenience for working in combination with the source
of o.e.tools.template which is not unusual.
Also add a few more missing things to Oomph setup for Java 11.

Change-Id: Ifc6105e251a7b8d855cf76401cdb3740c55f79c9
Signed-off-by: Marc-Andre Laperle <malaperle@gmail.com>
2018-11-09 15:09:34 -05:00
Jeff Johnston
331be6c45c Bug 540423 - C/C++ Container Launcher missing Port Binding
- add new ContainerPortDialog class to allow user to specify
  ports in the launch configuration Container tab
- add new ContainerTabModel and ExposedPortModel classes to
  support new functionality
- add new Ports group to ContainerTab and have a table
  where a user can add, edit, remove, and select ports
  for publishing to the host
- add new attribute ATTR_EXPOSED_PORTS to ILaunchConstants for
  saving and restoring user selected ports in C launch
  configuration
- add needed internal messages to support new port settings
  functionality
- bump up org.eclipse.cdt.docker.launcher version

Change-Id: I93b7503bdc141e3077418800352507ef38e65ab1
2018-11-08 17:57:23 -05:00
Hannes Vogt
f9c8f0da02 Bug 540676 - Improve parsing of alias templates
- If the argument for a template template paramter is unknown
(ICPPUnknownType), don't create a problem.
- Ensure that a possible argument-parameter mismatch is caught at
template instantiation time.

Change-Id: Ief61ef93f9d0c19d043aedb89f1c5e66c0374ef2
Signed-off-by: Hannes Vogt <hannes@havogt.de>
2018-11-06 10:31:06 -05:00
Jonah Graham
c3d4f06575 [releng] Update to newest maven-pmd-plugin
Change-Id: I357bdc57b8f1743928899fb91ac4a316008b58bf
2018-11-05 09:24:26 +00:00
Jeff Johnston
eea4bbabd6 Bug 540699 - NoClassDefFoundError in AutotoolsNewMakeGenerator
- use of CommandLaunchManager requires higher version of cdt.core
  than Autotools specified so up to 6.5.0

Change-Id: I315e69defeee9d7d1e6c016edff2d96013fe13e9
2018-11-02 10:46:29 -04:00