updateBuildConfigCombo originally accepted null as arument, restored
this behavior (it is not called with null from cdt code, but may be
called from overriding classes)
Change-Id: I7d0f271b2bd414d380a1804b838ce38fbdc7c0af
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
as discussed on cdt-dev I am trying to make ui look better
and more generic by replacing
"Select configuration using 'C/C++ Application'"
checkbox with Automatic selector.
Launch delegate or subclass on main page can control and override
behaivior of this ui control
This won't break API but it will break UI if subclasses were actually
doing something with original chechbox control
(besides not creating it).
Change-Id: I36f20bf05ff19e1fd66782e2351f18edc7d507cc
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/39619
Tested-by: Hudson CI
It is now located in the cdt/org.eclipse.launchbar repo. The intention
is to move it to a project lower down the stack so it can be reused
accross Eclipse.
Change-Id: I9d623fa372fcf6e345ba68a8830db190a75e0d28
Reviewed-on: https://git.eclipse.org/r/38266
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
This code is required if any LaunchTab interacts with other tabs in LC
Change-Id: I5d5e3b6d4e51b1f3ee0ac6297ebb4d88ad220224
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/36955
Tested-by: Hudson CI
We've seen a deadlock during startup mainly caused by CDT but triggered
when the launch bar manager initialized. This moves the init to a job
where it should be anyway to ensure smooth startup.
Change-Id: Id4b63e07dca3f96c561d6b4f45d60cf7cbcf530c
Reviewed-on: https://git.eclipse.org/r/35235
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
The launch bar manager was missing the line to actually remove the
launch target in launchTargetRemoved. Added a test to detect that.
Also fixed the Config Edit page. Name verification was failing since
it was comparing against the false configs created when the tabs
are initialized. We clean up now right after that init.
Change-Id: I9cff816040f2e1866c9454cb00f69ec4468225d4
Reviewed-on: https://git.eclipse.org/r/34477
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
fixed validation paths of the name/tabs markers
Change-Id: I0e6f1dbcde00ea00c351fdf377429026b8a83bd3
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/33923
Reviewed-by: Jonathan Williams <jonwilliams@qnx.com>
Has a page to select the target type. The INewWizard for the target
type is registered in the launchBarUIContributions extension point.
When selected and nextPage is hit, the wizard starts up.
Also some minor cleanup to the new config wizard.
Change-Id: Ic2bb5164d531a21b7a2a9dd7ecd109e18f2411cd
Reviewed-on: https://git.eclipse.org/r/34017
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
Only change the type when we're flipping to the next page. Also fixes
the order of initialization of the tabs to eliminate the NPEs that
were happening.
Change-Id: I9bb0a5d3ff646e4ca340f9c461e3a3c88f89e557
Reviewed-on: https://git.eclipse.org/r/34010
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
to test a previous commit I made directly accidentally.
Change-Id: Ia78de20a35e8288b58ba802c4215eb8abc2aff1f
Change-Id: I615c2673a0b2d091d71ffcf21a25fcc5b447e4f0
Reviewed-on: https://git.eclipse.org/r/33649
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
If a launchObject changes such that a new higher priority descriptor
type wants to take it over, we need to let it. This is handles on
the launchObjectChanged call.
I also added a note to the Project object provider as projects change
a lot and we only care about a subset of those events. Not sure how
to formalize that, though. Need to dig deeper into the deltas and
see what we can ignore.
Change-Id: I964d8785a474c43c917bcd7d8a84abf2b7904aa4
Pretty major changes but heavily reduce the size of the API. Check
out the ILaunchBarManager which now only supports providers. All other
methods are now for internal use by the UI plugin. Also change to the
model. The extension point has much more documentation now. Please see
it for an explanation. But essentially made launch configuration types
part of the model to make a nice cleaner bridge to the platform.
Also includes change to Launch Targets view to make it a common
navigator so different target types can add objects to the tree.
Also a number of changes to try and delay plug-in loading with the
providers.
Change-Id: Icdd300e99f831c84cd0a25a23410aa1cd2ccfd7c
Reviewed-on: https://git.eclipse.org/r/33061
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
Jacoco arguments are missing when executing certain tests. This happens when
argLine is being overriden. We had the same problem in Linux Tools. We solved
it by prepending the argLine with ${tycho.testArgLine}. This should help
improving the Code coverage metric in Sonar.
Also update the jacoco version to fix a bug when building with Java 8.
Change-Id: I7f73f40488efc01fc7d643940c1ac0d5950c900d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/32507
Tested-by: Hudson CI
Reviewed-by: Alvaro Sanchez-Leon <alvsan09@gmail.com>
This view lists all launch targets that could appear in the Target
selector. It allows us to add context menus to them to perform
operations, such as opening a terminal view to the target. It will
also gives us a cleaner UI to add and remove targets
Change-Id: I538a204ce6f25fd017573c50585ac45cdeeaf554
Reviewed-on: https://git.eclipse.org/r/31856
Tested-by: Hudson CI
Reviewed-by: Jonathan Williams <jonwilliams@qnx.com>
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
If provider does not return image or text, use default provider
Change-Id: I20bca6e5ef577f4e227d5e567820ba8d004cb85a
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31447
Tested-by: Hudson CI
contributions to LaunchBar
Change-Id: I577c0e1438090aaaf27bba34660169cde82a8e8c
Signed-off-by: Jonathan Williams <jonwilliams@qnx.com>
Reviewed-on: https://git.eclipse.org/r/31319
Tested-by: Hudson CI
Reviewed-by: Elena Laskavaia <elaskavaia.cdt@gmail.com>
project based descriptor must not accept launch configs without project
set
ownProject should not log exception when lc does not exist
Change-Id: I9a600641324b0ae22a2fdb99e68ff530cd1d33df
Reviewed-on: https://git.eclipse.org/r/31400
Reviewed-by: Elena Laskavaia <elaskavaia.cdt@gmail.com>
Tested-by: Elena Laskavaia <elaskavaia.cdt@gmail.com>
* Project provider to react on project changes (i.e. when nature
changed)
* Added concept of open descriptor - which will be visible in UI,
this will allow not to remap to null, reuse objects for other reasons,
and eventually I want to replace object map into 1:1 mapping without
nulls
* Removed throwing CoreException from getLaunchDescriptors (it does not
need to throw it)
* Project based type now checks if project is open
* Fixed copyright
* Added interface for ILaunchDescriptorProjectBased
Change-Id: I3277f5910c7df1bb4aa3e809dda3b61921dcad6e
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31321
there is an another API class which users should use, default is
strictly for cdt default provider
Change-Id: I70ad6db49c90d8465d3328edc4ec09949d2697fa
Reviewed-on: https://git.eclipse.org/r/31306
Tested-by: Hudson CI
Reviewed-by: Elena Laskavaia <elaskavaia.cdt@gmail.com>
Change-Id: I6bd238c69131933ca170d955352b7f899b245dfa
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31115
Tested-by: Hudson CI
Reviewed-by: Elena Laskavaia <elaskavaia.cdt@gmail.com>
Change-Id: I36eb28887f47dca62554cb2438b8ed62b044fb52
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/31114
Tested-by: Hudson CI
Reviewed-by: Elena Laskavaia <elaskavaia.cdt@gmail.com>
* added interface for CSelector to show one separator bar at given index
* change ConfigSelector provider to do special sorting
and set separtor index to 3, so first 3 elements are sorted by usage,
then all descriptors alphabetically (including first 3)
* persist descriptor order
Change-Id: Ib61d43abcb0da52f10d4b1e1ac7c0dc4f0d7958f
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30905
Tested-by: Hudson CI
* fixing default label provider for config selector, if no
contribution will default to launch config based image/name
Change-Id: I978f4071a2e5f7b25d0a1d345c676fdb7e43b263
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31056
* added tracing
* added method to get LCType without need for lc
* delete LC is nasty in platform, notificaton is sent after
it is deleted, have to store parametes somewhere else to be able
to handle it properly
* added toString to abstract classes
* allow config based type to have null config
* fixed loader for default provider extension (and added test for it)
Change-Id: I223684414eb51e18fe7f54113b1ae2055ddab1ae
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/31043
Tested-by: Hudson CI
* added launchObjectUpdated API
* added tests for it
* changed abstract provider to use it instead of hack that it used
before
* fixed login in launchObjectAdded to correctly update object map
Change-Id: I697594c34097e5439ca1550d0d68758baf7208e2
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30830
Tested-by: Hudson CI
Initial tests and refactoring to support tests
Change-Id: Ia14961b4a13ad7e8f2e1d75be264243f7432fe2d
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30462
* If provider only wants to associate lc type with target the
only thing is needed is to specy this lc type somewhere and framework
should take care of the rest
Change-Id: I3f60c7a0a5b1334f989e972fe8f773c6e2d7f71a
Signed-off-by: Alena Laskavaia <elaskavaia.cdt@gmail.com>
Reviewed-on: https://git.eclipse.org/r/30381
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
