Since TCF Terminals assumes xterm emulation, it requires a
tm.terminal 3.3.1 or later widget, since bug fixes from the widget
are required for this to work properly.
Change-Id: I7be8f355067bf385bb6b4171a1fbd7cbd2f9c102
Signed-off-by: Martin Oberhuber <martin.oberhuber@windriver.com>
Better close streams first before destroying the process.
An interactive program will terminate on EOF anyway.
On Windows process destroy takes > 1s because cmd.exe
does not respond to Spawner.terminate().
The https protocol should work through proxies just like http, so it
is easy for getting the initial code. But other than http, it also
allows pushing just by specifying the username and password generated
from Gerrit at https://git.eclipse.org/r/#/settings/http-password
This makes it preferable over git, ssh or other protocols.
Reduce function complexity and comply with java coding styles.
Convert some larger ifs to switches for performance sake.
Change-Id: Ief2672141511a1373cdd8a98e0fa2eeb564816e1
Signed-off-by: Matthew Khouzam <matthew.khouzam@ericsson.com>
Both Jetty 8 and Jetty 9 were getting included in the target platform. It seems
that those two versions can't co-exist and Eclipse fails to start.
Change-Id: I33e94458b34c339f8bffa5f64830958fe00a2e2d
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Make sure the layout of the terminal control happens before the terminal
is connected to the remote.
Change-Id: Ic12c93fb6fd459652836a5568f79f168a68d585f
Signed-off-by: Anton Leherbauer <anton.leherbauer@windriver.com>
Make sure the layout of the terminal control happens before the terminal
is connected to the remote.
Change-Id: Ic12c93fb6fd459652836a5568f79f168a68d585f
Signed-off-by: Anton Leherbauer <anton.leherbauer@windriver.com>
basically for the code like
if (a) return 1; else return 2;
a++; // this should be a dead code node
but we don't check connector node of "if" and don't add
it to dead nodes graph resulting it this code not being marked as dead,
which can lead to false positives or false negatives for checkers that
use that. Same apply for other control statements...
Change-Id: Iafb4b48ca960f0ffab2c0265285a31cb08eb0d11
Choose version 2.5.2 which is what is supported by CDT's HIPP. Note that by removing the version altogether, the latest available findBugs would be selected. However, this could lead to different results between manual builds and HIPP builds, which is why I thought it would be better to specify the version explicitly.
FindBugs can be run by adding the string
findbugs:findbugs
as a maven parameter, either in a local maven build, or on HIPP.
Add releng/findbugs-exclude.xml to control the errors shown by FindBugs.
The content of that file was copied from the TM project, but should
eventually be ajusted for CDT.
Change-Id: Ibc8348b9286f00580a4079a7ca3c669708bc6194
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
There is a superfluous LINE_MAIN_BEFORE_THREAD_START that is causing
problems, remove it.
Change-Id: I57c4637ada0b5efda2848029e5216a13cf638067
Signed-off-by: Simon Marchi <simon.marchi@polymtl.ca>