Change-Id: I5abc99be6aa8bf02b84a549c3c11fd929e9acbc7
Signed-off-by: Dan Ungureanu <dan.ungureanu@freescale.com>
Reviewed-on: https://git.eclipse.org/r/22149
Reviewed-by: Marc Khouzam <marc.khouzam@ericsson.com>
IP-Clean: Marc Khouzam <marc.khouzam@ericsson.com>
Tested-by: Marc Khouzam <marc.khouzam@ericsson.com>
Change-Id: Idce28724b7b7b1bc8c43528036b2697386ec76b7
Signed-off-by: Marco Trudel <marco@mtsystems.ch>
Reviewed-on: https://git.eclipse.org/r/21659
Reviewed-by: Thomas Corbat <tcorbat@hsr.ch>
IP-Clean: Thomas Corbat <tcorbat@hsr.ch>
Tested-by: Thomas Corbat <tcorbat@hsr.ch>
The Open Declaration (F3), etc. actions use code in the ASTProvider. If
the provider is not able to get an AST then the actions are disabled.
The implementation of the ASTProvider has an "instanceof CEditor" check
the result being that ASTProvider can only be used when the editor is a
CEditor.
This breaks our use case where we have a CEditor embedded as a tab in a
multi-pane editor (see org.eclipse.papyrus.infra.core.sasheditor
.editor.AbstractMultiPageSashEditor).
This patch modifies the ASTProvider to use #getAdapter instead of only
the instanceof check. I've kept the common case (where the editor is a
CEditor) unchanged and added the new code as extra handling.
I've also introduced a public interface, ITranslationUnitProvider, to
avoid forcing clients to adapt to the internal CEditor class. The only
part of CEditor that ASTProvider cares about is the ITranslationUnit.
The existing implementation has an unchecked cast. The new interface
provides the required type directly.
Change-Id: Ie7e68e8909928374fa11fe2b8a857f09d042fb5c
Signed-off-by: Andrew Eidsness <andrewe@jfront.com>
Reviewed-on: https://git.eclipse.org/r/20026
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
IP-Clean: Doug Schaefer <dschaefer@qnx.com>
view.connect( view.engine(), SIGNAL( quit() ), ...
The return type of view.engine() should be checked for the quit()
signal. The implementation was actually checking the type of view.
I've fixed a copy/paste error in a utility function.
Change-Id: Id483015214f04951fb30e3271d43499f31614446
Signed-off-by: Andrew Eidsness <eclipse@jfront.com>
Reviewed-on: https://git.eclipse.org/r/21189
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
IP-Clean: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
In Content Assist cases like:
q->
(when the cursor is to the right of the arrow operator) the name that is
returned by the content assist context is the empty string. This was
used to check if the QObject::connect function applied. Since the empt
string matches all bindings the Qt assistant incorrectly continued.
I've added a check to stop processing when the current name is the empty
string.
Change-Id: I4e5bf52f4ca1ddc33d88a48917213adbbeb81836
Signed-off-by: Andrew Eidsness <eclipse@jfront.com>
Reviewed-on: https://git.eclipse.org/r/21188
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
IP-Clean: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
This commit rolls back the commit
faa1188866 which changed the layout to use
a FillLayout. As this is fixing an issue with a horizontal scrollbar
painted on Linux where it is not needed, it leads to more serious issues
on Windows. Rolling back the commit is addressing the immediate need of
getting the layout fixed where the scrollbar issue is somewhat
cosmetical.
This commit rolls back the commit
faa1188866 which changed the layout to use
a FillLayout. As this is fixing an issue with a horizontal scrollbar
painted on Linux where it is not needed, it leads to more serious issues
on Windows. Rolling back the commit is addressing the immediate need of
getting the layout fixed where the scrollbar issue is somewhat
cosmetical.
When a PDOMName is deleted and that name is the head of an external
references list, the list's head must be changed.
The Qt plugin is the only user of the external reference list. One case
is the link from a SIGNAL or SLOT expansion to the C++ method binding
for the corresponding function. In this case, the problem will appear
when all of the following are true:
1) The file containing the SIGNAL/SLOT expansion is changed and the
index updated
2) The corresponding function is declared in a different file
3) The the function is the first entry in the external references list
When #2 is false, the binding (and the entire list) is removed as part
of updating the file containing the name.
When #3 is false, the list is updated with existing code using the
PDOMName's {next|prev}InBinding pointers.
Change-Id: I1e27c7c2356ca1fb68f57d69c40728289288ed66
Signed-off-by: Andrew Eidsness <eclipse@jfront.com>
Reviewed-on: https://git.eclipse.org/r/20972
Tested-by: Hudson CI
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
IP-Clean: Doug Schaefer <dschaefer@qnx.com>
