There are many opportunities for replacing `StringBuffer` with
`StringBuilder` provided that the type isn't visible from the
public API and is used only in internal methods. Replace these
where appropriate.
Change-Id: Ic2f50c5b6f3c3a4eae301bb3b40fb6faed235f79
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
In many cases a String's empty status is tested with `.equals("")`.
However, Java 1.6 added `.isEmpty()` which can be more efficient since
it compares the internal length parameter only for testing. Replace
code using the `.isEmpty()` variant instead.
Some tests for `"".equals(expr)` can be replaced with `expr.isEmpty()`
where it is already known that the `expr` is not null; however,
these have to be reviewed on a case-by-case basis.
Change-Id: I3c6af4d8b7638e757435914ac76cb3a67899a5fd
Signed-off-by: Alex Blewitt <alex.blewitt@gmail.com>
This commits adds support for the stand-alone debugger on Mac OS X
for both the RCP (product) and the script. The script had to be
modified slightly because of the different installation layout on Mac
and also the use of non-standard arguments to the 'find' command.
Change-Id: I24e4fec98803689dbaadb1dcfa651e431d4188a7
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
The depedency was added to the product before but not to the script.
This means the stand-alone debugger worked in the form of the
product but not the script bundled as part of other Eclipse products.
Change-Id: I3e9da14a7522524a6bec73d3d9e9d22263f17093
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
This is the first change to remove CDI from CDT. The CDI model
implementation is removed along with everything that directly
depends upon the implementation.
This commit does not include refactoring or moving classes. The few
insertions are the minimum necessary.
Change-Id: I80274e1a0d77bc7bb00a2afe4babc00c4f7613ae
Signed-off-by: Jonah Graham <jonah@kichwacoders.com>
-Add Refresh command to File menu.
-Enable 'Refresh on Access' by default, like Eclipse for C/C++ package
-Reorder the File menu a bit so that Exit is last
Change-Id: I3636cd20da1a2523ca1574674cf6ebc59a124860
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Add Error view to both the rcp and the script.
Also update the script to include com.google.gson which is required by
cdt.core.
Change-Id: I3975420cff8c912c07949384226bfa655a1a10e3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
This patch creates a product so that the stand-alone can be downloaded
without
the rest of the C/C++ EPP. It also makes it easier to use because the
user only
has to launch the executable, just like a regular Eclipse instead of
finding
the script.
To try the RCP:
mvn clean package -Pbuild-standalone-debugger-rcp
The result (tar.gz) is available under
debug/org.eclipse.cdt.debug.application.product/target/products
Once extracted, it can be started just like the normal script:
./cdtdebug -e myexecutable
Change-Id: Ifb849af8a8f2ec03abcae57cf43d57cde2333759
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Looks like platform 4.5 now depends on
org.eclipse.e4.core.di.annotations and some others
Change-Id: Ic7ecde8e52c825a563956ffeb1b56407f6d98325
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
(cherry picked from commit 0434220f80)
getAdaptable() in 4.5 M6 has changed to use generics, making casting its
result no longer necessary.
Change-Id: Idd943216a925576bb72c784b2c5a2a4b8e8b00d2
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
- allow pid to be specified following -a option for Standalone debugger
- if pid is specified, use it to set the ATTR_ATTACH_PROCESS_ID
setting for the launch configuration
- setting the pid will cause the process dialog not to appear and
the debugger will attempt to debug the given process
- an invalid pid will result in in the dialog being opened
- the pid is not used with the -r option and is ignored
- updated the README file and docs
Change-Id: I5a1d39f97285ad41dcb986dfb4692f9d808bafeb
Change-Id: Ifcbfd598d90305ac24bddf96893d4170201858c9
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/36700
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
Change-Id: I45c1c184c2b79b9bb463b6217fdbf6104e0c5abd
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/30659
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- Fix indentation
- Call install.sh from cdtdebug.sh if installation needed.
This should help the user realize they can run the script
outside if the eclipse installation directory after the first time.
- Use a subshell to run pwd to avoid having to actually change
directory.
- Tag the line that needs to be modified with a marker to make it
future-proof.
- Use find instead of ls which is easier to parse.
- Allow to run install.sh without doing a cd to its location
- Allow to run original cdtdebug.sh without doing a cd to its location
Change-Id: I3f63dcf8a307784b0c38a286e645ea962ce62dc4
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/29834
Tested-by: Hudson CI
- add a check in the Stand-alone Debugger install script to
catch the situation where the eclipse binary is not found
in the expected directory relative to this script
Change-Id: I9f179c80085e5a80a5f4d7fafe1636a7cec38021
Reviewed-on: https://git.eclipse.org/r/29568
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- do some parsing of options in cdtdebug script
- allow all options after -e executable to be passed to main and
not processed by Eclipse (e.g. -clean)
- prohibit -vmargs option from being used
Change-Id: Id40044a3dc9170f57c848447793dfa9aa044d60e
Reviewed-on: https://git.eclipse.org/r/29494
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- add code to search PATH using "which" command if the executable consists
of a single segment and is not absolute
Change-Id: I0e36adc99d206c4f61e58747eb3ebfc30cd1437c
Reviewed-on: https://git.eclipse.org/r/28790
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- distinguish between specifying an executable on command line or from the
New Executable Dialog
- remove all launch configurations for the Executables project before
deleting the project
- tell the configurer to not save and restore
- perform super.postWindowClose() after we have saved workspace
Change-Id: I1f02f3e033e5abf6c3c90a096312de2f134f7d8c
Reviewed-on: https://git.eclipse.org/r/28175
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
(cherry picked from commit 0e6641c128)
Reviewed-on: https://git.eclipse.org/r/28206
- Add support to replace paths with absolute canonical paths before
creating links within project or creating debug launch configs
Change-Id: I253978a973a4e583bc5e63b751e5184e7b085db1
Reviewed-on: https://git.eclipse.org/r/28448
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- workspace is now workspace-cdtdebug
Change-Id: I04e9285a385308c5b3911c64bb175b07f8ed407d
Reviewed-on: https://git.eclipse.org/r/28207
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- Fix cdtdebug.sh to not use pushd/popd
- Fix install.sh script to do proper sed now that pushd is not used
Change-Id: I466af0b0b6e09a53eb11505ce480138b5b538378
Reviewed-on: https://git.eclipse.org/r/28070
Reviewed-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- Fix config.ini to contain missing bundles such as
org.eclipse.cdt.native and org.eclipse.core.net
- Remove missing compat bundle
Change-Id: I440be50144e5e081f295f8535e616b4fc0f94692
Reviewed-on: https://git.eclipse.org/r/27613
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
(cherry picked from commit 473fe58a28)
Reviewed-on: https://git.eclipse.org/r/27992
Change-Id: I27bb60faf0b50733c3fc0cc830a081dcb10816e7
Signed-off-by: Marc Khouzam <marc.khouzam@ericsson.com>
Reviewed-on: https://git.eclipse.org/r/27116
Tested-by: Hudson CI
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
- add org.eclipse.cdt.debug.application plugin which supports running
CDT debugger as Eclipse application
- add org.eclipse.cdt.debug.application.docs plugin which is the
modified
CDT docs
- add org.eclipse.cdt.debug.standalone-feature which bundles the
two aforementioned plugins
- add org.eclipse.cdt.debug.standlone.source-feature
Change-Id: I1a1ae855ab3912e678b7d9e3465e2fbbfe949e13
Reviewed-on: https://git.eclipse.org/r/25845
Reviewed-by: Jeff Johnston <jjohnstn@redhat.com>
Tested-by: Jeff Johnston <jjohnstn@redhat.com>
