1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-22 06:02:11 +02:00
Commit graph

33 commits

Author SHA1 Message Date
Jonah Graham
f083a4a203 Split check code cleanliness into two build steps
A while ago we made the "Make sure all versions have been bumped
appropriately compared to the baseline" output to another file
to make it clearer. This refactor splits it up into different
build steps instead so that I don't have to open an additional
log file.
2023-08-16 15:04:39 -04:00
Moritz 'Morty' Strübe
848ce9c10b cleanliness.sh: Exit if stash is needed 2022-11-11 11:34:04 -05:00
Moritz 'Morty' Strübe
76fe5e6e2d Make running code cleanliness less painfull
* Only check for modifications in tracked files
* Tell the user to stash stuff, before running
2022-11-11 10:41:08 -05:00
Jonah Graham
06c8b01d83 GitHub Action for Code Cleanliness Check
This commit runs GitHub actions for code cleanliness.
Because this includes compare and replace build,
this verifies that the commit is buildable and
clean.

The natives are not rebuilt here (yet) because
the GitHub actions runner does not have the
cross compiler tools installed.

Part of migration to GitHub - Issue #32
2022-10-09 12:14:53 -04:00
Jonah Graham
bc8c94fbe6 [releng] Update to Tycho 2.7.1
2.7.1 is required to consume PGP keys successfully.

Change-Id: I2ca86728b9118943fcd364656861dc8e7170145a
2022-04-11 17:07:30 -04:00
Jonah Graham
a5423f5cd6 [releng] Sort output in compare and replace report
Also-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
Change-Id: I0345c363a1f9c23c608e3b3765ca91dffa82077a
2020-11-11 20:57:29 -05:00
Torbjörn Svensson
0429be17e1 [releng] Report more than one failed bundle per invocation
List as many as possible of the failed bundles when doing the baseline
compare.

Change-Id: I0d2817c418cf865f7fc6ea1c7e25d5b3b7b41bd5
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-10-24 18:39:47 +02:00
Jonah Graham
88b2322c38 Bug 551817: Fix legal docs - and automate their checks
Change-Id: I6f97927f0df64a28e71a2d7ab4c55b609794f751
2020-08-30 23:15:59 -04:00
Jonah Graham
0631233154 [releng] Add missing copyright headers to releng scripts
Change-Id: I68cdf1f8adc1e59f47bb610c8aaeb583ca6cf39b
2020-08-30 20:25:40 -04:00
Jonah Graham
6233337560 [releng] Split up check_code_cleanliness script
As more checks have been added it has gotten a little unweildy.

The new script "do_all_code_cleanups.sh" now does most of the code
formatting checks.

Change-Id: I65fd888c88e1d7e470ed5621cee18ff3bf6680b4
2020-08-30 20:09:50 -04:00
Jonah Graham
0cb1f7482a Bug 566511: [releng] Add missing UTF-8 encoding for all CDT projects
Includes updates to code cleanliness script

Change-Id: Ic495124285e3e002993f34dc12be5ad7337fe13b
2020-08-30 20:02:41 -04:00
Jonah Graham
0c5093d6ff Bug 566334: Turn on API Tooling & Analysis for all bundles
Change-Id: I3cb5645eba52b0cd0e9a71069264d9c589159107
2020-08-24 17:50:56 -04:00
Jonah Graham
a588063b23 Bug 521515: Automatically check .so, .dll, .exe files for valid deps
Because we build cross platform, we want to make sure no unexpected
dependencies are introduced on newer or non-universal libraries
in the native code.

Change-Id: Ib8ffeb5f374bcd04514c31dca9d8297fed70343a
2020-08-18 21:43:21 -04:00
Torbjörn Svensson
a025f75771 Bug 521515: Generate JNI header files as part of build
Also generate JNI header for serial component. This component does not
really need it since the implementation is in one file only, but this
would at least throw an error if the java part changes and the native
part is not updated accordingly.

Change-Id: Id598410c322580bdda37c905ed08627390c913ba
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-13 10:13:52 +02:00
Jonah Graham
7120731766 Bug 521515: Generate JNI header files as part of build
Change-Id: Ia92da44f964e1934b2c32d2536f3ec27c03d5d59
2020-08-12 21:30:42 -04:00
Jonah Graham
ba24afc3a4 Bug 521515: Save the log file all the time when building natives
Change-Id: I11b149d94f837dcb9537682a55551add289f8924
2020-08-12 21:30:42 -04:00
Torbjörn Svensson
00a52086c9 Bug 521515: Adopt native build support on jenkins
Change-Id: I6aee7a7c94f93375d3a2ddb0171602a27a6873e7
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-06 20:55:42 -04:00
Torbjörn Svensson
69acfe4819 Bug 521515: Align directory name of native source code
The native directory can contain both libraries and utilities. In
Gerrit https://git.eclipse.org/r/c/cdt/org.eclipse.cdt/+/165270,
there is a utility, so the directory name "jni", or even "library" does
not work. In order to support both utilities and libraries, the
suggested name of the directory is "native_src" and thus, this commit
syncs that change in o.e.c.native.serial.

Change-Id: Iafa9ce9ae1dca7ef563ab397e8b3eb0b8642372d
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-08-06 20:54:52 -04:00
Torbjörn Svensson
6e19332c33 Mark exe and dll files as executable
When git is configured to honor executable bit for files
(core.fileMode=true), the .exe and .dll files in the
repository needs to have execute bit set to be able to run
Eclipse in runtime mode on Windows.
For more details:
https://git-scm.com/docs/git-config#Documentation/git-config.txt-corefileMode
"Git for Windows" does not appear to have this problem,
but at least Cygwin does.

Change-Id: I4c164f6d99219d461c301189f101ccbf63debb50
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
2020-07-12 16:53:47 -04:00
Jonah Graham
cd0f01a5be [releng] Save baseline-compare-and-replace.log all the time
We have had sometimeouts running the baseline-compare-and-replace,
so save the log all the time.

Change-Id: I0e0d98c2f27dbce0f46f15757959e70a13fb53c3
2020-05-27 16:50:54 -04:00
Jonah Graham
646273d9a4 [releng] Update code cleanliness to better handle non-JDT/PDE projects
This commit on its own fails cleanliness, but is separated out
to make review easier. The subsequent commit is the result of
cleaning the code with the script

Change-Id: Ibaddc2f338f14fbe60662acc8cb272b584a1a828
2020-04-26 14:44:12 -04:00
Jonah Graham
00cf160745 [releng] Add some more help in error messages when code cleanliness fails
Change-Id: I5cea3eb02e4809e591e3160358b7f6b06feabefa
2020-04-26 10:32:26 -04:00
Jonah Graham
213770265a Bug 559474: Normalize .settings
Change-Id: I4b8ca8341a3f479a74a06621f68534732cff6957
2020-01-31 12:20:41 -05:00
Alexander Fedorov
053f3d7ea0 Bug 559412 - CDT checker: skip org.eclipse.pde.ds.annotations.prefs
Expand the copy mask for .settings/org.eclipse.pde.*, copy only
$COREPROJECT/.settings/org.eclipse.pde.prefs
$COREPROJECT/.settings/org.eclipse.pde.api.tools.prefs

Change-Id: I54d3bb65bb8b2a6d1054bff84fd6185e3fec67ef
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
2020-01-22 11:04:01 -05:00
Jonah Graham
692c4c02a3 Bug 558439: Bring check code cleaniness script back into CDT
Now that this script does not need to be in a common place
for launchbar and tools.templates bring it back into the main
repo.

Change-Id: Ia3033a44bbb809e9163b8cf6b14b49e63f151dd1
2020-01-13 22:06:38 -05:00
Jonah Graham
d1a15ef473 Bug 558827: Add cleanliness check for features
Change-Id: Id25d340506210206dcd8f0ce93f2e01a041d4e1e
2020-01-09 15:11:35 -05:00
Jonah Graham
f710eabea8 Bug 553231: Move core of script to cdt-infra
Change-Id: I05c1454ade47423d3eb8b20c63ad2bc8d2b800fb
2019-11-19 15:43:33 -05:00
Jonah Graham
29369a555c Bug 521515: [releng] Build o.e.cdt.native.serial natives using docker
Steps:
1. Edit and commit change
2. docker run --rm -it -v $(git rev-parse --show-toplevel):/work -w /work/$(git rev-parse --show-prefix) quay.io/eclipse-cdt/cdt-infra-eclipse-full:latest  make -C jni rebuild
3. GIT_COMMITTER_DATE=$(git log -1 --pretty=format:%cI -- .) git commit --amend -a --reuse-message=HEAD

Change-Id: I9d9a576fd2eb1c5edd874098d08564ecdfa6ba09
2019-11-04 07:19:27 -05:00
Jonah Graham
35338f28a3 [releng] Cleanup code that has been misformatted and update to SDK 4.13
The check-code-cleanliness CI jobs have not been running recently,
so this commit is to the code up to those minor changes

Change-Id: I9fb4b0213dec558f58c5ca718b3d2685564ef456
2019-10-28 13:07:02 -04:00
Jonah Graham
f869a3f247 Bug 540373: Post code-cleanup for DSF examples
The DSF Examples contains some commented out source that is enabled
via a script so this commit cleans that up for new formatting rules.

Change-Id: I82c5e195cc3746415c659b2c0fc72b8118cdc56c
2018-11-24 11:22:15 +00:00
Jonah Graham
37ed2c406d Bug 540373: Update the compiler warnings/ignores
The previous alignment of all the warnings/ignores
led to too many warnings that weren't there before. This
commit relaxes them a bit.

The core/org.eclipse.cdt.core/.settings/org.eclipse.jdt.core.prefs
is still the "master" copy, with
releng/scripts/check_code_cleanliness.sh containing the
exceptions that apply to test plug-ins.

Change-Id: Ibd4e31ade0b42b31e7cbe5a94f06c6fc15183a56
2018-11-24 10:55:06 +00:00
Jonah Graham
1ca3067521 Bug 540373: Use git ls-files instead of find
git ls-files has two benefits:
- Only finds tracked files
   This is necessary because we were having a few cleanups
   being attempted on ignored files.
- Is much faster

Change-Id: I5a53497f8ef9c839676b7ef7e3be35171140f4b9
2018-11-24 10:55:06 +00:00
Jonah Graham
1903ae1acd Bug 540373: Add a code cleanliness check script
Change-Id: Ib665e551469e512193ecdf36bd31667ea38408ea
2018-11-23 14:59:29 +00:00