The current situation is that:
* launch configuration dialog tabs scroll correctly in the standard
Eclipse platform dialog, but not at all in the Launchbar-specific dialog
* some CDT-supplied launch configuration dialog tabs try to manage their
own scrolling behaviour to fix scrolling in the Launchbar-specific
dialog but this breaks scrolling for that tab in the standard Eclipse
platform dialog.
This change fixes the launchbar-specific editor dialog to use a scrolled
composite instead of a regular composite on which to layout the content
of each tab -- This gives the launchbar's configuration editing dialog
exactly the same scrolling behaviour as the standard Eclipse platform
configuration editing dialog.
And also fixes any CDT-supplied tabs that try to manage their own
scrolling behaviour so now all tabs have the same behaviour when viewed
in the Launchbar-specific dialog as they do when viewed in the standard
Eclipse platform dialog.
Change-Id: I0d7364a24ca48bb125cae9518728b4c93b93545d
Signed-off-by: Mat Booth <mat.booth@gmail.com>
When the UI layer is running the correct terminate adapter is returned,
when the UI layer is not running, the Launch.terminate code is a valid
fallback, and the org.eclipse.debug.internal.core.commands.TerminateCommand
is not an appropriate adapter to use.
Change-Id: I3c4c273b78b4e5bc9fe521b4a24ef5443852d3c0
The test used to fail on the -100.0 / 3.0 case if that was the first
condition tested. This change forces that to not be the first
condition tested which reduces the incidence of failures.
This does not resolve the unknown underlying issue which appears
to be on the GDB side that CDT is exposing. Upgrading GDB version
may also resolve the test failures, but for now I am going with
this fix so that we stop having UNSTABLE Jenkins CI builds.
Change-Id: Ibfa93a8350cfc08adf721723bc07566521bed812
'/tcp' suffix is not supported anymore with 'gdb',
so an IP address should be in form of HOST:PORT
(and not of HOST:PORT/PROTOCOL)
See: https://github.com/flathub/org.eclipse.Java/issues/36
Change-Id: I9eedc450da0d39305fc5d4cde851eb991c3c31f0
Signed-off-by: Victor Rubezhny <vrubezhny@redhat.com>
- add check for flatpak environment variable in
GDBBackend_7_12.isFullGdbConsoleSupported() method
and return false if variable is set
Change-Id: I667a63395592e2671ab3bf6f255e7428371086b3
While most of these commands don't actually have spaces in them, or
their arguments, avoid the deprecated methods.
Change-Id: If7b4324695699d5a6d9a2f8a979657977486d8a4
Improvements in SyncUtil's addBreakpoint and runToLocation
methods to make them support hardware breakpoint
Change-Id: If358bf11cab426f48edb8854e9ece911c2839815
Signed-off-by: Abdullah Khalid <abdullah.dev0@gmail.com>
Eclipse CDT supports GDB version 6.6 and newer. Some features
in Eclipse CDT require newer versions of GDB. The Eclipse CDT
project focuses its testing time on GDB version 8.0 and newer.
Change-Id: Ifb7cd77c9fae4b9d1b82e0aa8a2cea206a4298b7
In some situations, it makes sense to have a build structure parallel
with the source tree, and it this case, the build results may not be
part of the resources visible in the Eclipse workspace.
Current implementation allows absolute paths to the binary to debug.
While it works, it's a cumbersome way to handle the above situation.
By resolving the relative path outside of Eclipse scope allows to point
to files that are not part of the Eclipse workspace, allthough the path
is relative to a project in the workspace.
Contributed by STMicroelectronics
Change-Id: I284a5dad61e692dae4029e5f142d23d8cda98ed0
Signed-off-by: Torbjörn Svensson <torbjorn.svensson@st.com>
this fixes cases where a single test failing does not clean up
properly causing subsequent tests to then fail.
Change-Id: I4bd9c08e5ce1a4cd2ccd5e710a446e6e96c4d353
Instead make the tests non-intermittent. If tests are flaky, they
should be moved to JUnit5 and marked with the flaky tag.
Change-Id: I9c165ec8f16c65383d93d64d17047c0a2597b81c
Many of the disabled tests were failing because they were dependent
on specific combinations of GDB + GCC and where exactly code
stops and steps effect when entering functions. The old code
mostly ran to a function and then stepped a known number of times.
But what changes between GDB versions is how many steps are needed.
Therefore for all failing tests update to run to a specific line
number by using tags in the .cc file and running to them to make
sure the test is precisely on that line.
This partially reverts commit 8220215a2e
and 92272c6465
Reason for revert: These tests were "temporarily" disabled a while ago
as part of the JIRO migration in Bug 545624.
Change-Id: I703429c8a81c856360f1cb4e899026200527f7c6
MIExpressionsTest.testNestedBaseChildrenBug accesses this field like
this -data-evaluate-expression "*((((*(class Base*) this)).pNested))"
which, as pNested isn't init, can cause a Cannot access memory at
address 0x0 error.
Change-Id: Ie6ba01be3499df6e72e714bc5c02dcd5355468bf
The test for ThreadStackFrameSyncTest accessed some state in the
IGDBFocusSynchronizer from outside the Executor thread.
The test also was not waiting on events to synchronize with
the executor thread, instead using Thread.sleep().
There was also some unneeded code due to not using the ServiceEventWaitor
in all places it could be used.
This was leading to race conditions and flaky test failures.
Change-Id: Ib6a3273e20f4383714edc491de9dd9330b250487
In some targets (such as the build machines @ Eclipse) gdb is
returning thread names for remote debugging. No longer fail tests
in this case as long as the provided name is empty or correct.
Change-Id: I5f59f279a9d477e2c1ccb32098bbe1dad08cf334
Added missed license headers
Updated baseline for the parent pom to CDT 10.2
Updated version for pom.xml to 10.3
Updated version for features and bundles to CDT 10.3
Updated copyright for about.properties to be 2021
Incremented version + 100 where needed
Change-Id: I79666fcc0402fee6607499d7dce1eaf87a5f446d
Signed-off-by: Alexander Fedorov <alexander.fedorov@arsysop.ru>
- Added null check to prevent NPE.
- Fixed the collector used in doTargetBreakpointsSynchronized method.
Change-Id: I1ea48b9231882923fe364321e42d0202a0924bf3
Signed-off-by: Umair Sair <umair_sair@hotmail.com>
Added a boolean which is set to true when groups are
successfully read on startup so that shutdown doesn't
attempt to save an empty register group list
Change-Id: Idfff94afbd6b9eb73d01dadbeb8a8fd24c83a19a
Signed-off-by: Santiago Gil <santipoborina@hotmail.com>
Add a limit of 100,000 records to prevent OOM errors. Normally
only a few OOB records are needed, but in some cases like with
tdump, hundreds may be needed.
Change-Id: I967e0facc1dc326d94fa67b1d647417ee3cd8891
Traditionally CDT used sync debug support all the time. However there
are cases where using target async is better because of GDB missing
interrupt.
This patch expands the cases that use target async to be all
remote targets when using Windows host. That is in addition to
cases when the full GDB Console is supported (new-ui).
Signed-off-by: Muhammad Bilal <hafizbilal100@gmail.com>
Change-Id: I1309d20319a24e4f23543d4ed22735044fd5b811
This change adds synchronization to iterating over the map
AbstractMIControl.fRxCommands during
AbstractMIControl.cancelRxCommands(). This prevents potential
ConcurrentModificationExceptions when elements are added or removed to
the map in parallel during e.g. AbstractMIControl.TxThread.run() loop.
The change also removes superfluous synchronization for method
AbstractMIControl.cancelRxCommands().
Change-Id: Id7c01b3057e522cce324a002dce54f0fabe02623
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
There is no way to predict what the user might do during for example the
launch sequence, so as a last resort, tell the UI to drop all caches and
refresh the data as the last step of the launch sequence.
Change-Id: I97731c8286657a0fc1111ba41deb47863181a453
Also-by: Jonah Graham <jonah@kichwacoders.com>
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
Change-Id: I7f682ad313ce275f45e0b4adb4c1280d952cf3ac
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Also-by: Jonah Graham <jonah@kichwacoders.com>
Add enforecment script that verifies that only specified file types are
allowed to be mared as executable.
Change-Id: I4b40e3a46b03bfc78a9dcd52e8bf29cb079b7f3b
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
* Bundle-Vendor should be Eclipse CDT
* Added missing Bundle-Name attribute for some bundles
* Synced MANIFEST.MF and properties file for keys
Change-Id: I14e3b1cc35e7ae88a1585d8ab19cede682bd4fce
Signed-off-by: Torbjörn Svensson <azoff@svenskalinuxforeningen.se>
