The area covered by CDT prefs pages has been always quite huge. Often,
the scroll bar of the virtual composite has to be displayed although the
components could display all the required information readily in a
smaller box. This is an attempt to reduce some of the fixed space
requirements. The solution is not ideal, but the layout framework of SWT
(no notation of minimum size) and the way how sizes are computed in
prefs page by jface doesn't allow a more sophisticated solution at this
time.
Change-Id: I5f9aa36d0d37b93852a39d636719be801a2c1360
Reviewed-on: https://git.eclipse.org/r/11299
Reviewed-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
IP-Clean: Sergey Prigogin <eclipse.sprigogin@gmail.com>
Tested-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
The extension point is called org.eclipse.cdt.ui.cPropertyTab and not
org.eclipse.cdt.managedbuilder.ui.cPropertyTab.
Change-Id: If1e767011133f385fc100f6de58a6bc2fcc14b95
Reviewed-on: https://git.eclipse.org/r/11298
Reviewed-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
IP-Clean: Sergey Prigogin <eclipse.sprigogin@gmail.com>
Tested-by: Sergey Prigogin <eclipse.sprigogin@gmail.com>
The javadoc for BTree.insert says "don't insert if the key was already
there, in which case we return the record that matched".
However, the implementation was returning the new record even when it
was not actually inserted.
This is a fix for the problem and a test case to demonstrate the issue.
Further Changes:
----------------
I have modified the code style as described in the comments in
https://git.eclipse.org/r/#/c/10804.
However, I'm still not sure what style is expected. I've looked through
the CDT wiki a few times, especially the 'new developer' parts, but
haven't found anything relevant. When I asked the question a few weeks
ago, the only reply was to use the "eclipse built-in style", which I
can't find in my preferences. The default seems to be "K&R Style" (that
is what it is set to now, and I don't think that I would have changed
it), so that is what I've used here.
If I've missed the section in the wiki then a pointer would be greatly
appreciated. Otherwise this topic would be a great topic for someone
that knows the answers to add to the wiki.
Change-Id: If079f235871fcdfbd35f1cba3f64cc3e33edaaec
Reviewed-on: https://git.eclipse.org/r/10804
Reviewed-by: Doug Schaefer <dschaefer@qnx.com>
IP-Clean: Doug Schaefer <dschaefer@qnx.com>
Tested-by: Doug Schaefer <dschaefer@qnx.com>
