* assertNotNull instead of assertTrue(var != null)
* better types for swtbot api to prevent useless casts after that
* LanguageSettingsManager.getLanguages instead of deprecated api
* assertFalse instead of assertTrue(!var)
Change-Id: Icdde01f10617b6ec51938bc1998a690cfe7ff1d4
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Try-with-resources for ErrorParserManager.
Change-Id: I5c36d3d68545cb50fcd416caefdc878212b57a88
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
AutotoolsConfigurationManager.createDefaultConfiguration doesn't need
the project as parameter, that's why it's default one :).
Change-Id: I55f39edf5867f874e38524042572329bc7e34f66
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Properly generify now that o.e.text is generified. This alows removing a
number of suppressed warnings. In a few places it is better to use
wildcard than suppressing warnings.
Also remove DefaultNoDependencyCalculator as it was suppressing warnings
but better to remove directly as it's not use anywhere.
Change-Id: I70c4ac073ce5b6c2a45443372037fa61b7c36c76
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Remove the sorting action from the MakefileContentOutlinePage because
the action was changed in a way to be addable in init method instead of
deprecated setActionBars.
Hooked it properly in AutomakefileContentOutlinePage.
Bonus point - hooked into AutoconfContentOutlinePage as it was just too
easy to get it there too.
Change-Id: I873864f3978ae7cb1d8aa4143edf604244c0a4bc
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Duplicating this interfaces just creates confusion due to interfaces in
autotools were copied from make bundles but staled in the years.
Implementation is kept as it is but at least the door is open for some
interoperability.
Change-Id: I1eb4a7c7dc7511aa6cb15ec0716d0bae8a64389c
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Main reason is to ignore warning about not exported packages which
doesn't make sense for tests bundles at all.
Change-Id: I99ceeb8e7b5c363e89c697655e7782c7c929405f
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
This removes all kind of warnings regarding BREE and etc.
Change-Id: I62851092e22b135dc2e921a61281f3f2fc0346e7
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Old IActions were just wrapped in handlers which created insane amount
of interactions. This is one idea better by moving the implementations
in the handlers themselves.
Change-Id: Ieb7fc465c8a23af09cb6a3d809f157289c65d2ae
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Removing unused code, making methods private to make it obvious when no
longer used (uncovered few cases), delete commented code and remove
methods that were simply one line invoking some method as they don't
create anything more but pollution.
Change-Id: I9aa0feedaedeb6509fe27772b1015ec953efa9e8
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
This allows direct access to everything in the bundles and doesn't
require exporting the packages.
Update test to directly call methods.
Change-Id: I58ecdb68ba5058caf6c7baaa3ff22eb539d296cd
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reduce coupling by changing UI bundle to use UI activator and drop UI
getters (e.g. workbench, window, shell) from the core bundle.
Also remove other unused methods.
Change-Id: Ida510d5a0e991c08332a998aefaba5843743172a
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Various small readability improvements in autotools.ui bundle:
* Remove useless comments
* Remove methods merely calling super().
* Use SelectionAdapter when only one method of SelectionListener
implemented
* Multi-catch exceptions
* Specialize return types to reduce casting after that
* Remove commented code
* Remove unused methods
* Use String.isEmpty
Change-Id: Iacda4094ee8b3bf80e1509cc3b39f55b6fcb96c9
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Moved new build system to it's own plug-ins. Cleaned up the root
build configuration and toolchain classes and use them for Qt local
run builds. Also hooks Qt local run launch delegate to launch target
manager and associated delegate interface.
Change-Id: I0c0f711ee53005edd399f6d24ba96658d606e1e5
Creating new Shell as parent of every dialog is waste of resources,
complicates window management and have negative effects in terms of
positioning and stacking of dialogs.
While at it remove dead/unused code from these classes.
Change-Id: I62f9a6430f230e18e5b2f949afe97b46fb9e4ac1
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Not all instances handled but the patch is big enough already. Drop the
useless casts thanks to the generification too.
Change-Id: I608c93a317135a8738ad770de71d9c3cda24791a
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
People that would have migrated did it in the last 4 years it is no
longer even known whether this is of any use anymore so better to drop
it now that there is major release on the horizon.
Change-Id: Ic68606582b426be10125fe6a6de345358fc57755
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Putting ELF before GNU_ELF by default means that the former will never
be used (unless manually configured by user) as the first match will
serve. This patch puts GNU_ELF first giving objdump and all other
benefits.
Inspired by 4303bc5cbb .
Change-Id: Ib37c174c216758f36cd0574c7980a38461794837
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
These extend deprecated classes and are not hooked anywhere so better to
remove directly.
Change-Id: I3be280cb7c24a92c633b2b055424609f99889412
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
-Projects with default settings for binary parser will see their binary parser
changed to Gnu Elf automatically.
-New projects will have Gnu Elf binary parser enabled.
-Projects overriding the settings will not change
Change-Id: Ie5db969e68da20d16f565923ecb0ec1edf8b79f3
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
* Remove useless instanceof check.
* Use collections interfaces to loose coupling.
* Remove useless overriding methods that simply call super.
* Unnecessary local before return.
* Stop useless coupling between wizards and pages.
Change-Id: I83c6240259a7805caeadda5503ea3ae2fa6adafb
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
* Do not check for null variables that are known to be non-null already.
* Stop using SubProgressMonitor in favor of SubMonitor.
* Non-javadoc removed.
* Commented code removed.
* Multi-catch.
Change-Id: Ib0aa433fbdfa8581c89161225f83a1f1640dd2dc
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Calling AutotoolsNewMakeGenerator.reconfigure in the wizard ensures that
autogen.sh/configure etc. will be called at import time to make build
work after that without further intervention.
Change-Id: I3f89f84e2f698ebe1c26cb4427de421b29225030
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
* Use try-with-resources.
* More efficient cycles.
* Use collections interfaces instead of concrete classes.
* Turn non-javadoc with actual comments into javadoc.
* Adapt to proper Java naming conventions.
* Modifiers order.
* Unused modifiers.
Change-Id: I5e4ca3e5f2900b72b53338a455dbaaa65273d812
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Reducing sonar warnings is good strategy to keep new warnings easily
noticable.
Interface methods/fields have strict modifiers so no need to specify it.
Change-Id: I8c453b5dbdc3c7fcc37e4e0a4fdf1c600e23fb1a
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
managedbuilder.core was already calling getDebugOption with this key
but it was not exposed in the launch configutation.
Change-Id: Ib9e983ea9240bf6d911b2e2b94fc5929d91bcea1
Signed-off-by: Marc-Andre Laperle <marc-andre.laperle@ericsson.com>
Recommended way is to use e.g. InstanceScope.INSTANCE instead of new
InstanceScope() which is deprecated now.
Change-Id: I9fa8e53e180a480805bd0a57903e65b5c2de5f75
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
Migrate org.eclipse.cdt.autotools.core from deprecated
SubProgressMonitor to SubMonitor.
Change-Id: Icad7c666fc88852554c5d7dbc70b4ecf26b9bc88
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
* Bump BREE to Java 1.8.
* Enable more warnings and save actions.
* Use lambdas.
* Use try-with-resources.
Change-Id: I688dd1865353380a9791ff28779b4c98f21403f6
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
* Bump BREE to Java 1.8.
* Start using lambdas.
* Removed unused helper methods/activator/etc.
* More JUnit 4 migration.
* Enable more warnings by default and fix them.
Change-Id: If2df6114fb18b66822849ce2e1b956dd0ce6b514
Signed-off-by: Alexander Kurtakov <akurtako@redhat.com>
