mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-06-08 02:06:01 +02:00
Code Issues Wiki Activity

Bug 548700 - Handle prefix negative sign in FloatingPointValue.parseDouble()

Browse source 
While a literal expression itself will never be negative (the negative
sign is parsed as a unary operator), we also use FloatingPointValue to
represent results during value computations which can be negative.

Change-Id: I16227b2d19256066b094ae60476e124b4bcea14d
This commit is contained in:
Nathan Ridge 2019-06-27 21:23:10 -04:00
parent 35a1923321
commit fe003c3b8f
2 changed files with 14 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
core/org.eclipse.cdt.core.tests/parser/org/eclipse/cdt/core/parser/tests/ast2/cxx14/constexpr/FloatingPointValueTests.java
View file

@ -39,6 +39,11 @@ public class FloatingPointValueTests extends TestBase {
assertEvaluationEquals(2.5); assertEvaluationEquals(2.5);
} }
// constexpr auto x = -2.5;
public void testNegativeDoubleLiteral() throws Exception {
assertEvaluationEquals(-2.5);
}
// constexpr auto x = .5f; // constexpr auto x = .5f;
public void testFloatLiteral() throws Exception { public void testFloatLiteral() throws Exception {
assertEvaluationEquals(0.5); assertEvaluationEquals(0.5);

9
core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/FloatingPointValue.java
View file

@ -44,6 +44,12 @@ public final class FloatingPointValue implements IValue {
int i = 0; int i = 0;
int len = value.length; int len = value.length;
boolean valueIsPositive = true;
if (i < len && (value[i] == '+' || value[i] == '-')) {
valueIsPositive = (value[i] == '+');
++i;
}
while (i < len && value[i] >= '0' && value[i] <= '9') { while (i < len && value[i] >= '0' && value[i] <= '9') {
int digit = value[i] - '0'; int digit = value[i] - '0';
result = result * 10 + digit; result = result * 10 + digit;
@ -87,6 +93,9 @@ public final class FloatingPointValue implements IValue {
if (!exponentIsPositive) { if (!exponentIsPositive) {
exponent *= -1; exponent *= -1;
} }
if (!valueIsPositive) {
result *= -1;
}
return result * Math.pow(10, exponent); return result * Math.pow(10, exponent);
} }
return null; return null;