From fda133c7433cb3a3e1d0183ba743c7ad86f6f3b8 Mon Sep 17 00:00:00 2001 From: Andrew Gvozdev Date: Tue, 15 Sep 2009 14:11:06 +0000 Subject: [PATCH] bug 289448: Tool Settings File field editor incorrectly draws focus. Patch from Wieant --- .../ui/properties/BuildOptionSettingsUI.java | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/BuildOptionSettingsUI.java b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/BuildOptionSettingsUI.java index e8e742ca570..3d302463f27 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/BuildOptionSettingsUI.java +++ b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/properties/BuildOptionSettingsUI.java @@ -163,7 +163,17 @@ public class BuildOptionSettingsUI extends AbstractToolSettingUI { } break; case IOption.BROWSE_FILE: { - stringField = new FileFieldEditor(optId, TextProcessor.process(opt.getName()), fieldEditorParent); + stringField = new FileFieldEditor(optId, TextProcessor.process(opt.getName()), fieldEditorParent) { + /** + * Do not perform validity check on the file name due to losing focus, + * see http://bugs.eclipse.org/289448 + */ + @Override + protected boolean checkState() { + clearErrorMessage(); + return true; + } + }; } break; case IOption.BROWSE_NONE: {