From fc8ed250b133fc4b4706ee00926f854d5c5e6b1a Mon Sep 17 00:00:00 2001 From: Jonah Graham Date: Fri, 1 May 2020 20:33:05 -0400 Subject: [PATCH] Bug 540737: Remove false optimization GC.getForeground / Background always create a new Color object, so this if expression was always true. Change-Id: Ief4ccaf1adb70967301411b012c0474608f425cb --- .../internal/terminal/textcanvas/TextLineRenderer.java | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/textcanvas/TextLineRenderer.java b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/textcanvas/TextLineRenderer.java index b45506abe13..67fea2e88c0 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/textcanvas/TextLineRenderer.java +++ b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/textcanvas/TextLineRenderer.java @@ -157,14 +157,8 @@ public class TextLineRenderer implements ILinelRenderer { } private void setupGC(GC gc, Style style) { - Color c = fStyleMap.getForegrondColor(style); - if (c != gc.getForeground()) { - gc.setForeground(c); - } - c = fStyleMap.getBackgroundColor(style); - if (c != gc.getBackground()) { - gc.setBackground(c); - } + gc.setForeground(fStyleMap.getForegrondColor(style)); + gc.setBackground(fStyleMap.getBackgroundColor(style)); Font f = fStyleMap.getFont(style); if (f != gc.getFont()) { gc.setFont(f);