From fb30c9539c0e9b9e9a57d2878f8eed6bcb490d96 Mon Sep 17 00:00:00 2001
From: David Dykstal <david_dykstal@us.ibm.com>
Date: Thu, 10 Aug 2006 14:22:04 +0000
Subject: [PATCH] bug 142471 - updated ISubSystemConfiguration interface to
 allow for not having a password.

---
 .../subsystems/ISubSystemConfiguration.java   | 33 ++++++++++++++++---
 .../subsystems/SubSystemConfiguration.java    | 26 +++++++++++++--
 2 files changed, 53 insertions(+), 6 deletions(-)

diff --git a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java
index 8f08057c3cf..34a0b762b14 100644
--- a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java
+++ b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/ISubSystemConfiguration.java
@@ -54,13 +54,38 @@ public interface ISubSystemConfiguration extends ISystemFilterPoolManagerProvide
 	// CRITICAL METHODS...
 	// ---------------------------------
     /**
-     * Return true (default) or false to indicate if subsystems of this factory require a userId to
-     *  do connection or not. If not, no GUI will be supplied related to user Ids in the remote systems
-     *  explorer view.
-	 * <p>Returns true in default implementation.
+     * Determines if a user id is relevant for this subsystem.
+	 * Returns true in default implementation.
+	 * Typically used to indicate if a login dialog needs to be presented when the subsystem
+	 * connects.
+     * @return true or false to indicate if subsystems can use a user id.
      */
     public boolean supportsUserId();
     
+    /**
+     * Determines if a user id is required if a user id can be used to connect subsystems of this configuration.
+	 * Returns true in default implementation.
+	 * Typically used to indicate if a login dialog can allow an empty user id.
+     * @return true or false to indicate if subsystems requires a user id.
+     */
+    public boolean requiresUserId();
+    
+    /**
+     * Can be used to determine if a password field is present on a login dialog for subsystems
+     * of this configuration.
+     * The default implementation of this interface should return true.
+     * @return true if the subsystem can use a password, false if a password is irrelevant.
+     */
+    public boolean supportsPassword();
+    
+    /**
+     * If a password is supported this is used to determine if the password can be the empty string.
+     * Must be ignored if supportsPassword() returns false.
+     * The default implementation of this interface should return true.
+     * @return true if the subsystem requires, false if a password may be empty.
+     */
+    public boolean requiresPassword();
+    
    /**
  	* Return true if the subsystem supports more than one filter string
  	* <p>RETURNS true BY DEFAULT
diff --git a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java
index 0700fae1fb3..0437016d86d 100644
--- a/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java
+++ b/rse/plugins/org.eclipse.rse.ui/subsystems/org/eclipse/rse/core/subsystems/SubSystemConfiguration.java
@@ -91,13 +91,13 @@ import org.eclipse.ui.dialogs.PropertyPage;
  * <ul>
  *  <li>SubSystemConfiguration#supportsFilters() to indicate if filters are to be enabled for this factory
  *  <li>SubSystemConfiguration#supportsNestedFilters() to indicate if filters can exist inside filters.
- *  <li>SubSystemConfiguration#supportsDuplicateFilterStrings() to indicate if filter strings can be duplicates within a filter
+ *  <li>SubSystemConfiguration#supportsDuplicateFilterStrings() to indicate if filter strings can be duplicated within a filter
  *  <li>SubSystemConfiguration#isCaseSensitive() to indicate if filter strings are case sensitive or not
  *  <li>SubSystemConfiguration#supportsQuickFilters() to indicate if filters can be specified at contain expansion time.
  *  <li>SubSystemConfiguration#supportsUserActions() to indicate if users can define their own actions for your subsystems' child objects.
  *  <li>SubSystemConfiguration#supportsCompileActions() to indicate if users can compile remote objects using menu actions 
  *  <li>SubSystemConfiguration#supportsFileTypes() to indicate if users can define their own named file types.
- *  <li>SubSystemConfiguration#isSubSystemsDeletable() if they support user-deleting of subsystems. Default is false
+ *  <li>SubSystemConfiguration#isSubSystemsDeletable() if they support user-deleting of subsystems. Default is false.
  *  <li>SubSystemConfiguration#supportsSubSystemConnect() to return false if the connect() action is not supported
  *  <li>SubSystemConfiguration#supportsTargets() to return true if this factory supports the notions of targets. Normally, this is only for file system factories.
  *  <li>SubSystemConfiguration#getSubSystemActions() if they wish to supply actions for the right-click menu when
@@ -200,6 +200,28 @@ public abstract class SubSystemConfiguration  implements ISubSystemConfiguration
 	{
 		return true;
 	}
+	
+	/* (non-Javadoc)
+	 * @see org.eclipse.rse.core.subsystems.ISubSystemConfiguration#requiresUserId()
+	 */
+	public boolean requiresUserId() {
+		return true;
+	}
+	
+	/* (non-Javadoc)
+	 * @see org.eclipse.rse.core.subsystems.ISubSystemConfiguration#supportsPassword()
+	 */
+	public boolean supportsPassword() {
+		return true;
+	}
+	
+	/* (non-Javadoc)
+	 * @see org.eclipse.rse.core.subsystems.ISubSystemConfiguration#requiresPassword()
+	 */
+	public boolean requiresPassword() {
+		return true;
+	}
+	
 	/**
 	 * Return true if instance of this factory's subsystems support connect and disconnect actions.
 	 * <b>By default, returns true</b>.