diff --git a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/FileContentProviderAdapter.java b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/FileContentProviderAdapter.java index 9f0d7093dc3..0db29107783 100644 --- a/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/FileContentProviderAdapter.java +++ b/core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/parser/FileContentProviderAdapter.java @@ -49,8 +49,7 @@ public class FileContentProviderAdapter extends InternalFileContentProvider { private FileContentProviderAdapter(AbstractCodeReaderFactory factory) { fDelegate = factory; - setIncludeResolutionHeuristics( - (IIncludeFileResolutionHeuristics) factory.getAdapter(IIncludeFileResolutionHeuristics.class)); + setIncludeResolutionHeuristics(factory.getAdapter(IIncludeFileResolutionHeuristics.class)); } /** diff --git a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/EditActionAccelerators.java b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/EditActionAccelerators.java index 9f8b06f57ed..827f2a7e575 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/EditActionAccelerators.java +++ b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/EditActionAccelerators.java @@ -50,7 +50,7 @@ class EditActionAccelerators { } private static IBindingService bindingService() { - return (IBindingService) PlatformUI.getWorkbench().getAdapter(IBindingService.class); + return PlatformUI.getWorkbench().getAdapter(IBindingService.class); } boolean isCopyAction(int accelerator) { diff --git a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/VT100TerminalControl.java b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/VT100TerminalControl.java index cde56fdd270..1a931f9abb3 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/VT100TerminalControl.java +++ b/terminal/plugins/org.eclipse.tm.terminal.control/src/org/eclipse/tm/internal/terminal/emulator/VT100TerminalControl.java @@ -842,7 +842,6 @@ public class VT100TerminalControl implements ITerminalControlForText, ITerminalC } @Override - @SuppressWarnings("cast") public void mouseEnter(MouseEvent e) { // Disable all keyboard accelerators (e.g., Control-B) so the Terminal view // can see every keystroke. Without this, Emacs, vi, and Bash are unusable @@ -855,7 +854,6 @@ public class VT100TerminalControl implements ITerminalControlForText, ITerminalC } @Override - @SuppressWarnings("cast") public void mouseExit(MouseEvent e) { // Enable all keybindings. captureKeyEvents(false); @@ -866,7 +864,6 @@ public class VT100TerminalControl implements ITerminalControlForText, ITerminalC contextService.deactivateContext(editContextActivation); } - @SuppressWarnings("cast") protected void captureKeyEvents(boolean capture) { IBindingService bindingService = PlatformUI.getWorkbench().getAdapter(IBindingService.class); IContextService contextService = PlatformUI.getWorkbench().getAdapter(IContextService.class); @@ -1179,7 +1176,6 @@ public class VT100TerminalControl implements ITerminalControlForText, ITerminalC /* * Process given event as Eclipse key binding. */ - @SuppressWarnings("cast") private void processKeyBinding(KeyEvent event, int accelerator) { IBindingService bindingService = PlatformUI.getWorkbench().getAdapter(IBindingService.class); KeyStroke keyStroke = SWTKeySupport.convertAcceleratorToKeyStroke(accelerator); diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/AbstractAction.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/AbstractAction.java index dade3502b13..31967001c57 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/AbstractAction.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/AbstractAction.java @@ -72,7 +72,7 @@ public abstract class AbstractAction extends AbstractTerminalAction { @Override public void run() { // Get the active tab item from the tab folder manager - TabFolderManager manager = (TabFolderManager) getParent().getAdapter(TabFolderManager.class); + TabFolderManager manager = getParent().getAdapter(TabFolderManager.class); if (manager != null) { // If we have the active tab item, we can get the active terminal control CTabItem activeTabItem = manager.getActiveTabItem(); @@ -91,7 +91,6 @@ public abstract class AbstractAction extends AbstractTerminalAction { * * @param data The terminal custom data node or null. */ - @SuppressWarnings("cast") protected void executeCommand(Object data) { // Get the command service from the workbench ICommandService service = PlatformUI.getWorkbench().getAdapter(ICommandService.class); @@ -148,7 +147,7 @@ public abstract class AbstractAction extends AbstractTerminalAction { // The action will be enabled if we can determine the VLM target object enabled = false; // Get the active tab item from the tab folder manager - TabFolderManager manager = (TabFolderManager) getParent().getAdapter(TabFolderManager.class); + TabFolderManager manager = getParent().getAdapter(TabFolderManager.class); if (manager != null) { // If we have the active tab item, we can get the active terminal control CTabItem activeTabItem = manager.getActiveTabItem(); diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/NewTerminalViewAction.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/NewTerminalViewAction.java index 46e4e985fe4..7d61839b9e7 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/NewTerminalViewAction.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/NewTerminalViewAction.java @@ -50,7 +50,6 @@ public class NewTerminalViewAction extends AbstractTerminalAction { setEnabled(true); } - @SuppressWarnings("cast") @Override public void run() { ICommandService service = PlatformUI.getWorkbench().getService(ICommandService.class); diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/ToggleCommandFieldAction.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/ToggleCommandFieldAction.java index dd7e97b1d66..13efde8f3b9 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/ToggleCommandFieldAction.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/actions/ToggleCommandFieldAction.java @@ -67,7 +67,6 @@ public class ToggleCommandFieldAction extends AbstractTerminalAction { * * @return The command input field handler or null. */ - @SuppressWarnings("cast") protected TabCommandFieldHandler getCommandFieldHandler() { TabCommandFieldHandler handler = null; // Get the active tab item from the tab folder manager diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/activator/UIPlugin.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/activator/UIPlugin.java index 059fbf0f615..c39036d4435 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/activator/UIPlugin.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/activator/UIPlugin.java @@ -133,7 +133,7 @@ public class UIPlugin extends AbstractUIPlugin { final List saveables = new ArrayList<>(); // Get the tab folder - CTabFolder tabFolder = (CTabFolder) ((TerminalsView) part).getAdapter(CTabFolder.class); + CTabFolder tabFolder = ((TerminalsView) part).getAdapter(CTabFolder.class); if (tabFolder != null && !tabFolder.isDisposed()) { // Get the list of tab items CTabItem[] items = tabFolder.getItems(); @@ -153,7 +153,7 @@ public class UIPlugin extends AbstractUIPlugin { } // Push the determined saveable items to the memento handler - TerminalsViewMementoHandler mementoHandler = (TerminalsViewMementoHandler) ((TerminalsView) part) + TerminalsViewMementoHandler mementoHandler = ((TerminalsView) part) .getAdapter(TerminalsViewMementoHandler.class); if (mementoHandler != null) mementoHandler.setSaveables(saveables); diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/PropertyTester.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/PropertyTester.java index 8ac25cfc3cf..0b5052bccda 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/PropertyTester.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/PropertyTester.java @@ -25,7 +25,6 @@ import org.eclipse.tm.terminal.view.ui.tabs.TabFolderManager; */ public class PropertyTester extends org.eclipse.core.expressions.PropertyTester { - @SuppressWarnings("cast") @Override public boolean test(Object receiver, String property, Object[] args, Object expectedValue) { diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/handler/DisconnectTerminalCommandHandler.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/handler/DisconnectTerminalCommandHandler.java index 7be55c9c147..d895f88a364 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/handler/DisconnectTerminalCommandHandler.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/internal/handler/DisconnectTerminalCommandHandler.java @@ -27,7 +27,6 @@ import org.eclipse.ui.handlers.HandlerUtil; */ public class DisconnectTerminalCommandHandler extends AbstractHandler { - @SuppressWarnings("cast") @Override public Object execute(ExecutionEvent event) throws ExecutionException { CTabItem item = null; diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/launcher/LauncherDelegateManager.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/launcher/LauncherDelegateManager.java index 810b2211d08..c84517baa69 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/launcher/LauncherDelegateManager.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/launcher/LauncherDelegateManager.java @@ -281,7 +281,6 @@ public class LauncherDelegateManager { * @param selection The selection or null. * @return The list of applicable terminal launcher delegates or an empty array. */ - @SuppressWarnings("cast") public ILauncherDelegate[] getApplicableLauncherDelegates(ISelection selection) { List applicable = new ArrayList<>(); diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/listeners/WorkbenchPartListener.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/listeners/WorkbenchPartListener.java index ea97ae49409..b8dff58b0fe 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/listeners/WorkbenchPartListener.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/listeners/WorkbenchPartListener.java @@ -49,7 +49,6 @@ public class WorkbenchPartListener implements IPartListener2 { public void partHidden(IWorkbenchPartReference partRef) { } - @SuppressWarnings("cast") @Override public void partActivated(IWorkbenchPartReference partRef) { if ("org.eclipse.tm.terminal.view.ui.TerminalsView".equals(partRef.getId())) { //$NON-NLS-1$ @@ -68,7 +67,6 @@ public class WorkbenchPartListener implements IPartListener2 { } } - @SuppressWarnings("cast") @Override public void partDeactivated(IWorkbenchPartReference partRef) { if ("org.eclipse.tm.terminal.view.ui.TerminalsView".equals(partRef.getId())) { //$NON-NLS-1$ diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/manager/ConsoleManager.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/manager/ConsoleManager.java index 4bd21a70b57..072b4673582 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/manager/ConsoleManager.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/manager/ConsoleManager.java @@ -421,7 +421,6 @@ public class ConsoleManager { * @param data The custom terminal data node or null. * @param flags The flags controlling how the console is opened or null to use defaults. */ - @SuppressWarnings("cast") public CTabItem openConsole(String id, String secondaryId, String title, String encoding, ITerminalConnector connector, Object data, Map flags) { Assert.isNotNull(title); @@ -501,7 +500,6 @@ public class ConsoleManager { * * @return The corresponding console tab item or null. */ - @SuppressWarnings("cast") public CTabItem findConsole(String id, String secondaryId, String title, ITerminalConnector connector, Object data) { Assert.isNotNull(title); @@ -529,7 +527,6 @@ public class ConsoleManager { * @param control The terminal control. Must not be null. * @return The corresponding console tab item or null. */ - @SuppressWarnings("cast") public CTabItem findConsole(ITerminalControl control) { Assert.isNotNull(control); @@ -572,7 +569,6 @@ public class ConsoleManager { * * @return The corresponding console tab item or null. */ - @SuppressWarnings("cast") private CTabItem findConsoleForTerminalConnector(String id, String title, ITerminalConnector connector, Object data) { Assert.isNotNull(title); diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderManager.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderManager.java index eb27127d3ba..de382033bf7 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderManager.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderManager.java @@ -190,7 +190,6 @@ public class TabFolderManager extends PlatformObject implements ISelectionProvid * * @return The tab folder or null. */ - @SuppressWarnings("cast") protected final CTabFolder getTabFolder() { return getParentView().getAdapter(CTabFolder.class); } @@ -229,7 +228,7 @@ public class TabFolderManager extends PlatformObject implements ISelectionProvid * * @return The created tab item or null if failed. */ - @SuppressWarnings({ "unused", "cast" }) + @SuppressWarnings({ "unused" }) public CTabItem createTabItem(String title, String encoding, ITerminalConnector connector, Object data, Map flags) { Assert.isNotNull(title); @@ -298,7 +297,7 @@ public class TabFolderManager extends PlatformObject implements ISelectionProvid // Set the context menu TabFolderMenuHandler menuHandler = getParentView().getAdapter(TabFolderMenuHandler.class); if (menuHandler != null) { - Menu menu = (Menu) menuHandler.getAdapter(Menu.class); + Menu menu = menuHandler.getAdapter(Menu.class); if (menu != null) { // One weird occurrence of IllegalArgumentException: Widget has wrong parent. // Inspecting the code, this seem extremely unlikely. The terminal is created @@ -341,7 +340,7 @@ public class TabFolderManager extends PlatformObject implements ISelectionProvid * @param oldItem The old dragged tab item. Must not be null. * @return The new dropped tab item. */ - @SuppressWarnings({ "unchecked", "cast" }) + @SuppressWarnings({ "unchecked" }) public CTabItem cloneTabItemAfterDrop(CTabItem oldItem) { Assert.isNotNull(oldItem); @@ -413,7 +412,7 @@ public class TabFolderManager extends PlatformObject implements ISelectionProvid // Set the context menu TabFolderMenuHandler menuHandler = getParentView().getAdapter(TabFolderMenuHandler.class); if (menuHandler != null) { - Menu menu = (Menu) menuHandler.getAdapter(Menu.class); + Menu menu = menuHandler.getAdapter(Menu.class); if (menu != null) { // One weird occurrence of IllegalArgumentException: Widget has wrong parent. // Inspecting the code, this seem extremely unlikely. The terminal is created diff --git a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderMenuHandler.java b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderMenuHandler.java index 47b280f376f..e6ebfc659a3 100644 --- a/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderMenuHandler.java +++ b/terminal/plugins/org.eclipse.tm.terminal.view.ui/src/org/eclipse/tm/terminal/view/ui/tabs/TabFolderMenuHandler.java @@ -125,7 +125,6 @@ public class TabFolderMenuHandler extends PlatformObject { * * @return The tab folder or null. */ - @SuppressWarnings("cast") protected final CTabFolder getTabFolder() { return getParentView().getAdapter(CTabFolder.class); } @@ -209,7 +208,6 @@ public class TabFolderMenuHandler extends PlatformObject { /** * Create the context menu actions. */ - @SuppressWarnings("cast") protected void doCreateContextMenuActions() { // Create and add the copy action add(new TerminalActionCopy() { @@ -303,7 +301,6 @@ public class TabFolderMenuHandler extends PlatformObject { * * @return The currently active terminal control or null. */ - @SuppressWarnings("cast") protected ITerminalViewControl getActiveTerminalViewControl() { ITerminalViewControl terminal = null;