mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-08-10 09:45:39 +02:00
Code Issues Wiki Activity

Optimized TypeTraits.hasTrivialDestructor method.

Browse source 
Avoid repeated checking of the same class.

Change-Id: If64bd05de0f5f20273bd77b2a8f3a55ccae96391
This commit is contained in:
Sergey Prigogin 2016-10-10 20:32:28 -07:00
parent 2d02ddf8ca
commit f661b90e01
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/dom/parser/cpp/semantics/TypeTraits.java
View file

@ -14,6 +14,9 @@ import static org.eclipse.cdt.internal.core.dom.parser.cpp.semantics.SemanticUti
import static org.eclipse.cdt.internal.core.dom.parser.cpp.semantics.SemanticUtil.CVTYPE;
import static org.eclipse.cdt.internal.core.dom.parser.cpp.semantics.SemanticUtil.TDEF;
import java.util.HashSet;
import java.util.Set;
import org.eclipse.cdt.core.dom.ast.IASTNode;
import org.eclipse.cdt.core.dom.ast.IArrayType;
import org.eclipse.cdt.core.dom.ast.IBasicType;
@ -380,20 +383,28 @@ public class TypeTraits {
* @return {@code true} if the class has a trivial destructor
*/
public static boolean hasTrivialDestructor(ICPPClassType classType, IASTNode point) {
return hasTrivialDestructor(classType, point, new HashSet<>());
}
private static boolean hasTrivialDestructor(ICPPClassType classType, IASTNode point,
Set<ICPPClassType> checkedClasses) {
if (!checkedClasses.add(classType))
return true; // Checked already.
for (ICPPMethod method : ClassTypeHelper.getDeclaredMethods(classType, point)) {
if (method.isDestructor() && !isDefaultedMethod(method))
return false;
}
for (ICPPClassType baseClass : ClassTypeHelper.getAllBases(classType, point)) {
if (!classType.isSameType(baseClass) && !hasTrivialDestructor(baseClass, point))
if (!hasTrivialDestructor(baseClass, point, checkedClasses))
return false;
}
for (ICPPField field : ClassTypeHelper.getDeclaredFields(classType, point)) {
if (!field.isStatic()) {
IType type = field.getType();
type = SemanticUtil.getNestedType(type, TDEF | CVTYPE | ARRAY);
if (type instanceof ICPPClassType && !classType.isSameType(type) &&
!hasTrivialDestructor((ICPPClassType) type, point)) {
if (type instanceof ICPPClassType &&
!hasTrivialDestructor((ICPPClassType) type, point, checkedClasses)) {
return false;
}
}