From efdd31958786af530a07822e6decd590a6ce9cac Mon Sep 17 00:00:00 2001 From: Chris Recoskie Date: Thu, 4 May 2006 15:07:28 +0000 Subject: [PATCH] further fixes for 139797 --- build/org.eclipse.cdt.managedbuilder.ui/plugin.xml | 8 ++++++-- .../managedbuilder/ui/actions/BuildFilesAction.java | 10 ++++++++-- .../managedbuilder/ui/actions/CleanFilesAction.java | 8 +++++++- 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/build/org.eclipse.cdt.managedbuilder.ui/plugin.xml b/build/org.eclipse.cdt.managedbuilder.ui/plugin.xml index 52393992fcd..c19233ad0fb 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/plugin.xml +++ b/build/org.eclipse.cdt.managedbuilder.ui/plugin.xml @@ -150,7 +150,7 @@ + visible="false"> + + diff --git a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/BuildFilesAction.java b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/BuildFilesAction.java index 2a3f078b90b..827f20d8b67 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/BuildFilesAction.java +++ b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/BuildFilesAction.java @@ -266,9 +266,13 @@ public class BuildFilesAction extends ActionDelegate implements IWorkbenchWindow ISelectionService selectionService = workbenchWindow .getSelectionService(); ISelection selection = selectionService.getSelection(); - + if (selection instanceof IStructuredSelection) { IStructuredSelection structuredSelection = (IStructuredSelection) selection; + + if(structuredSelection.size() <= 0) + return false; + for (Iterator elements = structuredSelection.iterator(); elements .hasNext();) { IFile file = convertToIFile(elements.next()); @@ -310,9 +314,11 @@ public class BuildFilesAction extends ActionDelegate implements IWorkbenchWindow return false; } } + return true; } + + return false; - return true; } /* diff --git a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/CleanFilesAction.java b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/CleanFilesAction.java index 46d56367a57..5ae259d1c4f 100644 --- a/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/CleanFilesAction.java +++ b/build/org.eclipse.cdt.managedbuilder.ui/src/org/eclipse/cdt/managedbuilder/ui/actions/CleanFilesAction.java @@ -278,6 +278,10 @@ public class CleanFilesAction extends ActionDelegate implements IWorkbenchWindow if (selection instanceof IStructuredSelection) { IStructuredSelection structuredSelection = (IStructuredSelection) selection; + + if(structuredSelection.size() <= 0) + return false; + for (Iterator elements = structuredSelection.iterator(); elements .hasNext();) { IFile file = convertToIFile(elements.next()); @@ -305,9 +309,11 @@ public class CleanFilesAction extends ActionDelegate implements IWorkbenchWindow } } + + return true; } - return true; + return false; }