mirrors/cdt
1
0
Fork 0
mirror of https://github.com/eclipse-cdt/cdt synced 2025-04-29 19:45:01 +02:00
Code Issues Wiki Activity

bug 212596: JUnit failures in cdt.managedbuilder.test.suite

Browse source 
wrong condition ignoring failures after passed check - fixed
This commit is contained in:
Andrew Gvozdev 2009-10-11 02:27:22 +00:00
parent a183b1abbd
commit ed09e98990
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
build/org.eclipse.cdt.managedbuilder.core.tests/suite/org/eclipse/cdt/managedbuilder/testplugin/ManagedBuildTestHelper.java
View file

@ -403,7 +403,7 @@ public class ManagedBuildTestHelper {
IPath benchmarkFileLocation = benchmarkLocationBase.append("Benchmarks").append(files[i]); IPath benchmarkFileLocation = benchmarkLocationBase.append("Benchmarks").append(files[i]);
if (isMakefile(testFileLocation)) { if (isMakefile(testFileLocation)) {
if (compareMakefiles(testFileLocation, benchmarkFileLocation)) { if (compareMakefiles(testFileLocation, benchmarkFileLocation)) {
return true; continue;
} }
} }
StringBuffer testBuffer = readContentsStripLineEnds(project, testFileLocation); StringBuffer testBuffer = readContentsStripLineEnds(project, testFileLocation);
@ -584,8 +584,8 @@ public class ManagedBuildTestHelper {
} }
static public boolean compareBenchmarks(IFile tFile, IFile bmFile) { static public boolean compareBenchmarks(IFile tFile, IFile bmFile) {
IPath tFileLocation = new Path(tFile.toString()); IPath tFileLocation = tFile.getLocation();
IPath bmFileLocation = new Path(bmFile.toString()); IPath bmFileLocation = bmFile.getLocation();
if (isMakefile(tFileLocation)) { if (isMakefile(tFileLocation)) {
if (compareMakefiles(tFileLocation, bmFileLocation)) { if (compareMakefiles(tFileLocation, bmFileLocation)) {
return true; return true;