From ec15514aa5abc3263470944cbb9d6b7222d89979 Mon Sep 17 00:00:00 2001 From: Uwe Stieber Date: Thu, 9 Jul 2009 11:00:22 +0000 Subject: [PATCH] [fix] Bug 282996 - [terminal][api] Add "hidden" attribute to terminal connector extension point --- .../.settings/.api_filters | 11 +++++++ .../META-INF/MANIFEST.MF | 4 +-- .../org.eclipse.rse.terminals.ui/plugin.xml | 1 + .../ui/views/RSETerminalConnector.java | 7 +++- .../feature.xml | 4 +-- .../feature.xml | 4 +-- .../feature.xml | 6 ++-- .../META-INF/MANIFEST.MF | 4 +-- .../feature.xml | 6 ++-- .../META-INF/MANIFEST.MF | 4 +-- .../feature.xml | 6 ++-- .../META-INF/MANIFEST.MF | 4 +-- .../META-INF/MANIFEST.MF | 4 +-- .../org.eclipse.tm.terminal.test/plugin.xml | 8 +++-- .../TerminalConnectorFactoryTest.java | 3 +- .../TerminalConnectorPluginTest.java | 9 +++-- .../connector/TerminalConnectorTest.java | 27 +++++++-------- .../feature.xml | 9 ++--- .../META-INF/MANIFEST.MF | 4 +-- .../terminal/view/TerminalSettingsDlg.java | 5 +-- .../META-INF/MANIFEST.MF | 2 +- .../schema/terminalConnectors.exsd | 33 +++++++++++++------ .../terminal/connector/TerminalConnector.java | 13 ++++++-- .../provisional/api/ITerminalConnector.java | 7 ++++ .../api/TerminalConnectorExtension.java | 5 ++- 25 files changed, 124 insertions(+), 66 deletions(-) create mode 100644 rse/plugins/org.eclipse.rse.terminals.ui/.settings/.api_filters diff --git a/rse/plugins/org.eclipse.rse.terminals.ui/.settings/.api_filters b/rse/plugins/org.eclipse.rse.terminals.ui/.settings/.api_filters new file mode 100644 index 00000000000..d000db6add1 --- /dev/null +++ b/rse/plugins/org.eclipse.rse.terminals.ui/.settings/.api_filters @@ -0,0 +1,11 @@ + + + + + + + + + + + diff --git a/rse/plugins/org.eclipse.rse.terminals.ui/META-INF/MANIFEST.MF b/rse/plugins/org.eclipse.rse.terminals.ui/META-INF/MANIFEST.MF index b49de54e982..07625ac57f4 100644 --- a/rse/plugins/org.eclipse.rse.terminals.ui/META-INF/MANIFEST.MF +++ b/rse/plugins/org.eclipse.rse.terminals.ui/META-INF/MANIFEST.MF @@ -2,7 +2,7 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %pluginName Bundle-SymbolicName: org.eclipse.rse.terminals.ui;singleton:=true -Bundle-Version: 1.0.0.qualifier +Bundle-Version: 1.1.0.qualifier Bundle-Activator: org.eclipse.rse.internal.terminals.ui.Activator Require-Bundle: org.eclipse.core.runtime, org.eclipse.core.expressions, @@ -12,7 +12,7 @@ Require-Bundle: org.eclipse.core.runtime, org.eclipse.rse.core;bundle-version="[3.0.0,4.0.0)", org.eclipse.rse.ui;bundle-version="[3.1.0,4.0.0)", org.eclipse.rse.subsystems.terminals.core;bundle-version="[1.0.0,2.0.0)", - org.eclipse.tm.terminal;bundle-version="[3.0.0,3.1.0)" + org.eclipse.tm.terminal;bundle-version="[3.1.0,3.2.0)" Bundle-ActivationPolicy: lazy Eclipse-LazyStart: true Bundle-Vendor: %providerName diff --git a/rse/plugins/org.eclipse.rse.terminals.ui/plugin.xml b/rse/plugins/org.eclipse.rse.terminals.ui/plugin.xml index 8896ae6100e..9fd7e008817 100644 --- a/rse/plugins/org.eclipse.rse.terminals.ui/plugin.xml +++ b/rse/plugins/org.eclipse.rse.terminals.ui/plugin.xml @@ -20,6 +20,7 @@ Anna Dushistova (MontaVista) - [235934] Launch Shell/Terminal commands enabled Anna Dushistova (MontaVista) - [251492] Launch Shell Action is enabled in Offline mode Kevin Doyle (IBM) - [249320] Launch Shell action not available in Remote System Details/Monitor views Anna Dushistova (MontaVista) - [257638] [rseterminal] Terminal subsystem doesn't have service properties +Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point --> diff --git a/rse/plugins/org.eclipse.rse.terminals.ui/src/org/eclipse/rse/internal/terminals/ui/views/RSETerminalConnector.java b/rse/plugins/org.eclipse.rse.terminals.ui/src/org/eclipse/rse/internal/terminals/ui/views/RSETerminalConnector.java index 8ec8dff7c14..a5aadfa52a6 100644 --- a/rse/plugins/org.eclipse.rse.terminals.ui/src/org/eclipse/rse/internal/terminals/ui/views/RSETerminalConnector.java +++ b/rse/plugins/org.eclipse.rse.terminals.ui/src/org/eclipse/rse/internal/terminals/ui/views/RSETerminalConnector.java @@ -1,11 +1,12 @@ /******************************************************************************** - * Copyright (c) 2008 MontaVista Software, Inc. + * Copyright (c) 2008, 2009 MontaVista Software, Inc and others * This program and the accompanying materials are made available under the terms * of the Eclipse Public License v1.0 which accompanies this distribution, and is * available at http://www.eclipse.org/legal/epl-v10.html * * Contributors: * Anna Dushistova (MontaVista) - initial API and implementation + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point ********************************************************************************/ package org.eclipse.rse.internal.terminals.ui.views; @@ -30,6 +31,10 @@ public class RSETerminalConnector extends RSETerminalConnectorImpl implements IT public String getName() { return "rse_internal_connector"; } + + public boolean isHidden() { + return true; + } public boolean isInitialized() { return true; diff --git a/terminal/org.eclipse.tm.terminal-feature/feature.xml b/terminal/org.eclipse.tm.terminal-feature/feature.xml index 11ad9fc9b38..bbc535cd4d5 100644 --- a/terminal/org.eclipse.tm.terminal-feature/feature.xml +++ b/terminal/org.eclipse.tm.terminal-feature/feature.xml @@ -1,8 +1,8 @@ - + diff --git a/terminal/org.eclipse.tm.terminal.sdk-feature/feature.xml b/terminal/org.eclipse.tm.terminal.sdk-feature/feature.xml index 11c01b2c12f..1b02d156d3f 100644 --- a/terminal/org.eclipse.tm.terminal.sdk-feature/feature.xml +++ b/terminal/org.eclipse.tm.terminal.sdk-feature/feature.xml @@ -1,8 +1,8 @@ - + diff --git a/terminal/org.eclipse.tm.terminal.serial-feature/feature.xml b/terminal/org.eclipse.tm.terminal.serial-feature/feature.xml index 9f7902fc1f1..831995bf764 100644 --- a/terminal/org.eclipse.tm.terminal.serial-feature/feature.xml +++ b/terminal/org.eclipse.tm.terminal.serial-feature/feature.xml @@ -1,8 +1,8 @@ - + @@ -25,7 +25,7 @@ - + + Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point --> @@ -35,7 +35,7 @@ - + diff --git a/terminal/org.eclipse.tm.terminal.ssh/META-INF/MANIFEST.MF b/terminal/org.eclipse.tm.terminal.ssh/META-INF/MANIFEST.MF index ac99ae31423..4e41d4ac6e8 100644 --- a/terminal/org.eclipse.tm.terminal.ssh/META-INF/MANIFEST.MF +++ b/terminal/org.eclipse.tm.terminal.ssh/META-INF/MANIFEST.MF @@ -2,12 +2,12 @@ Manifest-Version: 1.0 Bundle-ManifestVersion: 2 Bundle-Name: %pluginName Bundle-SymbolicName: org.eclipse.tm.terminal.ssh;singleton:=true -Bundle-Version: 2.0.100.qualifier +Bundle-Version: 2.1.0.qualifier Bundle-Vendor: %providerName Bundle-Localization: plugin Require-Bundle: org.eclipse.ui, org.eclipse.core.runtime, - org.eclipse.tm.terminal;bundle-version="[3.0.0,3.1.0)", + org.eclipse.tm.terminal;bundle-version="[3.1.0,3.2.0)", com.jcraft.jsch;bundle-version="[0.1.31,1.0.0)", org.eclipse.jsch.core;bundle-version="[1.0.0,2.0.0)" Bundle-RequiredExecutionEnvironment: J2SE-1.4 diff --git a/terminal/org.eclipse.tm.terminal.telnet-feature/feature.xml b/terminal/org.eclipse.tm.terminal.telnet-feature/feature.xml index 43d6dc311da..a690aad78b4 100644 --- a/terminal/org.eclipse.tm.terminal.telnet-feature/feature.xml +++ b/terminal/org.eclipse.tm.terminal.telnet-feature/feature.xml @@ -1,7 +1,7 @@ - @@ -24,7 +24,7 @@ - + - + diff --git a/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorFactoryTest.java b/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorFactoryTest.java index 4f6d3bffed6..105b43e5568 100644 --- a/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorFactoryTest.java +++ b/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorFactoryTest.java @@ -9,6 +9,7 @@ * Michael Scharf (Wind River) - initial API and implementation * Martin Oberhuber (Wind River) - [225853][api] Provide more default functionality in TerminalConnectorImpl * Martin Oberhuber (Wind River) - [204796] Terminal should allow setting the encoding to use + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point *******************************************************************************/ package org.eclipse.tm.internal.terminal.connector; @@ -137,7 +138,7 @@ public class TerminalConnectorFactoryTest extends TestCase { public TerminalConnectorImpl makeConnector() throws Exception { return mock; } - },"xID","xName"); + },"xID","xName", false); return c; } diff --git a/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorPluginTest.java b/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorPluginTest.java index cc0c9ee3a78..799bd2bc123 100644 --- a/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorPluginTest.java +++ b/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorPluginTest.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2008 Wind River Systems, Inc. and others. + * Copyright (c) 2008, 2009 Wind River Systems, Inc. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -7,6 +7,7 @@ * * Contributors: * Martin Oberhuber (Wind River) - initial API and implementation + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point *******************************************************************************/ package org.eclipse.tm.internal.terminal.connector; @@ -26,12 +27,14 @@ public class TerminalConnectorPluginTest extends TestCase { public void testIsInitialized() { if (!Platform.isRunning()) return; - TerminalConnector c = new TerminalConnector(new SimpleFactory(new ConnectorMock()), "xID", "xName"); + TerminalConnector c = new TerminalConnector(new SimpleFactory(new ConnectorMock()), "xID", "xName", false); assertFalse(c.isInitialized()); c.getId(); assertFalse(c.isInitialized()); c.getName(); assertFalse(c.isInitialized()); + c.isHidden(); + assertFalse(c.isInitialized()); c.getSettingsSummary(); assertFalse(c.isInitialized()); c.setTerminalSize(10, 10); @@ -48,7 +51,7 @@ public class TerminalConnectorPluginTest extends TestCase { if (!Platform.isRunning()) return; ConnectorMock mock = new ConnectorMock(); - TerminalConnector c = new TerminalConnector(new SimpleFactory(mock), "xID", "xName"); + TerminalConnector c = new TerminalConnector(new SimpleFactory(mock), "xID", "xName", false); assertNull(c.getAdapter(ConnectorMock.class)); // the load is called after the connect... c.connect(new TerminalControlMock()); diff --git a/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorTest.java b/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorTest.java index ffb0efe6700..93d555572e1 100644 --- a/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorTest.java +++ b/terminal/org.eclipse.tm.terminal.test/src/org/eclipse/tm/internal/terminal/connector/TerminalConnectorTest.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2008 Wind River Systems, Inc. and others. + * Copyright (c) 2007, 2009 Wind River Systems, Inc. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -9,6 +9,7 @@ * Michael Scharf (Wind River) - initial API and implementation * Martin Oberhuber (Wind River) - [225853][api] Provide more default functionality in TerminalConnectorImpl * Martin Oberhuber (Wind River) - [204796] Terminal should allow setting the encoding to use + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point *******************************************************************************/ package org.eclipse.tm.internal.terminal.connector; @@ -139,27 +140,27 @@ public class TerminalConnectorTest extends TestCase { } } public void testGetInitializationErrorMessage() { - TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName", false); c.connect(new TerminalControlMock()); assertNull(c.getInitializationErrorMessage()); c=new TerminalConnector(new SimpleFactory(new ConnectorMock(){ public void initialize() throws Exception { throw new Exception("FAILED"); - }}),"xID","xName"); + }}),"xID","xName", false); c.connect(new TerminalControlMock()); assertEquals("FAILED",c.getInitializationErrorMessage()); } public void testGetIdAndName() { - TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName", false); assertEquals("xID", c.getId()); assertEquals("xName", c.getName()); } public void testConnect() { - TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName", false); assertFalse(c.isInitialized()); c.connect(new TerminalControlMock()); assertTrue(c.isInitialized()); @@ -168,7 +169,7 @@ public class TerminalConnectorTest extends TestCase { public void testDisconnect() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); TerminalControlMock control=new TerminalControlMock(); c.connect(control); c.disconnect(); @@ -177,14 +178,14 @@ public class TerminalConnectorTest extends TestCase { public void testGetTerminalToRemoteStream() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); TerminalControlMock control=new TerminalControlMock(); c.connect(control); assertSame(mock.fControl,control); } public void testGetSettingsSummary() { - TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(new ConnectorMock()),"xID","xName", false); assertEquals("Not Initialized", c.getSettingsSummary()); c.connect(new TerminalControlMock()); assertEquals("Summary", c.getSettingsSummary()); @@ -192,7 +193,7 @@ public class TerminalConnectorTest extends TestCase { public void testIsLocalEcho() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); assertFalse(c.isLocalEcho()); mock.fEcho=true; assertTrue(c.isLocalEcho()); @@ -200,7 +201,7 @@ public class TerminalConnectorTest extends TestCase { public void testLoad() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); ISettingsStore s=new SettingsMock(); c.load(s); // the load is called after the connect... @@ -211,7 +212,7 @@ public class TerminalConnectorTest extends TestCase { public void testSave() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); ISettingsStore s=new SettingsMock(); c.save(s); assertNull(mock.fSaveStore); @@ -222,13 +223,13 @@ public class TerminalConnectorTest extends TestCase { public void testMakeSettingsPage() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); assertNotNull(c.makeSettingsPage()); } public void testSetTerminalSize() { ConnectorMock mock=new ConnectorMock(); - TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName"); + TerminalConnector c=new TerminalConnector(new SimpleFactory(mock),"xID","xName", false); c.setTerminalSize(100, 200); } diff --git a/terminal/org.eclipse.tm.terminal.view-feature/feature.xml b/terminal/org.eclipse.tm.terminal.view-feature/feature.xml index f52c6457efb..69143387e54 100644 --- a/terminal/org.eclipse.tm.terminal.view-feature/feature.xml +++ b/terminal/org.eclipse.tm.terminal.view-feature/feature.xml @@ -1,4 +1,5 @@ - - @@ -35,7 +36,7 @@ - + - + - + + + + + + @@ -34,9 +39,9 @@ - + - + @@ -49,9 +54,9 @@ A class extending TerminalConnectorImpl - + - + @@ -66,9 +71,16 @@ The name of the connection (used in the UI) - + - + + + + + + + When set to "true", the terminal connector will not be visible to the user in connector selections. + @@ -79,9 +91,9 @@ - + - + Copyright (c) 2006, 2008 Wind River Systems, Inc. and others. All rights reserved. This program and the accompanying materials @@ -92,6 +104,7 @@ http://www.eclipse.org/legal/epl-v10.html Contributors: Michael Scharf (Wind River) - initial API and implementation Martin Oberhuber (Wind River) - fixed copyright headers and beautified +Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point diff --git a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/connector/TerminalConnector.java b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/connector/TerminalConnector.java index b2439f6c204..86ebca265c1 100644 --- a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/connector/TerminalConnector.java +++ b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/connector/TerminalConnector.java @@ -1,5 +1,5 @@ /******************************************************************************* - * Copyright (c) 2007, 2008 Wind River Systems, Inc. and others. + * Copyright (c) 2007, 2009 Wind River Systems, Inc. and others. * All rights reserved. This program and the accompanying materials * are made available under the terms of the Eclipse Public License v1.0 * which accompanies this distribution, and is available at @@ -9,6 +9,7 @@ * Michael Scharf (Wind River) - initial API and implementation * Michael Scharf (Wind River) - [200541] Extract from TerminalConnectorExtension.TerminalConnectorProxy * Martin Oberhuber (Wind River) - [225853][api] Provide more default functionality in TerminalConnectorImpl + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point *******************************************************************************/ package org.eclipse.tm.internal.terminal.connector; @@ -75,6 +76,10 @@ public class TerminalConnector implements ITerminalConnector { * The unique id the connector */ private final String fId; + /** + * Flag to mark the connector as hidden. + */ + private final boolean fHidden; /** * The connector */ @@ -98,10 +103,11 @@ public class TerminalConnector implements ITerminalConnector { * this ID. * @param name translatable name to display the connector in the UI. */ - public TerminalConnector(TerminalConnector.Factory terminalConnectorFactory, String id, String name) { + public TerminalConnector(TerminalConnector.Factory terminalConnectorFactory, String id, String name, boolean hidden) { fTerminalConnectorFactory = terminalConnectorFactory; fId = id; fName = name; + fHidden = hidden; } public String getInitializationErrorMessage() { getConnectorImpl(); @@ -115,6 +121,9 @@ public class TerminalConnector implements ITerminalConnector { public String getName() { return fName; } + public boolean isHidden() { + return fHidden; + } private TerminalConnectorImpl getConnectorImpl() { if(!isInitialized()) { try { diff --git a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java index 978c4b89fee..8af3a10f71f 100644 --- a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java +++ b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/ITerminalConnector.java @@ -9,6 +9,7 @@ * Michael Scharf (Wind River) - initial API and implementation * Martin Oberhuber (Wind River) - fixed copyright headers and beautified * Martin Oberhuber (Wind River) - [261486][api][cleanup] Mark @noimplement interfaces as @noextend + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point *******************************************************************************/ package org.eclipse.tm.internal.terminal.provisional.api; @@ -59,6 +60,12 @@ public interface ITerminalConnector extends IAdaptable { * @since org.eclipse.tm.terminal 2.0 */ String getName(); + + /** + * @return True if the connector is not visible in user selections. + * @since org.eclipse.tm.terminal 3.1 + */ + boolean isHidden(); /** * @return true if the {@link TerminalConnectorImpl} has been initialized. diff --git a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalConnectorExtension.java b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalConnectorExtension.java index ee14c8117a6..fbd9cd7e50b 100644 --- a/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalConnectorExtension.java +++ b/terminal/org.eclipse.tm.terminal/src/org/eclipse/tm/internal/terminal/provisional/api/TerminalConnectorExtension.java @@ -8,6 +8,7 @@ * Contributors: * Michael Scharf (Wind River) - initial API and implementation * Martin Oberhuber (Wind River) - fixed copyright headers and beautified + * Uwe Stieber (Wind River) - [282996] [terminal][api] Add "hidden" attribute to terminal connector extension point *******************************************************************************/ package org.eclipse.tm.internal.terminal.provisional.api; @@ -44,11 +45,13 @@ public class TerminalConnectorExtension { if(name==null || name.length()==0) { name=id; } + String hidden = config.getAttribute("hidden"); //$NON-NLS-1$ + boolean isHidden = hidden != null ? Boolean.parseBoolean(hidden) : false; TerminalConnector.Factory factory=new TerminalConnector.Factory(){ public TerminalConnectorImpl makeConnector() throws Exception { return (TerminalConnectorImpl)config.createExecutableExtension("class"); //$NON-NLS-1$ }}; - return new TerminalConnector(factory,id,name); + return new TerminalConnector(factory,id,name, isHidden); } /**