From e9dfe3c1e994fd132445468023d8c5836df7787a Mon Sep 17 00:00:00 2001 From: Baltasar Belyavsky Date: Tue, 14 May 2013 13:21:55 -0400 Subject: [PATCH] Bug 405638 - [performance] CExternalSettingsManager causes all workspace project-descriptions to load prematurely Change-Id: I814835ce63b358dcab4349cd88f205b9dbe81c85 Reviewed-on: https://git.eclipse.org/r/11935 Reviewed-by: Andrew Gvozdev IP-Clean: Andrew Gvozdev Tested-by: Andrew Gvozdev --- .../core/settings/model/CExternalSettingsManager.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java index 6f8c9966869..b586062cc4a 100644 --- a/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java +++ b/core/org.eclipse.cdt.core/model/org/eclipse/cdt/internal/core/settings/model/CExternalSettingsManager.java @@ -8,6 +8,7 @@ * Contributors: * Intel Corporation - Initial API and implementation * James Blackburn (Broadcom Corp.) + * Baltasar Belyavsky (Texas Instruments) - [405638] CExternalSettingsManager causes all workspace project-descriptions to load prematurely *******************************************************************************/ package org.eclipse.cdt.internal.core.settings.model; @@ -481,7 +482,8 @@ public class CExternalSettingsManager implements ICExternalSettingsListener, ICP } private ProjDesCfgList createCfgList(IProject project, Set cfgIdSet){ - ICProjectDescription des = CProjectDescriptionManager.getInstance().getProjectDescription(project, false); + // ignore projects which haven't loaded yet - forcing them to load here is expensive and unnecessary [Bug 405638] + ICProjectDescription des = CProjectDescriptionManager.getInstance().getProjectDescription(project, false, false); if(des == null) return null;